public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: geniis <geniis@126.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] maybe a priority mistake in mpc85xx_cpu\init.c
Date: Thu, 21 Oct 2010 00:08:06 +0800 (CST)	[thread overview]
Message-ID: <1000d70.d8d1.12bca65bb27.Coremail.geniis@126.com> (raw)

hi,
 
    I notice that in "arch\powerpc\cpu\mpc85xx\cpu_init.c" line 193, version 2010.06:
if (! memctl->br1 & 1)
 
    The original intention is to check if V bit of BR1 is set or not, but the operator "!" has higher priority than "&" ,I think it should be changed to:
 
if (! (memctl->br1 & 1))
 
    please check this question, thanks!

             reply	other threads:[~2010-10-20 16:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-20 16:08 geniis [this message]
2010-10-26 10:14 ` [U-Boot] maybe a priority mistake in mpc85xx_cpu\init.c Detlev Zundel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1000d70.d8d1.12bca65bb27.Coremail.geniis@126.com \
    --to=geniis@126.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox