[U-Boot-Users] Patches

[U-Boot-Users] Patches

[Jonas Larsson]

I have a question regarding submitting patches.

Should I send them to the mailing list or to the patch
tracking system at sourceforge? I've submitted a patch
to sourcforge already.

The patch adds support for an environment variable 'arch'
which is passed as the ARM machine number to the kernel if
set. The u-boot behaviour is unchanged if 'arch' is not defined.

/ Jonas

[U-Boot-Users] Patches

[Marc Singer]

On Fri, Aug 15, 2003 at 02:21:48PM +0200, Jonas Larsson wrote:
> I have a question regarding submitting patches.
> 
> Should I send them to the mailing list or to the patch
> tracking system at sourceforge? I've submitted a patch
> to sourcforge already.
> 
> The patch adds support for an environment variable 'arch'
> which is passed as the ARM machine number to the kernel if
> set. The u-boot behaviour is unchanged if 'arch' is not defined.

That's an interesting idea, though I'm not sure I can see how it would
be valuable in practice.  Do you have systems where the hardware setup
is identitical but the ARM CPU is different?

[U-Boot-Users] Patches

[Jonas Larsson]

On Fri, 2003-08-15 at 17:19, Marc Singer wrote:
> On Fri, Aug 15, 2003 at 02:21:48PM +0200, Jonas Larsson wrote:
> > I have a question regarding submitting patches.
> > 
> > Should I send them to the mailing list or to the patch
> > tracking system at sourceforge? I've submitted a patch
> > to sourcforge already.
> > 
> > The patch adds support for an environment variable 'arch'
> > which is passed as the ARM machine number to the kernel if
> > set. The u-boot behaviour is unchanged if 'arch' is not defined.
> 
> That's an interesting idea, though I'm not sure I can see how it would
> be valuable in practice.  Do you have systems where the hardware setup
> is identitical but the ARM CPU is different?

Nope. The arch number specifies what kind of arm-board the kernel is
booting on. One kernel binary is in my case able to handle 3 different 
versions of boards (and its hard or dangerous to find out by probing
the board). The number is used to tell the kernel about how irq-lines
etc are wired on the board. Perhaps the name 'arch' is a bad choice, 
perhaps "arm-mach" is better.

/ Jonas 

[U-Boot-Users] Patches

[Marc Singer]

> > That's an interesting idea, though I'm not sure I can see how it would
> > be valuable in practice.  Do you have systems where the hardware setup
> > is identitical but the ARM CPU is different?
> 
> Nope. The arch number specifies what kind of arm-board the kernel is
> booting on. One kernel binary is in my case able to handle 3 different 
> versions of boards (and its hard or dangerous to find out by probing
> the board). The number is used to tell the kernel about how irq-lines
> etc are wired on the board. Perhaps the name 'arch' is a bad choice, 
> perhaps "arm-mach" is better.
> 

Yes, I understand that.  It is also important that the board setup be
compatible which is the responsibility of uboot.  Which seems to be
true in your case.  None of the Arm chips I've used have this feature.
While they can be dynamically detected without danger, it is just as
easy to make separate u-boot builds for each.

Which chips are you using?

[U-Boot-Users] Patches

[Jonas Larsson]

On Fri, 2003-08-15 at 17:50, Marc Singer wrote:
> > > That's an interesting idea, though I'm not sure I can see how it would
> > > be valuable in practice.  Do you have systems where the hardware setup
> > > is identitical but the ARM CPU is different?
> > 
> > Nope. The arch number specifies what kind of arm-board the kernel is
> > booting on. One kernel binary is in my case able to handle 3 different 
> > versions of boards (and its hard or dangerous to find out by probing
> > the board). The number is used to tell the kernel about how irq-lines
> > etc are wired on the board. Perhaps the name 'arch' is a bad choice, 
> > perhaps "arm-mach" is better.
> > 
> 
> Yes, I understand that.  It is also important that the board setup be
> compatible which is the responsibility of uboot.  Which seems to be
> true in your case.  None of the Arm chips I've used have this feature.
> While they can be dynamically detected without danger, it is just as
> easy to make separate u-boot builds for each.
> 
> Which chips are you using?

I'm working on an U-boot port to StrongARM (SA110) [ensa285]. Our 
board are based the ebsa285 eval board but are in some parts different
(such as irq-mapping to networking chips). It is quite easy to have the
same kernel for all the boards and handle the differences with the 
machine number. I cannot detect the board type in u-boot, hence
I added the arch env variable.

For sure I could hard-code each mach nbr in my board dependent code at
compile time. But this would mean more release management on my behalf.
With the arch env its just a factory setting to be made.

I will submit a patch for the ebsa285 eval board later on. 

Whats your preference: patch system at sourceforge or mailing list?  

/ Jonas

[U-Boot-Users] Patches

[Marc Singer]

> For sure I could hard-code each mach nbr in my board dependent code at
> compile time. But this would mean more release management on my behalf.
> With the arch env its just a factory setting to be made.

I can see what you mean.

BTW, 'arm-arch' or 'arm-arch-number' is probably a better name for the
variable than 'arch'.

> I will submit a patch for the ebsa285 eval board later on. 

Excellent.

> Whats your preference: patch system at sourceforge or mailing list?  

Read the ./README section called "Submitting Patches".

Cheers.

[U-Boot-Users] Patches

[Wolfgang Denk]

In message <1060963480.26299.67.camel@doris> you wrote:
>
> Whats your preference: patch system at sourceforge or mailing list?  

Mailing list, please.

If I'd knew how to do that I'd turn of the SF features as I find them
difficult to use, so I tend to ignore them.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
"May the forces of evil become confused on the way to your house."
- George Carlin

[U-Boot-Users] patches

[Matthew S. McClintock]

Here are some patches..

u-boot-startchg.patch: this patches changes what I was talking about in 
the message (whoops, it was an html message) I sent to the list earlier.

u-boot-utxchg.patch: these are changes for our board that brings u-boot 
upto date with what we have here

If you have any questions don't hesistate to ask.

Thanks,
Matthew
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: u-boot-startchg.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20030528/3bd0b9d7/attachment.txt 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: u-boot-utxchg.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20030528/3bd0b9d7/attachment-0001.txt 

[U-Boot-Users] patches

[Wolfgang Denk]

Dear Matthew,

in message <3ED51F22.4010608@arlut.utexas.edu> you wrote:
> 
> Here are some patches..
> 
> u-boot-startchg.patch: this patches changes what I was talking about in 
> the message (whoops, it was an html message) I sent to the list earlier.

Please add an entry for the CHANGELOG file.

> u-boot-utxchg.patch: these are changes for our board that brings u-boot 
> upto date with what we have here
> 
> If you have any questions don't hesistate to ask.

I hesitate to apply a patch that throws out copyright notes:

> +++ ./board/utx8245/flash.c	2003-05-28 14:38:13.002469000 -0500
> @@ -2,11 +2,6 @@
>   * (C) Copyright 2001
>   * Wolfgang Denk, DENX Software Engineering, wd at denx.de.
>   *
> - * (C) Copyright 2002
> - * Gregory E. Allen, gallen at arlut.utexas.edu
> - * Matthew E. Karger, karger at arlut.utexas.edu
> - * Applied Research Laboratories, The University of Texas at Austin
> - *
>   * See file CREDITS for list of people who contributed to this
>   * project.
>   *

Can you please explain if this is really OK?

Also, the CHANGELOG entry is missing.

And please don't add trailing  white  space.  Please  clean  up,  and
re-submit.


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
All your people must learn before you can reach for the stars.
	-- Kirk, "The Gamesters of Triskelion", stardate 3259.2

[U-Boot-Users] patches

[Matthew S. McClintock]

Here are the changes you requested, if there is anything else that needs 
to be changed don't hesitate to let me know.

Thanks,
Matthew

Wolfgang Denk wrote:
> Dear Matthew,
> 
> in message <3ED51F22.4010608@arlut.utexas.edu> you wrote:
> 
>>Here are some patches..
>>
>>u-boot-startchg.patch: this patches changes what I was talking about in 
>>the message (whoops, it was an html message) I sent to the list earlier.
> 
> 
> Please add an entry for the CHANGELOG file.
> 
> 
>>u-boot-utxchg.patch: these are changes for our board that brings u-boot 
>>upto date with what we have here
>>
>>If you have any questions don't hesistate to ask.
> 
> 
> I hesitate to apply a patch that throws out copyright notes:
> 
> 
>>+++ ./board/utx8245/flash.c	2003-05-28 14:38:13.002469000 -0500
>>@@ -2,11 +2,6 @@
>>  * (C) Copyright 2001
>>  * Wolfgang Denk, DENX Software Engineering, wd at denx.de.
>>  *
>>- * (C) Copyright 2002
>>- * Gregory E. Allen, gallen at arlut.utexas.edu
>>- * Matthew E. Karger, karger at arlut.utexas.edu
>>- * Applied Research Laboratories, The University of Texas at Austin
>>- *
>>  * See file CREDITS for list of people who contributed to this
>>  * project.
>>  *
> 
> 
> Can you please explain if this is really OK?
> 
> Also, the CHANGELOG entry is missing.
> 
> And please don't add trailing  white  space.  Please  clean  up,  and
> re-submit.
> 
> 
> Best regards,
> 
> Wolfgang Denk
> 

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: u-boot-startchg.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20030528/964ef2ae/attachment.txt 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: u-boot-utxchg.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20030528/964ef2ae/attachment-0001.txt