From: Dave Liu <r63238@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH v1 2/5] ATA: Add the libata support
Date: Wed, 19 Mar 2008 17:08:59 +0800 [thread overview]
Message-ID: <1205917739.3654.81.camel@localhost.localdomain> (raw)
In-Reply-To: <PWN74WD6.1205919334.9849270.tor@localhost>
On Wed, 2008-03-19 at 09:35 +0000, Tor Krill wrote:
> After some further work with these pathces. (I currently work on a
> SIL3114 driver using them)
>
> It seems like there is a "lot" of code duplication in libata.h and the
> existant ata.h. Thus making it impossible to include both ones. Which i
> would like to do.
Yes, it is my one concern.
My another concern is, the common dir originally have one cmd_sata.c.
However, the cmd_sata.c is not generic.
Wolfgang,
How do we handle it?
> Pasted below is the modifications i did to do to get it working.
>
> Could one perhaps merge the differences? Or is there other suggestions on
> how to solve this?
So, Wolfgang,
Can we merge the new stuff from libata.h to ata.h?
Thanks,
Dave
next prev parent reply other threads:[~2008-03-19 9:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-16 8:33 [U-Boot-Users] [PATCH v1 2/5] ATA: Add the libata support Dave Liu
2008-03-17 21:55 ` Tor Krill
2008-03-19 9:35 ` Tor Krill
2008-03-19 9:08 ` Dave Liu [this message]
2008-03-19 12:14 ` Wolfgang Denk
2008-03-19 12:06 ` Wolfgang Denk
2008-03-19 13:16 ` Tor Krill
2008-03-19 12:23 ` Liu Dave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205917739.3654.81.camel@localhost.localdomain \
--to=r63238@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox