public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tor Krill <tor@excito.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous.
Date: Thu, 24 Jun 2010 13:34:50 +0200	[thread overview]
Message-ID: <1277379290.1861.103.camel@tor-desktop> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19A4A0206E@SC-VEXCH4.marvell.com>


Hi Prafulla,

On Thu, 2010-06-24 at 13:22 +0200, Prafulla Wadaskar wrote:
> 
> > -----Original Message-----
> > From: Tor Krill [mailto:tor at excito.com] 
> > Sent: Thursday, June 24, 2010 3:02 PM
> > To: u-boot at lists.denx.de
> > Cc: Prafulla Wadaskar; Tor Krill
> > Subject: [PATCH V2] Allow PHY addresses on kirkwood egiga to 
> > be non continuous.
> > 
> > Changing its configuration from PHY_BASE_ADR single value to use
> > CONFIG_PHY_BASE_ADDRS as an array with adresses.
> > 
> > Updated in version 2:
> > 
> > Merged board updates to single patch.
> 
> These two lines should go as changelog for v2 below (after ---)

Sorry, there seems to be no end on my mistakes :(

> > 
> > Signed-off-by: Tor Krill <tor@excito.com>
> > ---
> i.e. here..
> 
> >  board/keymile/km_arm/km_arm.c |    3 ++-
> >  drivers/net/kirkwood_egiga.c  |    3 ++-
> >  drivers/net/kirkwood_egiga.h  |    8 ++++----
> >  include/configs/guruplug.h    |    2 +-
> >  include/configs/km_arm.h      |    2 +-
> >  include/configs/openrd_base.h |    2 +-
> >  include/configs/rd6281a.h     |    2 +-
> >  include/configs/sheevaplug.h  |    2 +-
> >  8 files changed, 13 insertions(+), 11 deletions(-)
> 
> Hi Tom
> I understood your problem.
> But all of the Kirkwood boards so far have similar implementation which is standard practice.
> How does your board design differed in this case?
> 
> Instead of fixing it here for all other boards,
> can't you simply align PHY address on your board?
> I think this will be much easier.

We use both ethernet interfaces by default in our design, with the phy
addresses 0x08 and 0x18, and unfortunately we have already started the
manufacturing of these units which makes it expensive and hard to
reverse this design decision :(  

But if we turn this around if the hardware allows this then why not let
this be configurable in u-boot as well? Do this have any technical
implications on the other boards? 

Best Regards,

/Tor

  reply	other threads:[~2010-06-24 11:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-24  9:31 [U-Boot] [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous Tor Krill
2010-06-24 11:22 ` Prafulla Wadaskar
2010-06-24 11:34   ` Tor Krill [this message]
2010-06-24 16:37 ` Mike Frysinger
2010-06-24 16:48   ` Albert ARIBAUD
2010-06-24 16:53     ` Mike Frysinger
2010-06-28  9:20   ` Tor Krill
     [not found] <F766E4F80769BD478052FB6533FA745D19A4A02082@SC-VEXCH4.marvell.com>
2010-06-28  9:11 ` Tor Krill
2010-06-28 12:02   ` Wolfgang Denk
2010-06-28 17:44     ` Prafulla Wadaskar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1277379290.1861.103.camel@tor-desktop \
    --to=tor@excito.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox