From: Tor Krill <tor@excito.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous.
Date: Mon, 28 Jun 2010 11:20:32 +0200 [thread overview]
Message-ID: <1277716832.2221.46.camel@tor-desktop> (raw)
In-Reply-To: <201006241237.43140.vapier@gentoo.org>
On Thu, 2010-06-24 at 18:37 +0200, Mike Frysinger wrote:
> On Thursday, June 24, 2010 05:31:47 Tor Krill wrote:
> > void reset_phy(void)
> > {
> > char *name = "egiga0";
> > + u8 port_addr[] = CONFIG_PHY_ADDRS;
> >
> > if (miiphy_set_current_dev(name))
> > return;
> >
> > /* reset the phy */
> > - miiphy_reset(name, CONFIG_PHY_BASE_ADR);
> > + miiphy_reset(name, port_addr[0]);
> > }
>
> hmm, this cant possibly be correct. how do you know which of the phys is to
> be reset ? but i guess that's just a bug in the ARM tree you cant do much
> about without fixing everyone.
In the original the base adress was used to adress the PHY being reset
and as long as you don't enter the addresses in reverse in the array the
above construction should work. (And since this is for a specific board,
only using one PHY(?), it should be quite isolated.)
/Tor
next prev parent reply other threads:[~2010-06-28 9:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 9:31 [U-Boot] [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous Tor Krill
2010-06-24 11:22 ` Prafulla Wadaskar
2010-06-24 11:34 ` Tor Krill
2010-06-24 16:37 ` Mike Frysinger
2010-06-24 16:48 ` Albert ARIBAUD
2010-06-24 16:53 ` Mike Frysinger
2010-06-28 9:20 ` Tor Krill [this message]
[not found] <F766E4F80769BD478052FB6533FA745D19A4A02082@SC-VEXCH4.marvell.com>
2010-06-28 9:11 ` Tor Krill
2010-06-28 12:02 ` Wolfgang Denk
2010-06-28 17:44 ` Prafulla Wadaskar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277716832.2221.46.camel@tor-desktop \
--to=tor@excito.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox