From: Maxim Cournoyer <maxim.cournoyer@savoirfairelinux.com>
To: Sjoerd Simons <sjoerd@collabora.com>
Cc: Simon Glass <sjg@chromium.org>,
Maxim Cournoyer <maxim.cournoyer@gmail.com>,
U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH v3 3/8] patman: invoke the checkpatch.pl script with '--u-boot' and '--strict'
Date: Fri, 13 Jan 2023 08:54:39 -0500 (EST) [thread overview]
Message-ID: <1278481656.163511.1673618079166.JavaMail.zimbra@savoirfairelinux.com> (raw)
In-Reply-To: <b5f781689797bf17c7347100050a451f035b8a06.camel@collabora.com>
Hi Sjoerd,
----- Original Message -----
> From: "Sjoerd Simons" <sjoerd@collabora.com>
> To: "Simon Glass" <sjg@chromium.org>, "Maxim Cournoyer" <maxim.cournoyer@gmail.com>
> Cc: "Maxim Cournoyer" <maxim.cournoyer@savoirfairelinux.com>, "U-Boot Mailing List" <u-boot@lists.denx.de>
> Sent: Friday, January 13, 2023 5:19:39 AM
> Subject: Re: [PATCH v3 3/8] patman: invoke the checkpatch.pl script with '--u-boot' and '--strict'
> Hey,
>
> This breaks using patman for linux as it's check-patch has no clue
> about `--u-boot` :). I'm not sure if people using patman for linux
> patches is meant to be a supported use-case though (the documentation
> seems to indicate it is)
Sorry for the breakage, and thank you for reporting it! I had overlooked that. I've reverted that commit and fixed the test suite via symlinking the top level .checkpatch.conf to tools/patman/.checkpatch.conf instead, which seems to work.
You are CC'd to that change [0], in case you'd like to test it in your environment.
Thank you,
Maxim
[0] https://patchwork.ozlabs.org/project/uboot/patch/20230113135051.22738-2-maxim.cournoyer@savoirfairelinux.com/
next prev parent reply other threads:[~2023-01-13 20:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 22:32 [PATCH v3 1/8] patman: cosmetic: Fix PEP 8 warnings for the gitutil module Maxim Cournoyer
2022-12-19 22:32 ` [PATCH v3 2/8] patman: locate test data files via __file__ and pathlib Maxim Cournoyer
2022-12-21 0:28 ` Simon Glass
2022-12-19 22:32 ` [PATCH v3 3/8] patman: invoke the checkpatch.pl script with '--u-boot' and '--strict' Maxim Cournoyer
2022-12-21 0:28 ` Simon Glass
2023-01-13 10:19 ` Sjoerd Simons
2023-01-13 13:54 ` Maxim Cournoyer [this message]
2022-12-19 22:32 ` [PATCH v3 4/8] patman: rename main script to __main__.py Maxim Cournoyer
2022-12-21 0:28 ` Simon Glass
2022-12-21 0:30 ` Simon Glass
2022-12-19 22:32 ` [PATCH v3 5/8] patman: add pytest configuration file Maxim Cournoyer
2022-12-21 0:28 ` Simon Glass
2022-12-19 22:32 ` [PATCH v3 6/8] patman: hide the 'test' command unless test data is available Maxim Cournoyer
2022-12-21 0:28 ` Simon Glass
2022-12-19 22:32 ` [PATCH v3 7/8] patman: document how to run test suite via pytest Maxim Cournoyer
2022-12-21 0:28 ` Simon Glass
2022-12-19 22:32 ` [PATCH v3 8/8] patman: document default 'send' command Maxim Cournoyer
2022-12-21 0:28 ` Simon Glass
2022-12-21 0:28 ` [PATCH v3 1/8] patman: cosmetic: Fix PEP 8 warnings for the gitutil module Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278481656.163511.1673618079166.JavaMail.zimbra@savoirfairelinux.com \
--to=maxim.cournoyer@savoirfairelinux.com \
--cc=maxim.cournoyer@gmail.com \
--cc=sjg@chromium.org \
--cc=sjoerd@collabora.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox