public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sjoerd Simons <sjoerd@collabora.com>
To: Simon Glass <sjg@chromium.org>,
	Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: Maxim Cournoyer <maxim.cournoyer@savoirfairelinux.com>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH v3 3/8] patman: invoke the checkpatch.pl script with '--u-boot' and '--strict'
Date: Fri, 13 Jan 2023 11:19:39 +0100	[thread overview]
Message-ID: <b5f781689797bf17c7347100050a451f035b8a06.camel@collabora.com> (raw)
In-Reply-To: <CAPnjgZ0-njbz8n4DyUye5RrXJ2Q_UFLxpRKcw-Lu6JsS8kvxaQ@mail.gmail.com>

Hey,

This breaks using patman for linux as it's check-patch has no clue
about `--u-boot` :).  I'm not sure if people using patman for linux
patches is meant to be a supported use-case though (the documentation
seems to indicate it is)


On Wed, 2022-12-21 at 00:28 +0000, Simon Glass wrote:
> This resolves 10 out of 11 test failures seen when running './patman
> test' from the 'tools/patman' subdirectory. This was caused by the
> .checkpatch.conf configuration file at the root of the project not
> being picked up. Make the test suite of patman independent from it by
> always invoking the checkpatch.pl script with the minimally required
> arguments for the test suite to pass.
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Maxim Cournoyer <maxim.cournoyer@savoirfairelinux.com>
> ---
> 
> Changes in v3:
> - Fix typo in commit message
> 
> Changes in v2:
> - Reword the commit message with a better explanation of the problem
> - Add the '--strict' argument to script invocation
> 
>  tools/patman/checkpatch.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied to u-boot-dm/next, thanks!

-- 
Sjoerd Simons
Collabora Ltd.

  reply	other threads:[~2023-01-13 10:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19 22:32 [PATCH v3 1/8] patman: cosmetic: Fix PEP 8 warnings for the gitutil module Maxim Cournoyer
2022-12-19 22:32 ` [PATCH v3 2/8] patman: locate test data files via __file__ and pathlib Maxim Cournoyer
2022-12-21  0:28   ` Simon Glass
2022-12-19 22:32 ` [PATCH v3 3/8] patman: invoke the checkpatch.pl script with '--u-boot' and '--strict' Maxim Cournoyer
2022-12-21  0:28   ` Simon Glass
2023-01-13 10:19     ` Sjoerd Simons [this message]
2023-01-13 13:54       ` Maxim Cournoyer
2022-12-19 22:32 ` [PATCH v3 4/8] patman: rename main script to __main__.py Maxim Cournoyer
2022-12-21  0:28   ` Simon Glass
2022-12-21  0:30     ` Simon Glass
2022-12-19 22:32 ` [PATCH v3 5/8] patman: add pytest configuration file Maxim Cournoyer
2022-12-21  0:28   ` Simon Glass
2022-12-19 22:32 ` [PATCH v3 6/8] patman: hide the 'test' command unless test data is available Maxim Cournoyer
2022-12-21  0:28   ` Simon Glass
2022-12-19 22:32 ` [PATCH v3 7/8] patman: document how to run test suite via pytest Maxim Cournoyer
2022-12-21  0:28   ` Simon Glass
2022-12-19 22:32 ` [PATCH v3 8/8] patman: document default 'send' command Maxim Cournoyer
2022-12-21  0:28   ` Simon Glass
2022-12-21  0:28 ` [PATCH v3 1/8] patman: cosmetic: Fix PEP 8 warnings for the gitutil module Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5f781689797bf17c7347100050a451f035b8a06.camel@collabora.com \
    --to=sjoerd@collabora.com \
    --cc=maxim.cournoyer@gmail.com \
    --cc=maxim.cournoyer@savoirfairelinux.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox