public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [u-boot-release] [Patch v2] powerpc/eeprom: cleanup mac command
Date: Thu, 11 Aug 2011 09:35:30 -0500	[thread overview]
Message-ID: <1313073330.5224.9.camel@oslab-l1> (raw)
In-Reply-To: <4E432FFE.9040308@freescale.com>

On Wed, 2011-08-10 at 20:27 -0500, Tabi Timur-B04825 wrote:
> York Sun wrote:
> > Change the help message to be more helpful. Print argument format.
> > Fix MAX_NUM_PORTS to comply with v1 NXID format.
> >
> > Signed-off-by: York Sun<yorksun@freescale.com>
> 
> Could you also fix the commands so that they take a number in decimal 
> instead of hex?
> 
> 
>          e.mac[index][i] = simple_strtoul(p, &p, 16);
> 
> ...
> 
> 	e.mac_count = simple_strtoul(argv[2], NULL, 16);
> 
> I know U-Boot uses hex for everything, but it doesn't make sense for 
> this command.


Yes, I can change it. But not all of them. We use hexadecimal for mac
address but not the count of ports. Please comment on my next version.

York

      parent reply	other threads:[~2011-08-11 14:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10 14:56 [U-Boot] [Patch v2] powerpc/eeprom: cleanup mac command York Sun
2011-08-11  1:27 ` [U-Boot] [u-boot-release] " Tabi Timur-B04825
2011-08-11  1:34   ` Mike Frysinger
2011-08-11 14:35   ` York Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313073330.5224.9.camel@oslab-l1 \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox