From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [u-boot-release] [Patch v2] powerpc/eeprom: cleanup mac command
Date: Wed, 10 Aug 2011 21:34:29 -0400 [thread overview]
Message-ID: <201108102134.30546.vapier@gentoo.org> (raw)
In-Reply-To: <4E432FFE.9040308@freescale.com>
On Wednesday, August 10, 2011 21:27:28 Tabi Timur-B04825 wrote:
> York Sun wrote:
> > Change the help message to be more helpful. Print argument format.
> > Fix MAX_NUM_PORTS to comply with v1 NXID format.
> >
> > Signed-off-by: York Sun<yorksun@freescale.com>
>
> Could you also fix the commands so that they take a number in decimal
> instead of hex?
>
>
> e.mac[index][i] = simple_strtoul(p, &p, 16);
>
> ...
>
> e.mac_count = simple_strtoul(argv[2], NULL, 16);
>
> I know U-Boot uses hex for everything, but it doesn't make sense for
> this command.
change it to 0 and then both should work
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110810/07f1559c/attachment.pgp
next prev parent reply other threads:[~2011-08-11 1:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 14:56 [U-Boot] [Patch v2] powerpc/eeprom: cleanup mac command York Sun
2011-08-11 1:27 ` [U-Boot] [u-boot-release] " Tabi Timur-B04825
2011-08-11 1:34 ` Mike Frysinger [this message]
2011-08-11 14:35 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108102134.30546.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox