public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v7 24/29] SPL: Add option to skip copying of the mkimage header
Date: Mon, 24 Sep 2012 17:31:02 -0700	[thread overview]
Message-ID: <1348533068-13038-25-git-send-email-trini@ti.com> (raw)
In-Reply-To: <1348533068-13038-1-git-send-email-trini@ti.com>

From: Stefan Roese <sr@denx.de>

On some system (e.g. powerpc), the load-address and entry-point is
located at address 0. So the current approach to load the image
(payload) including the header to the address "load-address - 64"
can't work here.

This patch adds an flag to skip this copying including header to
the SPL framework. By setting SPL_COPY_PAYLOAD_ONLY, only the
playload will be copied. This will be used by the SPL NOR flash
driver on powerpc.

Signed-off-by: Stefan Roese <sr@denx.de>
Signed-off-by: Tom Rini <trini@ti.com>
---

 common/spl/spl.c |   21 +++++++++++++++++----
 include/spl.h    |    3 +++
 2 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/common/spl/spl.c b/common/spl/spl.c
index 3156401..95dd9d5 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -76,10 +76,23 @@ void spl_parse_image_header(const struct image_header *header)
 	u32 header_size = sizeof(struct image_header);
 
 	if (image_get_magic(header) == IH_MAGIC) {
-		spl_image.size = image_get_data_size(header) + header_size;
-		spl_image.entry_point = image_get_load(header);
-		/* Load including the header */
-		spl_image.load_addr = spl_image.entry_point - header_size;
+		if (spl_image.flags & SPL_COPY_PAYLOAD_ONLY) {
+			/*
+			 * On some system (e.g. powerpc), the load-address and
+			 * entry-point is located at address 0. We can't load
+			 * to 0-0x40. So skip header in this case.
+			 */
+			spl_image.load_addr = image_get_load(header);
+			spl_image.entry_point = image_get_ep(header);
+			spl_image.size = image_get_data_size(header);
+		} else {
+			spl_image.entry_point = image_get_load(header);
+			/* Load including the header */
+			spl_image.load_addr = spl_image.entry_point -
+				header_size;
+			spl_image.size = image_get_data_size(header) +
+				header_size;
+		}
 		spl_image.os = image_get_os(header);
 		spl_image.name = image_get_name(header);
 		debug("spl: payload image: %s load addr: 0x%x size: %d\n",
diff --git a/include/spl.h b/include/spl.h
index e405386..cf441a1 100644
--- a/include/spl.h
+++ b/include/spl.h
@@ -38,8 +38,11 @@ struct spl_image_info {
 	u32 load_addr;
 	u32 entry_point;
 	u32 size;
+	u32 flags;
 };
 
+#define SPL_COPY_PAYLOAD_ONLY	1
+
 extern struct spl_image_info spl_image;
 extern u32 *boot_params_ptr;
 
-- 
1.7.9.5

  parent reply	other threads:[~2012-09-25  0:31 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25  0:30 [U-Boot] [PATCH v7 0/29] ARM: SPL: Make more generic, merge DaVinci and OMAP Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 01/29] Makefile: Move SPL files to clobber, remove from clean Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 02/29] spl_mmc: Make FAT checks / calls guarded with CONFIG_SPL_FAT_SUPPORT Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 03/29] omap-common: SPL: Add CONFIG_SPL_DISPLAY_PRINT / spl_display_print() Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 04/29] omap-common: Fix typo in save_boot_params() in lowlevel_init.S Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 05/29] omap-common: SPL: Fix whitespace in omap-common/u-boot-spl.lds Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 06/29] ARM: SPL: Rename omap_boot_device to spl_boot_device Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 07/29] ARM: SPL: Rename omap_boot_mode to spl_boot_mode() Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 08/29] ARM: SPL: Remove NAND_MODE_HW_ECC from spl_nand.c Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 09/29] ARM: SPL: Only call mem_malloc_init if configured Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 10/29] ARM: SPL: Add <asm/spl.h> and <asm/arch/spl.h> Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 11/29] ARM: SPL: Make spl_mmc.c more generic Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 12/29] ARM: SPL: Clean up spl.c / spl_nand.c slightly Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 13/29] ARM: SPL: Start hooking in the current SPI SPL support Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 14/29] ARM: SPL: Move gpmc_init() to spl_board_init() Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 15/29] SPL: Move the omap SPL framework to common/spl Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 16/29] SPL: Create arch/arm/lib/spl.c for board_init_f and jump_to_image_linux Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 17/29] SPL: do not use fix value for u-boot size Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 18/29] SPL: Use image_get_xxx() functions to access header values Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 19/29] SPL: NAND: Move arch/arm/cpu/armv7/omap-common/spl_nand.c to common/spl Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 20/29] ARM: SPL: Convert davinci to CONFIG_SPL_FRAMEWORK Tom Rini
2012-09-27 18:20   ` Tom Rini
2012-09-25  0:30 ` [U-Boot] [PATCH v7 21/29] hawkboard: Update config file to work with common spl framework Tom Rini
2012-09-25  0:31 ` [U-Boot] [PATCH v7 22/29] da850: Add README.da850 Tom Rini
2012-09-25  0:31 ` [U-Boot] [PATCH v7 23/29] SPL: Add NOR flash booting support Tom Rini
2012-09-25  0:31 ` Tom Rini [this message]
2012-09-25  0:31 ` [U-Boot] [PATCH v7 25/29] SPL: SPI: Enhance spi_spl_load to match the other load functions Tom Rini
2012-09-25  0:31 ` [U-Boot] [PATCH v7 26/29] SPL: Enable use of custom defined U-Boot entry point Tom Rini
2012-09-25  0:31 ` [U-Boot] [PATCH v7 27/29] SPL: Make un-supported boot device puts a debug instead Tom Rini
2012-09-25  0:31 ` [U-Boot] [PATCH v7 28/29] SPL: Rework how we inform about un-headered images Tom Rini
2012-09-25  0:31 ` [U-Boot] [PATCH v7 29/29] SPL: Add support for loading image from ram in SPL Tom Rini
2012-09-27 20:04 ` [U-Boot] [PATCH v7 0/29] ARM: SPL: Make more generic, merge DaVinci and OMAP Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348533068-13038-25-git-send-email-trini@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox