From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 02/17] arm: mvebu: Add gpio support
Date: Thu, 1 Dec 2016 09:26:32 +0100 [thread overview]
Message-ID: <13535b7b-2b63-ae43-5e4f-ceea7c0eb6be@denx.de> (raw)
In-Reply-To: <c75146d6cfad3055dc4043d2f75c2286e3c0cd2f.1479913469.git.mario.six@gdsys.cc>
Hi Mario,
sorry for the late review. A few comments now to the patch
series...
On 23.11.2016 16:12, Mario Six wrote:
> From: Dirk Eibach <dirk.eibach@gdsys.cc>
>
> Add driver interface functions for the GPIO controller on the mvebu
> architecture (based on kirkwood).
>
> Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc>
> ---
> arch/arm/mach-mvebu/include/mach/gpio.h | 41 +++++++++++++++++++++++++++++++--
> 1 file changed, 39 insertions(+), 2 deletions(-)
This is no "real" GPIO driver but only adds to the old GPIO
infrastructure. I've added a DM based GPIO driver for MVEBU quite
a while ago:
drivers/gpio/mvebu_gpio.c
Could you please try to use this driver instead? If something
is missing in this driver then please extend this DM driver.
Thanks,
Stefan
next prev parent reply other threads:[~2016-12-01 8:26 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 15:12 [U-Boot] [PATCH 00/17] arm: mvebu: Add gdsys ControlCenter-Compact board Mario Six
2016-11-23 15:12 ` [U-Boot] [PATCH 01/17] pci: mvebu: Fix Armada 38x support Mario Six
2016-11-23 15:12 ` [U-Boot] [PATCH 02/17] arm: mvebu: Add gpio support Mario Six
2016-12-01 8:26 ` Stefan Roese [this message]
2016-11-23 15:12 ` [U-Boot] [PATCH 03/17] net: phy: Support Marvell 88E1680 Mario Six
2016-11-29 23:00 ` Joe Hershberger
2016-12-01 11:01 ` Dirk Eibach
2016-11-23 15:12 ` [U-Boot] [PATCH 04/17] mvebu: Add board_pex_config() Mario Six
2016-12-01 8:30 ` Stefan Roese
2016-12-01 10:55 ` Dirk Eibach
2016-11-23 15:12 ` [U-Boot] [PATCH 05/17] arm: mvebu: spl.c: Remove useless gd declaration Mario Six
2016-11-23 15:12 ` [U-Boot] [PATCH 06/17] dm: Add callback to modify the device tree Mario Six
2016-12-01 8:39 ` Stefan Roese
2016-12-05 6:24 ` Simon Glass
2016-12-05 15:32 ` Mario Six
2016-12-07 3:47 ` Simon Glass
2016-12-05 9:47 ` Maxime Ripard
2016-11-23 15:12 ` [U-Boot] [PATCH 07/17] lib: tpm: Add command to flush resources Mario Six
2016-12-01 8:42 ` Stefan Roese
2016-12-05 6:24 ` Simon Glass
2016-12-05 14:50 ` Mario Six
2016-11-23 15:12 ` [U-Boot] [PATCH 08/17] tools: kwbimage: Fix dest addr Mario Six
2016-11-23 15:12 ` [U-Boot] [PATCH 09/17] tools: kwbimage: Fix style violations Mario Six
2016-11-23 15:12 ` [U-Boot] [PATCH 10/17] tools: kwbimage: Fix arithmetic with void pointers Mario Six
2016-11-23 15:12 ` [U-Boot] [PATCH 11/17] tools: kwbimage: Reduce scope of variables Mario Six
2016-11-23 15:12 ` [U-Boot] [PATCH 12/17] tools: kwbimage: Remove unused parameter Mario Six
2016-11-23 15:12 ` [U-Boot] [PATCH 13/17] tools: kwbimage: Factor out add_binary_header_v1 Mario Six
2016-11-23 15:12 ` [U-Boot] [PATCH 14/17] tools: kwbimage: Refactor line parsing and fix error Mario Six
2016-11-23 15:12 ` [U-Boot] [PATCH 15/17] arm: mvebu: Implement secure boot Mario Six
2016-12-01 9:15 ` Stefan Roese
2016-12-07 7:23 ` Mario Six
2016-11-23 15:12 ` [U-Boot] [PATCH 16/17] arm: mvebu: Add gdsys ControlCenter-Compact board Mario Six
2016-12-01 9:57 ` Stefan Roese
2016-12-02 9:34 ` Mario Six
2016-11-23 15:12 ` [U-Boot] [PATCH 17/17] controlcenterdc: Make secure boot available Mario Six
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13535b7b-2b63-ae43-5e4f-ceea7c0eb6be@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox