From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/7] usb: ehci: Fix aliasing issue in EHCI interrupt code
Date: Thu, 13 Dec 2012 18:21:29 -0800 [thread overview]
Message-ID: <1355451692-28017-5-git-send-email-sjg@chromium.org> (raw)
In-Reply-To: <1355451692-28017-1-git-send-email-sjg@chromium.org>
From: Vincent Palatin <vpalatin@chromium.org>
The interrupt endpoint handling code stores the buffer pointer in the QH
padding field. We need to make it the size of a pointer to avoid strict
aliasing issue with the compiler.
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v2: None
drivers/usb/host/ehci.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index 8bc2ba1..5370eb0 100644
--- a/drivers/usb/host/ehci.h
+++ b/drivers/usb/host/ehci.h
@@ -247,7 +247,7 @@ struct QH {
* aligned to 32 bytes
*/
union {
- uint8_t fill[16];
+ uint32_t fill[4];
void *buffer;
};
};
--
1.7.7.3
next prev parent reply other threads:[~2012-12-14 2:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 2:21 [U-Boot] [PATCH v2 0/7] Various USB improvements Simon Glass
2012-12-14 2:21 ` [U-Boot] [PATCH v2 1/7] usb: net: asix: Do a fast init if link already established Simon Glass
2012-12-21 2:29 ` Joe Hershberger
2013-02-17 6:47 ` Simon Glass
2013-02-17 21:39 ` Joe Hershberger
2013-02-17 21:43 ` Simon Glass
2012-12-14 2:21 ` [U-Boot] [PATCH v2 2/7] usb: ehci: generic PCI support Simon Glass
2012-12-14 2:21 ` [U-Boot] [PATCH v2 3/7] usb: ehci: Support interrupt transfers via periodic list Simon Glass
2012-12-19 6:16 ` Jim Lin
2012-12-14 2:21 ` Simon Glass [this message]
2013-03-06 21:34 ` [U-Boot] [PATCH v2 4/7] usb: ehci: Fix aliasing issue in EHCI interrupt code Simon Glass
2012-12-14 2:21 ` [U-Boot] [PATCH v2 5/7] usb: usbeth: smsc95xx: remove EEPROM loaded check Simon Glass
2012-12-21 2:30 ` Joe Hershberger
2012-12-14 2:21 ` [U-Boot] [PATCH v2 6/7] usb: Add multiple controllers support for EHCI PCI Simon Glass
2012-12-14 2:21 ` [U-Boot] [PATCH v2 7/7] x86: Enable USB features for coreboot Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355451692-28017-5-git-send-email-sjg@chromium.org \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox