From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dfu:ext4:fix Fix ext4{read|write} command formatting
Date: Mon, 24 Jun 2013 16:18:18 +0200 [thread overview]
Message-ID: <1372083498-19938-1-git-send-email-l.majewski@samsung.com> (raw)
In the following commit:
"dfu: Support larger than memory transfers."
SHA1: ea2453d56b8860dbd18a3c517531ffc8dcb5c839
The ext4{read|write} command formatting has been changed. It removed
a mandatory [sizebytes] parameter.
It prevented from ext4 update via dfu. This commit restored the previous
behaviour.
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Tom Rini <trini@ti.com>
Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
---
drivers/dfu/dfu_mmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c
index e2f3978..032c6a7 100644
--- a/drivers/dfu/dfu_mmc.c
+++ b/drivers/dfu/dfu_mmc.c
@@ -94,10 +94,10 @@ static int mmc_file_op(enum dfu_mmc_op op, struct dfu_entity *dfu,
sprintf(cmd_buf + strlen(cmd_buf), " %lx", *len);
break;
case DFU_FS_EXT4:
- sprintf(cmd_buf, "ext4%s mmc %d:%d 0x%x /%s",
+ sprintf(cmd_buf, "ext4%s mmc %d:%d 0x%x /%s %ld",
op == DFU_OP_READ ? "load" : "write",
dfu->data.mmc.dev, dfu->data.mmc.part,
- (unsigned int) buf, dfu->name);
+ (unsigned int) buf, dfu->name, *len);
break;
default:
printf("%s: Layout (%s) not (yet) supported!\n", __func__,
--
1.7.10.4
next reply other threads:[~2013-06-24 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 14:18 Lukasz Majewski [this message]
2013-06-26 14:41 ` [U-Boot] [PATCH] dfu:ext4:fix Fix ext4{read|write} command formatting Lukasz Majewski
2013-06-26 15:05 ` Tom Rini
2013-06-26 15:27 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372083498-19938-1-git-send-email-l.majewski@samsung.com \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox