From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dfu:ext4:fix Fix ext4{read|write} command formatting
Date: Wed, 26 Jun 2013 17:27:05 +0200 [thread overview]
Message-ID: <20130626172705.2ebfb7c1@amdc308.digital.local> (raw)
In-Reply-To: <20130626150531.GL28078@bill-the-cat>
On Wed, 26 Jun 2013 11:05:31 -0400, Tom Rini wrote:
> On Wed, Jun 26, 2013 at 04:41:28PM +0200, Lukasz Majewski wrote:
> > Hi Tom,
> >
> > > In the following commit:
> > > "dfu: Support larger than memory transfers."
> > > SHA1: ea2453d56b8860dbd18a3c517531ffc8dcb5c839
> > >
> > > The ext4{read|write} command formatting has been changed. It
> > > removed a mandatory [sizebytes] parameter.
> > >
> > > It prevented from ext4 update via dfu. This commit restored the
> > > previous behaviour.
> >
> > Tom, please drop this patch, since it only fixes DFU eMMC write.
> >
> > Unfortunately after dfu.c code changes to support NAND and arbitrary
> > files transmission, the eMMC ext4 read needs to be fixed.
> >
> > I will prepare one patch set, which fixes read and write.
>
> Ouch, sorry. I thought I had tested those cases still.
>
With RAW_ADDR from very beginning, we can read chunk by chunk when
proper request from DFU arrives.
With e.g. DFU_FS_EXT4 we first need to read all data from file system
to a buffer (dfu_buf) and then give it to DFU gadget piece by piece.
I will fix this and share patches.
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
prev parent reply other threads:[~2013-06-26 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 14:18 [U-Boot] [PATCH] dfu:ext4:fix Fix ext4{read|write} command formatting Lukasz Majewski
2013-06-26 14:41 ` Lukasz Majewski
2013-06-26 15:05 ` Tom Rini
2013-06-26 15:27 ` Lukasz Majewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130626172705.2ebfb7c1@amdc308.digital.local \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox