* [U-Boot] [PATCH] tools: correct proftool build rule
@ 2014-01-31 17:09 Ian Campbell
2014-01-31 20:49 ` Simon Glass
2014-01-31 23:54 ` [U-Boot] [PATCH v2] " Ian Campbell
0 siblings, 2 replies; 5+ messages in thread
From: Ian Campbell @ 2014-01-31 17:09 UTC (permalink / raw)
To: u-boot
The incorrect substitution made it rebuild every time.
Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
Cc: Tom Rini <trini@ti.com>
Cc: Simon Glass <sjg@chromium.org>
---
tools/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/Makefile b/tools/Makefile
index 323d408..602b2e5 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -59,7 +59,7 @@ BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX)
BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX)
BIN_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1$(SFX)
BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX)
-BIN_FILES-y += proftool(SFX)
+BIN_FILES-y += proftool$(SFX)
# Source files which exist outside the tools directory
EXT_OBJ_FILES-$(CONFIG_BUILD_ENVCRC) += common/env_embedded.o
@@ -182,7 +182,7 @@ $(obj)bmp_logo$(SFX): $(obj)bmp_logo.o
$(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
$(HOSTSTRIP) $@
-$(obj)proftool(SFX): $(obj)proftool.o
+$(obj)proftool$(SFX): $(obj)proftool.o
$(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
$(HOSTSTRIP) $@
--
1.8.5.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] tools: correct proftool build rule
2014-01-31 17:09 [U-Boot] [PATCH] tools: correct proftool build rule Ian Campbell
@ 2014-01-31 20:49 ` Simon Glass
2014-01-31 23:54 ` [U-Boot] [PATCH v2] " Ian Campbell
1 sibling, 0 replies; 5+ messages in thread
From: Simon Glass @ 2014-01-31 20:49 UTC (permalink / raw)
To: u-boot
Hi Ian,
On 31 January 2014 10:09, Ian Campbell <ijc@hellion.org.uk> wrote:
> The incorrect substitution made it rebuild every time.
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Tom Rini <trini@ti.com>
> Cc: Simon Glass <sjg@chromium.org>
It looks correct but does not apply for me on master.
Regards,
Simon
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] tools: correct proftool build rule
2014-01-31 17:09 [U-Boot] [PATCH] tools: correct proftool build rule Ian Campbell
2014-01-31 20:49 ` Simon Glass
@ 2014-01-31 23:54 ` Ian Campbell
2014-02-01 0:10 ` Simon Glass
2014-02-19 15:49 ` [U-Boot] [U-Boot,v2] " Tom Rini
1 sibling, 2 replies; 5+ messages in thread
From: Ian Campbell @ 2014-01-31 23:54 UTC (permalink / raw)
To: u-boot
The incorrect substitution made it rebuild every time.
Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
Cc: Tom Rini <trini@ti.com>
Cc: Simon Glass <sjg@chromium.org>
---
tools/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/Makefile b/tools/Makefile
index 328cea3..052e4d4 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -60,7 +60,7 @@ BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX)
BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX)
BIN_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1$(SFX)
BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX)
-BIN_FILES-y += proftool(SFX)
+BIN_FILES-y += proftool$(SFX)
BIN_FILES-$(CONFIG_STATIC_RELA) += relocate-rela$(SFX)
# Source files which exist outside the tools directory
@@ -186,7 +186,7 @@ $(obj)bmp_logo$(SFX): $(obj)bmp_logo.o
$(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
$(HOSTSTRIP) $@
-$(obj)proftool(SFX): $(obj)proftool.o
+$(obj)proftool$(SFX): $(obj)proftool.o
$(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
$(HOSTSTRIP) $@
--
1.8.5.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] tools: correct proftool build rule
2014-01-31 23:54 ` [U-Boot] [PATCH v2] " Ian Campbell
@ 2014-02-01 0:10 ` Simon Glass
2014-02-19 15:49 ` [U-Boot] [U-Boot,v2] " Tom Rini
1 sibling, 0 replies; 5+ messages in thread
From: Simon Glass @ 2014-02-01 0:10 UTC (permalink / raw)
To: u-boot
On 31 January 2014 16:54, Ian Campbell <ijc@hellion.org.uk> wrote:
> The incorrect substitution made it rebuild every time.
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Tom Rini <trini@ti.com>
> Cc: Simon Glass <sjg@chromium.org>
Thanks Ian.
Acked-by: Simon Glass <sjg@chromium.org>
> ---
> tools/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/Makefile b/tools/Makefile
> index 328cea3..052e4d4 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -60,7 +60,7 @@ BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX)
> BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX)
> BIN_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1$(SFX)
> BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX)
> -BIN_FILES-y += proftool(SFX)
> +BIN_FILES-y += proftool$(SFX)
> BIN_FILES-$(CONFIG_STATIC_RELA) += relocate-rela$(SFX)
>
> # Source files which exist outside the tools directory
> @@ -186,7 +186,7 @@ $(obj)bmp_logo$(SFX): $(obj)bmp_logo.o
> $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
> $(HOSTSTRIP) $@
>
> -$(obj)proftool(SFX): $(obj)proftool.o
> +$(obj)proftool$(SFX): $(obj)proftool.o
> $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
> $(HOSTSTRIP) $@
>
> --
> 1.8.5.3
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [U-Boot,v2] tools: correct proftool build rule
2014-01-31 23:54 ` [U-Boot] [PATCH v2] " Ian Campbell
2014-02-01 0:10 ` Simon Glass
@ 2014-02-19 15:49 ` Tom Rini
1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2014-02-19 15:49 UTC (permalink / raw)
To: u-boot
On Fri, Jan 31, 2014 at 11:54:44PM +0000, Ian Campbell wrote:
> The incorrect substitution made it rebuild every time.
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Tom Rini <trini@ti.com>
> Cc: Simon Glass <sjg@chromium.org>
> Acked-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140219/665ec707/attachment.pgp>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-19 15:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-31 17:09 [U-Boot] [PATCH] tools: correct proftool build rule Ian Campbell
2014-01-31 20:49 ` Simon Glass
2014-01-31 23:54 ` [U-Boot] [PATCH v2] " Ian Campbell
2014-02-01 0:10 ` Simon Glass
2014-02-19 15:49 ` [U-Boot] [U-Boot,v2] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox