[U-Boot] [PATCH] cmd_nvedit: Make 'env import -c' require size parameter

[U-Boot] [PATCH] cmd_nvedit: Make 'env import -c' require size parameter

[Tom Rini]

When importing a checksummed area we need to be told how big the area in
question is so that we know that will match the size of the area which
the checksum is generated against.

Reported-by: Pierre AUBERT <p.aubert@staubli.com>
Signed-off-by: Tom Rini <trini@ti.com>
---
 common/cmd_nvedit.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
index 5bcc324..c53601c 100644
--- a/common/cmd_nvedit.c
+++ b/common/cmd_nvedit.c
@@ -1008,6 +1008,9 @@ static int do_env_import(cmd_tbl_t *cmdtp, int flag,
 
 	if (argc == 2) {
 		size = simple_strtoul(argv[1], NULL, 16);
+	} else if (argc == 1 && chk) {
+		puts("## Error: external checksum format must pass size\n");
+		return CMD_RET_FAILURE;
 	} else {
 		char *s = addr;
 
-- 
1.7.9.5

[U-Boot] cmd_nvedit: Make 'env import -c' require size parameter

[Tom Rini]

On Tue, Mar 04, 2014 at 03:52:35PM -0500, Tom Rini wrote:

> When importing a checksummed area we need to be told how big the area in
> question is so that we know that will match the size of the area which
> the checksum is generated against.
> 
> Reported-by: Pierre AUBERT <p.aubert@staubli.com>
> Signed-off-by: Tom Rini <trini@ti.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140307/3bb6e572/attachment.pgp>