From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] kbuild: move "checkthumb" to ARM archprepare
Date: Wed, 5 Mar 2014 17:49:22 +0900 [thread overview]
Message-ID: <1394009363-21833-2-git-send-email-yamada.m@jp.panasonic.com> (raw)
In-Reply-To: <1394009363-21833-1-git-send-email-yamada.m@jp.panasonic.com>
"checkthumb" makes sense only for ARM architecture.
Move it to arch/arm/config.mk.
To make sure gcc supports THUMB mode before beginning build,
run "checkthumb" during "archprepare".
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
Makefile | 8 --------
arch/arm/config.mk | 12 +++++++++++-
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/Makefile b/Makefile
index 6882d10..7ed2d97 100644
--- a/Makefile
+++ b/Makefile
@@ -1114,14 +1114,6 @@ SYSTEM_MAP = \
System.map: u-boot
@$(call SYSTEM_MAP,$<) > $@
-checkthumb:
- @if test $(call cc-version) -lt 0404; then \
- echo -n '*** Your GCC does not produce working '; \
- echo 'binaries in THUMB mode.'; \
- echo '*** Your board is configured for THUMB mode.'; \
- false; \
- fi
-
# GCC 3.x is reported to have problems generating the type of relocation
# that U-Boot wants.
# See http://lists.denx.de/pipermail/u-boot/2012-September/135156.html
diff --git a/arch/arm/config.mk b/arch/arm/config.mk
index c5fd22f..be9e4c7 100644
--- a/arch/arm/config.mk
+++ b/arch/arm/config.mk
@@ -41,7 +41,17 @@ endif
# Only test once
ifneq ($(CONFIG_SPL_BUILD),y)
-ALL-$(CONFIG_SYS_THUMB_BUILD) += checkthumb
+ifeq ($(CONFIG_SYS_THUMB_BUILD),y)
+archprepare: checkthumb
+
+checkthumb:
+ @if test "$(call cc-version)" -lt "0404"; then \
+ echo -n '*** Your GCC does not produce working '; \
+ echo 'binaries in THUMB mode.'; \
+ echo '*** Your board is configured for THUMB mode.'; \
+ false; \
+ fi
+endif
endif
# Try if EABI is supported, else fall back to old API,
--
1.8.3.2
next prev parent reply other threads:[~2014-03-05 8:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 8:49 [U-Boot] [PATCH 0/2] Move arch-specific checks to "archprepare" target Masahiro Yamada
2014-03-05 8:49 ` Masahiro Yamada [this message]
2014-03-07 22:20 ` [U-Boot] [PATCH 1/2] kbuild: move "checkthumb" to ARM archprepare Simon Glass
2014-03-07 22:29 ` [U-Boot] [U-Boot, " Tom Rini
2014-03-05 8:49 ` [U-Boot] [PATCH 2/2] kbuild: move "checkgcc4" to PowerPC archprepare Masahiro Yamada
2014-03-07 22:20 ` Simon Glass
2014-03-07 22:29 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394009363-21833-2-git-send-email-yamada.m@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).