u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] kbuild: move "checkgcc4" to PowerPC archprepare
Date: Wed,  5 Mar 2014 17:49:23 +0900	[thread overview]
Message-ID: <1394009363-21833-3-git-send-email-yamada.m@jp.panasonic.com> (raw)
In-Reply-To: <1394009363-21833-1-git-send-email-yamada.m@jp.panasonic.com>

"checkgcc4" is used only for PowerPC.
Move it to arch/powerpc/config.mk.

To make sure gcc is new enough before beginning build,
run "checkgcc4" during "archprepare".

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

 Makefile               |  9 ---------
 arch/powerpc/config.mk | 11 ++++++++++-
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/Makefile b/Makefile
index 7ed2d97..ea9400d 100644
--- a/Makefile
+++ b/Makefile
@@ -1114,15 +1114,6 @@ SYSTEM_MAP = \
 System.map:	u-boot
 		@$(call SYSTEM_MAP,$<) > $@
 
-# GCC 3.x is reported to have problems generating the type of relocation
-# that U-Boot wants.
-# See http://lists.denx.de/pipermail/u-boot/2012-September/135156.html
-checkgcc4:
-	@if test $(call cc-version) -lt 0400; then \
-		echo -n '*** Your GCC is too old, please upgrade to GCC 4.x or newer'; \
-		false; \
-	fi
-
 checkdtc:
 	@if test $(call dtc-version) -lt 0104; then \
 		echo '*** Your dtc is too old, please upgrade to dtc 1.4 or newer'; \
diff --git a/arch/powerpc/config.mk b/arch/powerpc/config.mk
index ac94b2e..9821068 100644
--- a/arch/powerpc/config.mk
+++ b/arch/powerpc/config.mk
@@ -35,5 +35,14 @@ endif
 
 # Only test once
 ifneq ($(CONFIG_SPL_BUILD),y)
-ALL-y += checkgcc4
+archprepare: checkgcc4
+
+# GCC 3.x is reported to have problems generating the type of relocation
+# that U-Boot wants.
+# See http://lists.denx.de/pipermail/u-boot/2012-September/135156.html
+checkgcc4:
+	@if test $(call cc-version) -lt 0400; then \
+		echo -n '*** Your GCC is too old, please upgrade to GCC 4.x or newer'; \
+		false; \
+	fi
 endif
-- 
1.8.3.2

  parent reply	other threads:[~2014-03-05  8:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05  8:49 [U-Boot] [PATCH 0/2] Move arch-specific checks to "archprepare" target Masahiro Yamada
2014-03-05  8:49 ` [U-Boot] [PATCH 1/2] kbuild: move "checkthumb" to ARM archprepare Masahiro Yamada
2014-03-07 22:20   ` Simon Glass
2014-03-07 22:29   ` [U-Boot] [U-Boot, " Tom Rini
2014-03-05  8:49 ` Masahiro Yamada [this message]
2014-03-07 22:20   ` [U-Boot] [PATCH 2/2] kbuild: move "checkgcc4" to PowerPC archprepare Simon Glass
2014-03-07 22:29   ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394009363-21833-3-git-send-email-yamada.m@jp.panasonic.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).