From: Russ Dill <Russ.Dill@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ARM: am33xx: Fix DDR init delay placement
Date: Thu, 21 Jul 2016 04:28:31 -0700 [thread overview]
Message-ID: <1469100512-5467-2-git-send-email-Russ.Dill@ti.com> (raw)
In-Reply-To: <1469100512-5467-1-git-send-email-Russ.Dill@ti.com>
The delay needs to be before the write to ref_ctrl register
which initiates refreshes. An improper initialization sequence
generates an L3 noc error.
Signed-off-by: Russ Dill <Russ.Dill@ti.com>
---
arch/arm/cpu/armv7/am33xx/ddr.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/cpu/armv7/am33xx/ddr.c b/arch/arm/cpu/armv7/am33xx/ddr.c
index 888cf1f..ef1fc4d 100644
--- a/arch/arm/cpu/armv7/am33xx/ddr.c
+++ b/arch/arm/cpu/armv7/am33xx/ddr.c
@@ -120,12 +120,15 @@ void config_sdram_emif4d5(const struct emif_regs *regs, int nr)
writel(regs->sdram_config, &emif_reg[nr]->emif_sdram_config);
writel(regs->sdram_config, &cstat->secure_emif_sdram_config);
+
+ /* Wait 1ms because of L3 timeout error */
+ udelay(1000);
+
writel(regs->ref_ctrl, &emif_reg[nr]->emif_sdram_ref_ctrl);
writel(regs->ref_ctrl, &emif_reg[nr]->emif_sdram_ref_ctrl_shdw);
/* Perform hardware leveling for DDR3 */
if (emif_sdram_type(regs->sdram_config) == EMIF_SDRAM_TYPE_DDR3) {
- udelay(1000);
writel(readl(&emif_reg[nr]->emif_ddr_ext_phy_ctrl_36) |
0x100, &emif_reg[nr]->emif_ddr_ext_phy_ctrl_36);
writel(readl(&emif_reg[nr]->emif_ddr_ext_phy_ctrl_36_shdw) |
--
2.8.1
next prev parent reply other threads:[~2016-07-21 11:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 11:28 [U-Boot] [PATCH 0/2] am33xx/am437x u-boot DDR init fixes Russ Dill
2016-07-21 11:28 ` Russ Dill [this message]
2016-07-22 13:42 ` [U-Boot] [PATCH 1/2] ARM: am33xx: Fix DDR init delay placement Tom Rini
2016-07-26 2:32 ` [U-Boot] [U-Boot, " Tom Rini
2016-07-21 11:28 ` [U-Boot] [PATCH 2/2] ARM: am33xx: Always inhibit init/refresh during DDR phy init Russ Dill
2016-07-22 13:42 ` Tom Rini
2016-07-26 2:32 ` [U-Boot] [U-Boot, " Tom Rini
2016-07-22 13:42 ` [U-Boot] [PATCH 0/2] am33xx/am437x u-boot DDR init fixes Tom Rini
2016-07-23 0:31 ` Russ Dill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469100512-5467-2-git-send-email-Russ.Dill@ti.com \
--to=russ.dill@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox