[PATCH 0/2] Remove "saveenv" functionality from am57xx evms

[PATCH 0/2] Remove "saveenv" functionality from am57xx evms

[Anurag Dutta]

Previously saved environment introduce discrepancies and may lead to
incompatibilities without default settings. This series removes the saved
environment functionality on am57xx evms so that the default configuration
is always loaded

Test result: https://gist.github.com/anuragdutta731/b253ddb0a5538ab6588a3535d7bbecf7

Anurag Dutta (2):
  configs: am57xx_hs: Remove saved environments
  configs: am57xx: Remove saved environments

 configs/am57xx_evm_defconfig    | 4 +---
 configs/am57xx_hs_evm_defconfig | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

-- 
2.34.1

[PATCH 1/2] configs: am57xx_hs: Remove saved environments

[Anurag Dutta]

Saved environments cause inconsistencies leading to conflicts
with the default environment that U-boot should update during
development. Remove the previously saved environment so that
the default environment is always loaded.

Signed-off-by: Anurag Dutta <a-dutta@ti.com>
---
 configs/am57xx_hs_evm_defconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/configs/am57xx_hs_evm_defconfig b/configs/am57xx_hs_evm_defconfig
index 5cacd7f9cc5..a406e899d42 100644
--- a/configs/am57xx_hs_evm_defconfig
+++ b/configs/am57xx_hs_evm_defconfig
@@ -13,7 +13,6 @@ CONFIG_TI_SECURE_EMIF_PROTECTED_REGION_SIZE=0x01c00000
 CONFIG_TARGET_AM57XX_EVM=y
 CONFIG_SYS_BOOTM_LEN=0x4000000
 CONFIG_SPL=y
-CONFIG_ENV_OFFSET_REDUND=0x280000
 CONFIG_SPL_SPI_FLASH_SUPPORT=y
 CONFIG_SPL_SPI=y
 CONFIG_ARMV7_LPAE=y
@@ -50,8 +49,7 @@ CONFIG_CMD_AVB=y
 CONFIG_OF_CONTROL=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_LIST="am57xx-beagle-x15 am57xx-beagle-x15-revb1 am57xx-beagle-x15-revc am5729-beagleboneai am572x-idk am571x-idk am574x-idk"
-CONFIG_ENV_OVERWRITE=y
-CONFIG_ENV_IS_IN_MMC=y
+# CONFIG_ENV_IS_IN_FAT is not set
 CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SYS_MMC_ENV_DEV=1
-- 
2.34.1

[PATCH 2/2] configs: am57xx: Remove saved environments

[Anurag Dutta]

Saved environments lead to inconsistencies leading to conflicts
with the default environment that U-boot should update during
development. Remove the previously saved environment so that
the default environment is always loaded.

Signed-off-by: Anurag Dutta <a-dutta@ti.com>
---
 configs/am57xx_evm_defconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/configs/am57xx_evm_defconfig b/configs/am57xx_evm_defconfig
index d10d2a5940f..13260edf3f0 100644
--- a/configs/am57xx_evm_defconfig
+++ b/configs/am57xx_evm_defconfig
@@ -10,7 +10,6 @@ CONFIG_TARGET_AM57XX_EVM=y
 CONFIG_SPL_TEXT_BASE=0x40300000
 CONFIG_SYS_BOOTM_LEN=0x4000000
 CONFIG_SPL=y
-CONFIG_ENV_OFFSET_REDUND=0x280000
 CONFIG_SPL_SPI_FLASH_SUPPORT=y
 CONFIG_SPL_SPI=y
 CONFIG_ARMV7_LPAE=y
@@ -54,8 +53,7 @@ CONFIG_CMD_AVB=y
 CONFIG_OF_CONTROL=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_LIST="am57xx-beagle-x15 am57xx-beagle-x15-revb1 am57xx-beagle-x15-revc am5729-beagleboneai am572x-idk am571x-idk am574x-idk"
-CONFIG_ENV_OVERWRITE=y
-CONFIG_ENV_IS_IN_MMC=y
+# CONFIG_ENV_IS_IN_FAT is not set
 CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SYS_MMC_ENV_DEV=1
-- 
2.34.1

Re: [PATCH 0/2] Remove "saveenv" functionality from am57xx evms

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

On Sat, Feb 08, 2025 at 10:09:36AM +0530, Anurag Dutta wrote:

> Previously saved environment introduce discrepancies and may lead to
> incompatibilities without default settings. This series removes the saved
> environment functionality on am57xx evms so that the default configuration
> is always loaded
> 
> Test result: https://gist.github.com/anuragdutta731/b253ddb0a5538ab6588a3535d7bbecf7
> 
> Anurag Dutta (2):
>   configs: am57xx_hs: Remove saved environments
>   configs: am57xx: Remove saved environments
> 
>  configs/am57xx_evm_defconfig    | 4 +---
>  configs/am57xx_hs_evm_defconfig | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)

I'm not sure what this is intended to solve. A persistent environment
can be reset to the defaults with "env default -f -a" and telling users
to do this when needed when upgrading is a long standing practice.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH 0/2] Remove "saveenv" functionality from am57xx evms

[Kumar, Udit]

Hi Tom

On 2/9/2025 10:50 PM, Tom Rini wrote:
> On Sat, Feb 08, 2025 at 10:09:36AM +0530, Anurag Dutta wrote:
>
>> Previously saved environment introduce discrepancies and may lead to
>> incompatibilities without default settings. This series removes the saved
>> environment functionality on am57xx evms so that the default configuration
>> is always loaded
>>
>> Test result: https://gist.github.com/anuragdutta731/b253ddb0a5538ab6588a3535d7bbecf7
>>
>> Anurag Dutta (2):
>>    configs: am57xx_hs: Remove saved environments
>>    configs: am57xx: Remove saved environments
>>
>>   configs/am57xx_evm_defconfig    | 4 +---
>>   configs/am57xx_hs_evm_defconfig | 4 +---
>>   2 files changed, 2 insertions(+), 6 deletions(-)
> I'm not sure what this is intended to solve. A persistent environment
> can be reset to the defaults with "env default -f -a" and telling users
> to do this when needed when upgrading is a long standing practice.

There are few inconsistencies in development flow with saved env.

There we revert already for k3 platforms.  Please see

https://github.com/u-boot/u-boot/commit/a5e8678e0a32f85ad012aea7641e9534ada5c0fe 

Re: [PATCH 0/2] Remove "saveenv" functionality from am57xx evms

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1848 bytes --]

On Mon, Feb 10, 2025 at 09:55:22AM +0530, Kumar, Udit wrote:
> Hi Tom
> 
> On 2/9/2025 10:50 PM, Tom Rini wrote:
> > On Sat, Feb 08, 2025 at 10:09:36AM +0530, Anurag Dutta wrote:
> > 
> > > Previously saved environment introduce discrepancies and may lead to
> > > incompatibilities without default settings. This series removes the saved
> > > environment functionality on am57xx evms so that the default configuration
> > > is always loaded
> > > 
> > > Test result: https://gist.github.com/anuragdutta731/b253ddb0a5538ab6588a3535d7bbecf7
> > > 
> > > Anurag Dutta (2):
> > >    configs: am57xx_hs: Remove saved environments
> > >    configs: am57xx: Remove saved environments
> > > 
> > >   configs/am57xx_evm_defconfig    | 4 +---
> > >   configs/am57xx_hs_evm_defconfig | 4 +---
> > >   2 files changed, 2 insertions(+), 6 deletions(-)
> > I'm not sure what this is intended to solve. A persistent environment
> > can be reset to the defaults with "env default -f -a" and telling users
> > to do this when needed when upgrading is a long standing practice.
> 
> There are few inconsistencies in development flow with saved env.
> 
> There we revert already for k3 platforms.  Please see
> 
> https://github.com/u-boot/u-boot/commit/a5e8678e0a32f85ad012aea7641e9534ada5c0fe

I did miss that one at the time, yeah. I do think this is the wrong
direction because custom designs tend to copy the ref platform and
making each of them pick the right long term likely to not be
overwritten location seems like more work than reminding developers to
run "env default -f -a" when modifying the environment, or even just
locally switching to ENV_IS_NOWHERE. I'm not nak'ing it but I would
encourage everyone to re-think all of the use cases here and make sure
that yes, really, this is the best option.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH 0/2] Remove "saveenv" functionality from am57xx evms

[Kumar, Udit]

On 2/10/2025 8:13 PM, Tom Rini wrote:
> On Mon, Feb 10, 2025 at 09:55:22AM +0530, Kumar, Udit wrote:
>> Hi Tom
>>
>> On 2/9/2025 10:50 PM, Tom Rini wrote:
>>> On Sat, Feb 08, 2025 at 10:09:36AM +0530, Anurag Dutta wrote:
>>>
>>>> Previously saved environment introduce discrepancies and may lead to
>>>> incompatibilities without default settings. This series removes the saved
>>>> environment functionality on am57xx evms so that the default configuration
>>>> is always loaded
>>>>
>>>> Test result: https://gist.github.com/anuragdutta731/b253ddb0a5538ab6588a3535d7bbecf7
>>>>
>>>> Anurag Dutta (2):
>>>>     configs: am57xx_hs: Remove saved environments
>>>>     configs: am57xx: Remove saved environments
>>>>
>>>>    configs/am57xx_evm_defconfig    | 4 +---
>>>>    configs/am57xx_hs_evm_defconfig | 4 +---
>>>>    2 files changed, 2 insertions(+), 6 deletions(-)
>>> I'm not sure what this is intended to solve. A persistent environment
>>> can be reset to the defaults with "env default -f -a" and telling users
>>> to do this when needed when upgrading is a long standing practice.
>> There are few inconsistencies in development flow with saved env.
>>
>> There we revert already for k3 platforms.  Please see
>>
>> https://github.com/u-boot/u-boot/commit/a5e8678e0a32f85ad012aea7641e9534ada5c0fe
> I did miss that one at the time, yeah. I do think this is the wrong
> direction because custom designs tend to copy the ref platform and
> making each of them pick the right long term likely to not be
> overwritten location seems like more work than reminding developers to
> run "env default -f -a" when modifying the environment, or even just
> locally switching to ENV_IS_NOWHERE. I'm not nak'ing it but I would
> encourage everyone to re-think all of the use cases here and make sure
> that yes, really, this is the best option.

Likewise, I don't have strong opinion for either.

But I am slightly inclined towards ENV_IS_NOWHERE

How i see two environments development and production.


In development environment, boot should work out of box,

There are few non u-boot developer, using u-boot in their work flows,

they should know to run "env default -f -a" command when they do u-boot 
update.

In production environment, u-boot is customized most of times, so env 
option could be enabled at part of customization

PF, I see around 48 configs are on ENV_IS_NOWHERE

Thanks


>

Re: [PATCH 0/2] Remove "saveenv" functionality from am57xx evms

[Tom Rini]

On Sat, 08 Feb 2025 10:09:36 +0530, Anurag Dutta wrote:

> Previously saved environment introduce discrepancies and may lead to
> incompatibilities without default settings. This series removes the saved
> environment functionality on am57xx evms so that the default configuration
> is always loaded
> 
> Test result: https://gist.github.com/anuragdutta731/b253ddb0a5538ab6588a3535d7bbecf7
> 
> [...]

Applied to u-boot/next, thanks!

-- 
Tom