public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/6] x86: tsc: Try hardware calibration first
Date: Fri, 10 Aug 2018 02:39:36 -0700	[thread overview]
Message-ID: <1533893978-12838-4-git-send-email-bmeng.cn@gmail.com> (raw)
In-Reply-To: <1533893978-12838-1-git-send-email-bmeng.cn@gmail.com>

At present if TSC frequency is provided in the device tree, it takes
precedence over hardware calibration result. This swaps the order to
try hardware calibration first and uses device tree as last resort.

This can be helpful when a generic dts (eg: coreboot/efi payload) is
supposed to work on as many hardware as possible, including emulators
like QEMU where TSC hardware calibration sometimes fails.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 drivers/timer/tsc_timer.c | 27 ++++++++++++++++-----------
 1 file changed, 16 insertions(+), 11 deletions(-)

diff --git a/drivers/timer/tsc_timer.c b/drivers/timer/tsc_timer.c
index 747f190..6473de2 100644
--- a/drivers/timer/tsc_timer.c
+++ b/drivers/timer/tsc_timer.c
@@ -341,16 +341,12 @@ static int tsc_timer_get_count(struct udevice *dev, u64 *count)
 	return 0;
 }
 
-static void tsc_timer_ensure_setup(void)
+static void tsc_timer_ensure_setup(bool stop)
 {
 	if (gd->arch.tsc_base)
 		return;
 	gd->arch.tsc_base = rdtsc();
 
-	/*
-	 * If there is no clock frequency specified in the device tree,
-	 * calibrate it by ourselves.
-	 */
 	if (!gd->arch.clock_rate) {
 		unsigned long fast_calibrate;
 
@@ -366,7 +362,10 @@ static void tsc_timer_ensure_setup(void)
 		if (fast_calibrate)
 			goto done;
 
-		panic("TSC frequency is ZERO");
+		if (stop)
+			panic("TSC frequency is ZERO");
+		else
+			return;
 
 done:
 		gd->arch.clock_rate = fast_calibrate * 1000000;
@@ -377,11 +376,17 @@ static int tsc_timer_probe(struct udevice *dev)
 {
 	struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev);
 
-	if (!uc_priv->clock_rate) {
-		tsc_timer_ensure_setup();
-		uc_priv->clock_rate = gd->arch.clock_rate;
+	/* Try hardware calibration first */
+	tsc_timer_ensure_setup(false);
+	if (!gd->arch.clock_rate) {
+		/*
+		 * Use the clock frequency specified in the
+		 * device tree as last resort
+		 */
+		if (!uc_priv->clock_rate)
+			panic("TSC frequency is ZERO");
 	} else {
-		gd->arch.tsc_base = rdtsc();
+		uc_priv->clock_rate = gd->arch.clock_rate;
 	}
 
 	return 0;
@@ -394,7 +399,7 @@ unsigned long notrace timer_early_get_rate(void)
 	 * clock rate can only be calibrated via some hardware ways. Specifying
 	 * it in the device tree won't work for the early timer.
 	 */
-	tsc_timer_ensure_setup();
+	tsc_timer_ensure_setup(true);
 
 	return gd->arch.clock_rate;
 }
-- 
2.7.4

  parent reply	other threads:[~2018-08-10  9:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-10  9:39 [U-Boot] [PATCH 1/6] x86: coreboot: Add generic coreboot payload support Bin Meng
2018-08-10  9:39 ` [U-Boot] [PATCH 2/6] x86: Remove support for Advantech SOM-6896 Bin Meng
2018-08-10 12:43   ` George McCollister
2018-08-20  5:57     ` Bin Meng
2018-08-10  9:39 ` [U-Boot] [PATCH 3/6] x86: dts: Remove coreboot_fb.dtsi Bin Meng
2018-08-17 12:48   ` Simon Glass
2018-08-20  5:57     ` Bin Meng
2018-08-10  9:39 ` Bin Meng [this message]
2018-08-14  6:54   ` [U-Boot] [PATCH 4/6] x86: tsc: Try hardware calibration first Christian Gmeiner
2018-08-14  7:07     ` Bin Meng
2018-08-14  8:35       ` Christian Gmeiner
2018-08-20  5:57         ` Bin Meng
2018-08-10  9:39 ` [U-Boot] [PATCH 5/6] x86: coreboot: Add default TSC frequency in the device tree Bin Meng
2018-08-14  6:45   ` Christian Gmeiner
2018-08-20  5:57     ` Bin Meng
2018-08-10  9:39 ` [U-Boot] [PATCH 6/6] x86: efi: payload: " Bin Meng
2018-08-17 12:48   ` Simon Glass
2018-08-20  5:57     ` Bin Meng
2018-08-14  6:39 ` [U-Boot] [PATCH 1/6] x86: coreboot: Add generic coreboot payload support Christian Gmeiner
2018-08-20  5:56   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533893978-12838-4-git-send-email-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox