* [U-Boot] [PATCH v2 1/2] cpu: Add DM_FLAG_PRE_RELOC flag to various cpu drivers
@ 2018-10-14 8:07 Bin Meng
2018-10-14 8:07 ` [U-Boot] [PATCH v2 2/2] cpu: sandbox: Add "u-boot, dm-pre-reloc" for all cpu nodes Bin Meng
2018-10-15 7:36 ` [U-Boot] [PATCH v2 1/2] cpu: Add DM_FLAG_PRE_RELOC flag to various cpu drivers Stefan Roese
0 siblings, 2 replies; 6+ messages in thread
From: Bin Meng @ 2018-10-14 8:07 UTC (permalink / raw)
To: u-boot
It turns out commit c0434407b595 broke some boards which have DM CPU
driver with CONFIG_DISPLAY_CPUINFO option on. These boards just fail
to boot when print_cpuinfo() is called during boot.
Fixes: c0434407b595 ("board_f: Use static print_cpuinfo if CONFIG_CPU is active")
Reported-by: Stefan Roese <sr@denx.de>
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
Changes in v2:
- drop the sandbox cpu driver change
arch/x86/cpu/baytrail/cpu.c | 1 +
arch/x86/cpu/broadwell/cpu.c | 1 +
arch/x86/cpu/cpu_x86.c | 1 +
arch/x86/cpu/ivybridge/model_206ax.c | 1 +
4 files changed, 4 insertions(+)
diff --git a/arch/x86/cpu/baytrail/cpu.c b/arch/x86/cpu/baytrail/cpu.c
index 56e9813..2eb9172 100644
--- a/arch/x86/cpu/baytrail/cpu.c
+++ b/arch/x86/cpu/baytrail/cpu.c
@@ -203,4 +203,5 @@ U_BOOT_DRIVER(cpu_x86_baytrail_drv) = {
.bind = cpu_x86_bind,
.probe = cpu_x86_baytrail_probe,
.ops = &cpu_x86_baytrail_ops,
+ .flags = DM_FLAG_PRE_RELOC,
};
diff --git a/arch/x86/cpu/broadwell/cpu.c b/arch/x86/cpu/broadwell/cpu.c
index 02b3169..232fa40 100644
--- a/arch/x86/cpu/broadwell/cpu.c
+++ b/arch/x86/cpu/broadwell/cpu.c
@@ -764,4 +764,5 @@ U_BOOT_DRIVER(cpu_x86_broadwell_drv) = {
.probe = cpu_x86_broadwell_probe,
.ops = &cpu_x86_broadwell_ops,
.priv_auto_alloc_size = sizeof(struct cpu_broadwell_priv),
+ .flags = DM_FLAG_PRE_RELOC,
};
diff --git a/arch/x86/cpu/cpu_x86.c b/arch/x86/cpu/cpu_x86.c
index 2b6cc9f..1aaf851 100644
--- a/arch/x86/cpu/cpu_x86.c
+++ b/arch/x86/cpu/cpu_x86.c
@@ -94,4 +94,5 @@ U_BOOT_DRIVER(cpu_x86_drv) = {
.of_match = cpu_x86_ids,
.bind = cpu_x86_bind,
.ops = &cpu_x86_ops,
+ .flags = DM_FLAG_PRE_RELOC,
};
diff --git a/arch/x86/cpu/ivybridge/model_206ax.c b/arch/x86/cpu/ivybridge/model_206ax.c
index 33e5c62..6edc3e2 100644
--- a/arch/x86/cpu/ivybridge/model_206ax.c
+++ b/arch/x86/cpu/ivybridge/model_206ax.c
@@ -478,4 +478,5 @@ U_BOOT_DRIVER(cpu_x86_model_206ax_drv) = {
.bind = cpu_x86_bind,
.probe = cpu_x86_model_206ax_probe,
.ops = &cpu_x86_model_206ax_ops,
+ .flags = DM_FLAG_PRE_RELOC,
};
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH v2 2/2] cpu: sandbox: Add "u-boot, dm-pre-reloc" for all cpu nodes
2018-10-14 8:07 [U-Boot] [PATCH v2 1/2] cpu: Add DM_FLAG_PRE_RELOC flag to various cpu drivers Bin Meng
@ 2018-10-14 8:07 ` Bin Meng
2018-10-15 7:37 ` Stefan Roese
2018-10-15 7:36 ` [U-Boot] [PATCH v2 1/2] cpu: Add DM_FLAG_PRE_RELOC flag to various cpu drivers Stefan Roese
1 sibling, 1 reply; 6+ messages in thread
From: Bin Meng @ 2018-10-14 8:07 UTC (permalink / raw)
To: u-boot
To support CONFIG_DISPLAY_CPUINFO, add "u-boot,dm-pre-reloc" for
all cpu nodes in Sandbox test.dts.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
Changes in v2:
- new patch to add "u-boot,dm-pre-reloc" for all cpu nodes in Sandbox
arch/sandbox/dts/test.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
index 0635b91..c52f5a9 100644
--- a/arch/sandbox/dts/test.dts
+++ b/arch/sandbox/dts/test.dts
@@ -350,14 +350,17 @@
cpu-test1 {
compatible = "sandbox,cpu_sandbox";
+ u-boot,dm-pre-reloc;
};
cpu-test2 {
compatible = "sandbox,cpu_sandbox";
+ u-boot,dm-pre-reloc;
};
cpu-test3 {
compatible = "sandbox,cpu_sandbox";
+ u-boot,dm-pre-reloc;
};
misc-test {
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH v2 2/2] cpu: sandbox: Add "u-boot, dm-pre-reloc" for all cpu nodes
2018-10-14 8:07 ` [U-Boot] [PATCH v2 2/2] cpu: sandbox: Add "u-boot, dm-pre-reloc" for all cpu nodes Bin Meng
@ 2018-10-15 7:37 ` Stefan Roese
2018-11-06 22:44 ` sjg at google.com
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Roese @ 2018-10-15 7:37 UTC (permalink / raw)
To: u-boot
On 14.10.2018 10:07, Bin Meng wrote:
> To support CONFIG_DISPLAY_CPUINFO, add "u-boot,dm-pre-reloc" for
> all cpu nodes in Sandbox test.dts.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2 2/2] cpu: sandbox: Add "u-boot, dm-pre-reloc" for all cpu nodes
2018-10-15 7:37 ` Stefan Roese
@ 2018-11-06 22:44 ` sjg at google.com
0 siblings, 0 replies; 6+ messages in thread
From: sjg at google.com @ 2018-11-06 22:44 UTC (permalink / raw)
To: u-boot
On 14.10.2018 10:07, Bin Meng wrote:
> To support CONFIG_DISPLAY_CPUINFO, add "u-boot,dm-pre-reloc" for
> all cpu nodes in Sandbox test.dts.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
Applied to u-boot-dm/master, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2 1/2] cpu: Add DM_FLAG_PRE_RELOC flag to various cpu drivers
2018-10-14 8:07 [U-Boot] [PATCH v2 1/2] cpu: Add DM_FLAG_PRE_RELOC flag to various cpu drivers Bin Meng
2018-10-14 8:07 ` [U-Boot] [PATCH v2 2/2] cpu: sandbox: Add "u-boot, dm-pre-reloc" for all cpu nodes Bin Meng
@ 2018-10-15 7:36 ` Stefan Roese
2018-11-06 22:44 ` sjg at google.com
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Roese @ 2018-10-15 7:36 UTC (permalink / raw)
To: u-boot
On 14.10.2018 10:07, Bin Meng wrote:
> It turns out commit c0434407b595 broke some boards which have DM CPU
> driver with CONFIG_DISPLAY_CPUINFO option on. These boards just fail
> to boot when print_cpuinfo() is called during boot.
>
> Fixes: c0434407b595 ("board_f: Use static print_cpuinfo if CONFIG_CPU is active")
> Reported-by: Stefan Roese <sr@denx.de>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Tested-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH v2 1/2] cpu: Add DM_FLAG_PRE_RELOC flag to various cpu drivers
2018-10-15 7:36 ` [U-Boot] [PATCH v2 1/2] cpu: Add DM_FLAG_PRE_RELOC flag to various cpu drivers Stefan Roese
@ 2018-11-06 22:44 ` sjg at google.com
0 siblings, 0 replies; 6+ messages in thread
From: sjg at google.com @ 2018-11-06 22:44 UTC (permalink / raw)
To: u-boot
On 14.10.2018 10:07, Bin Meng wrote:
> It turns out commit c0434407b595 broke some boards which have DM CPU
> driver with CONFIG_DISPLAY_CPUINFO option on. These boards just fail
> to boot when print_cpuinfo() is called during boot.
>
> Fixes: c0434407b595 ("board_f: Use static print_cpuinfo if CONFIG_CPU is active")
> Reported-by: Stefan Roese <sr@denx.de>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Tested-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
Applied to u-boot-dm/master, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-06 22:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-14 8:07 [U-Boot] [PATCH v2 1/2] cpu: Add DM_FLAG_PRE_RELOC flag to various cpu drivers Bin Meng
2018-10-14 8:07 ` [U-Boot] [PATCH v2 2/2] cpu: sandbox: Add "u-boot, dm-pre-reloc" for all cpu nodes Bin Meng
2018-10-15 7:37 ` Stefan Roese
2018-11-06 22:44 ` sjg at google.com
2018-10-15 7:36 ` [U-Boot] [PATCH v2 1/2] cpu: Add DM_FLAG_PRE_RELOC flag to various cpu drivers Stefan Roese
2018-11-06 22:44 ` sjg at google.com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox