From: Heiko Stuebner <heiko@sntech.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 0/6] rockchip: back-to-bootrom: replace assembly-implementation with C-code
Date: Thu, 21 Sep 2017 11:44:26 +0200 [thread overview]
Message-ID: <1575654.3LH0U9PvCD@phil> (raw)
In-Reply-To: <2510496.Zb8RDqHzGq@phil>
Am Donnerstag, 21. September 2017, 11:09:49 CEST schrieb Heiko Stuebner:
> Am Donnerstag, 21. September 2017, 10:19:23 CEST schrieb Philipp Tomsich:
> >
> > Recent discussions confirmed (what the code always assumed): the
> > Rockchip BROM always enters U-Boot with the stack-pointer valid
> > (i.e. the U-Boot startup code is running off the BROM stack).
> >
> > We can thus replace the back-to-bootrom code (i.e. both the
> > save_boot_params and back_to_bootrom implementations) using C-code
> > based on setjmp/longjmp. The new implementation is already structured
> > to allow an easy drop-in of Andy's changes to enter download-mode when
> > returning to the BROM.
> >
> > This turned out to require a some tweaking to system.h (making sure
> > that the prototype for save_boot_params_ret is visible for A64)and
> > start.S (so binutils knows that this is a possible function entry and
> > it can correctly insert A32-to-Thumb transitions) and taking the axe
> > to setjmp.h (which created quite a few issues with it not expecting
> > A32/T32/Thumb call-sites and some fragility from GCC being smart about
> > the clobber-list of the inline assembly... which led to r9 not being
> > saved or restored).
>
> This is missing information on dependant series. Using the u-boot-rockchip
> repository which is at
> 782088de7be7 ("rockchip: imply ADC and SARADC_ROCKCHIP on supported SoCs")
>
> patches 1-3 apply, but patch 4 fails to apply as I seem to be missing some
> dependencies.
>
> And the u-boot mailinglist seems to be configured very strangely, as it
> seems to rip apart patch-series only sending me some parts.
>
> So far I can at least say, that the u-boot-rockchip repo at the above
> commit still boots. Could you please point me to mbox versions
> of needed base patches?
Also, with patches 1-3 and 5 applied the radxarock board fails to start.
I see the SPL banner and a "Returning to boot ROM..." and then nothing.
I do belive it may have something to do with the TPL's + SPL's stack both
being at the end of SRAM? Having the SPL go back to TPL and then
back to bootrom was my original intention as well, but didn't work at
the time.
Heiko
next prev parent reply other threads:[~2017-09-21 9:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 8:19 [U-Boot] [PATCH v3 0/6] rockchip: back-to-bootrom: replace assembly-implementation with C-code Philipp Tomsich
2017-09-21 8:19 ` [U-Boot] [PATCH v3 1/6] arm: make save_boot_params_ret prototype visible for AArch64 Philipp Tomsich
2017-09-21 8:19 ` [U-Boot] [PATCH v3 2/6] arm: mark save_boot_params_ret as a function Philipp Tomsich
2017-09-21 8:19 ` [U-Boot] [PATCH v3 3/6] arm: provide a PCS-compliant setjmp implementation Philipp Tomsich
2017-09-23 0:48 ` Alexander Graf
2017-09-21 8:19 ` [U-Boot] [PATCH v3 4/6] rockchip: back-to-bootrom: replace assembly-implementation with C-code Philipp Tomsich
2017-09-21 8:19 ` [U-Boot] [PATCH v3 5/6] rockchip: back-to-bootrom: rk3188: chain from SPL via TPL to the BROM Philipp Tomsich
2017-09-21 8:19 ` [U-Boot] [PATCH v3 6/6] rockchip: back-to-bootrom: allow passing a cmd to the bootrom Philipp Tomsich
2017-09-21 9:09 ` [U-Boot] [PATCH v3 0/6] rockchip: back-to-bootrom: replace assembly-implementation with C-code Heiko Stuebner
2017-09-21 9:44 ` Heiko Stuebner [this message]
2017-09-21 10:25 ` Dr. Philipp Tomsich
2017-09-21 10:39 ` Dr. Philipp Tomsich
2017-09-21 10:44 ` Heiko Stübner
2017-09-25 8:46 ` Andy Yan
2017-09-25 8:49 ` Dr. Philipp Tomsich
2017-09-21 10:27 ` Dr. Philipp Tomsich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1575654.3LH0U9PvCD@phil \
--to=heiko@sntech.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox