Re: [PATCH v2 00/11] Rockchip VOP2 support

Re: [PATCH v2 00/11] Rockchip VOP2 support

[Maciej Pijanowski]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 606 bytes --]

Hello,

First of all, thanks for your work on this Rockchip upstream code. We have
tested your patches on RK3566 board (Radxa CM3 IO) and HDMI output in
U-Boot works great. We didn't have success with MIPI yet so far, though.

 > HDMI should work flawlessly but there's still some timings issue with
 > DW MIPI DSI, perhaps that's something to look into later.

I wanted to confirm whether you have had success with the MIPI as well,
and what exactly do you mean by these issues?

Thanks,

-- 
Maciej Pijanowski
Engineering Manager
GPG: 9963C36AAC3B2B46
https://3mdeb.com | @3mdeb_com


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3203 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: [PATCH v2 00/11] Rockchip VOP2 support

[Dang Huynh]

Hi Maciej,

On Monday, March 24, 2025 3:46:12 PM UTC Maciej Pijanowski wrote:
> Hello,
> 
> First of all, thanks for your work on this Rockchip upstream code. We have
> tested your patches on RK3566 board (Radxa CM3 IO) and HDMI output in
> U-Boot works great. We didn't have success with MIPI yet so far, though.
> 
> 
>  > HDMI should work flawlessly but there's still some timings issue with
>  > DW MIPI DSI, perhaps that's something to look into later.
> 
> 
> I wanted to confirm whether you have had success with the MIPI as well,
> and what exactly do you mean by these issues?
Try not to plug in the HDMI cable and see if MIPI works. You'll also need a 
panel driver. 

As for the timing issue (which I'm not sure if it is), I don't know how to 
explain it so here's an image of how text rendering looks like on my device 
(notice the word "Bus" in the image):
https://0x0.st/8j__.jpg
> 
> Thanks,
> 
> -- 
> Maciej Pijanowski
> Engineering Manager
> GPG: 9963C36AAC3B2B46
> https://3mdeb.com | @3mdeb_com
> 

Best regards,
Dang

Re: [PATCH v2 00/11] Rockchip VOP2 support

[Piotr Zalewski]

Tested on pinetab2. With v2 usb start isn't called on boot because
USB_PREBOOT config was disabled so keyboard doesn't work until it is
manually typed through serial console. Also there is less console output
than in v1 because PRE_CONSOLE_BUFFER is disabled. Perhaps disabling those
2 was intentional but I haven't found an explanation in patch descriptions.
Otherwise everything ok.

Tested-by: Piotr Zalewski <pZ010001011111@proton.me>

[PATCH v2 00/11] Rockchip VOP2 support

[Dang Huynh]

This series adds VOP2 support to U-Boot and enable it for PineTab2.

HDMI should work flawlessly but there's still some timings issue with
DW MIPI DSI, perhaps that's something to look into later.

PATCH 4 and 7 requires get_display_timing patch[1]. Until that patch
gets into master, the patches can be merged.

[1]: https://lore.kernel.org/u-boot/20250220170629.228485-1-clamor95@gmail.com

Signed-off-by: Dang Huynh <danct12@riseup.net>
---
Changes in v2:
- Get display timings from video bridge (requires [1])
- Disable esmart and post before booting to OS
- Enable avdd-0v9 and avdd-1v8 when probing HDMI.
- Link to v1: https://lore.kernel.org/r/20250116-vop2-pt2-v1-0-c9d646b53930@riseup.net

---
Dang Huynh (9):
      video: rockchip: dw-mipi-dsi: Depend on CONFIG_VIDEO_BRIDGE
      video: rockchip: dw-mipi-dsi: Add get_display_timing support
      video: Add BOE TH101MB31IG002-28A MIPI-DSI panel
      video: rockchip: Add VOP2 support
      video: rockchip: vop2: Add video bridge support
      dts: rockchip: rk356x: Prerelocate VOP in U-Boot proper
      configs: quartz64: Enable vidconsole
      video: rockchip: Add HDMI support for RK3568
      configs: pinetab2-rk3566: Enable video and USB keyboard

Ondrej Jirman (2):
      video: rockchip: dw_mipi_dsi: Improve pixel clock calculations
      video: rockchip: dw_mipi_dsi: Proceed when external PHY is not defined

 arch/arm/dts/rk356x-u-boot.dtsi                 |   4 +
 arch/arm/include/asm/arch-rockchip/vop_rk3568.h | 249 ++++++++++++
 configs/pinetab2-rk3566_defconfig               |  11 +
 drivers/video/Kconfig                           |  10 +
 drivers/video/Makefile                          |   1 +
 drivers/video/boe-th101mb31ig002-28a.c          | 236 +++++++++++
 drivers/video/rockchip/Kconfig                  |   2 +-
 drivers/video/rockchip/Makefile                 |   4 +-
 drivers/video/rockchip/dw_mipi_dsi_rockchip.c   |  45 ++-
 drivers/video/rockchip/rk3568_hdmi.c            |  71 ++++
 drivers/video/rockchip/rk3568_vop.c             | 247 ++++++++++++
 drivers/video/rockchip/rk_vop2.c                | 514 ++++++++++++++++++++++++
 drivers/video/rockchip/rk_vop2.h                |  59 +++
 include/configs/quartz64_rk3566.h               |   5 +-
 14 files changed, 1436 insertions(+), 22 deletions(-)
---
base-commit: 313b9856f95419b01df7cc6b9a16f7b07d9fe13c
change-id: 20250114-vop2-pt2-755fb1991bb6

Best regards,
-- 
Dang Huynh <danct12@riseup.net>