U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/6] arm: am57xx: reintroduce the CONFIG_AM57XX symbol
Date: Wed, 15 Feb 2017 13:30:38 +0200	[thread overview]
Message-ID: <1be76bec-6b5a-2cc0-590c-fab244829f9d@ti.com> (raw)
In-Reply-To: <7c6cff82-ad8d-f506-09d7-9af8d4600bc8@ti.com>

On 15/02/17 10:24, Roger Quadros wrote:
> On 14/02/17 22:12, Tom Rini wrote:
>> On Tue, Feb 14, 2017 at 01:26:24PM -0600, Nishanth Menon wrote:
>>> On 02/14/2017 01:20 PM, Tom Rini wrote:
>>>> On Tue, Feb 14, 2017 at 01:18:20PM -0600, menon.nishanth at gmail.com wrote:
>>>>> On Mon, Feb 13, 2017 at 7:27 AM, Tom Rini <trini@konsulko.com> wrote:
>>>>>> On Mon, Feb 13, 2017 at 01:34:52PM +0200, Uri Mashiach wrote:
>>>>>>
>>>>>>> The SOC family symbol CONFIG_AM57XX was removed by the commit
>>>>>>> 3891a54: "ARM: DRA7x/AM57xx: Get rid of CONFIG_AM57XX".
>>>>>>>
>>>>>>> The symbol is needed by the XHCI OMAP USB driver.
>>>>>>> Without the symbol all the AM57x targets symbols should be ored in the
>>>>>>> ifdef'ery.
>>>>>>>
>>>>>>> Signed-off-by: Uri Mashiach <uri.mashiach@compulab.co.il>
>>>>>>
>>>>>> We need to introduce it into Kconfig files now, thanks!
>>>>>
>>>>> DRA7 and AM57xx are literally the same. the #ifdeffery in USB is more
>>>>> to do which port to use rather than having anything to do with DRA7 Vs
>>>>> AM57xx.
>>>>
>>>> Yes, agreed.  And we need to solve this, and introduce some Kconfig
>>>> CONFIG symbol to deal with it.  Maybe the better way to look at this is,
>>>> can we have DRA7xx boards configured in the way Uri wants to be able to
>>>> configure the AM57xx board he's working with? And vice versa?  The
>>>> answer to that will help drive what the right CONFIG_xxx name is.
>>>
>>> Should'nt be ideally done via DM model instead? I have no
>>> understanding of USB integration done in u-boot to comment better.
>>
>> That's also something that could be explored.
>>
> 
> Yes, ideally this should be taken care of by DM.
> Till that migration is complete I'm fine with fixing this temporarily.
> 
> OMAP5, DRA7, AM57 and AM43 use different XHCI_BASE address.
> 
Just to clarify further on this
DRA7 and AM57 are identical SoCs but the EVMs are using different
instances of the USB as host so the difference in XHCI_BASE.

DRA7-evm uses USB1 instance whereas AM57x-EVM uses USB0 instance as host.

-- 
cheers,
-roger

  reply	other threads:[~2017-02-15 11:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13 11:34 [U-Boot] [PATCH v2 1/6] arm: am57xx: reintroduce the CONFIG_AM57XX symbol Uri Mashiach
2017-02-13 13:27 ` Tom Rini
2017-02-14 19:18   ` menon.nishanth at gmail.com
2017-02-14 19:20     ` Tom Rini
2017-02-14 19:26       ` Nishanth Menon
2017-02-14 20:12         ` Tom Rini
2017-02-15  8:24           ` Roger Quadros
2017-02-15 11:30             ` Roger Quadros [this message]
2017-02-15 13:50               ` Uri Mashiach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1be76bec-6b5a-2cc0-590c-fab244829f9d@ti.com \
    --to=rogerq@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox