U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@cherry.de>
To: dmukhin@ford.com, u-boot@lists.denx.de
Cc: sjg@chromium.org, trini@konsulko.com
Subject: Re: [PATCH v4 6/7] docs: reset: document cold reset option
Date: Fri, 26 Jun 2026 17:05:10 +0200	[thread overview]
Message-ID: <1c6df9e1-4c44-46bd-a400-c6ecee9ac5bf@cherry.de> (raw)
In-Reply-To: <20260603070743.1268544-7-dmukhin@ford.com>

On 6/3/26 9:07 AM, dmukhin@ford.com wrote:
> Update the reset command documentation to cover 'reset -c' and explain
> that the default reset type can be overridden through the relevant
> Kconfig choice.
> 
> Signed-off-by: Denis Mukhin <dmukhin@ford.com>
> ---
> Changes since v3:
> - corrected description for reset command
> ---
>   doc/usage/cmd/reset.rst | 11 +++++++----
>   1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/doc/usage/cmd/reset.rst b/doc/usage/cmd/reset.rst
> index 79bc8b9deca5..660527d0b8f9 100644
> --- a/doc/usage/cmd/reset.rst
> +++ b/doc/usage/cmd/reset.rst
> @@ -11,15 +11,18 @@ Synopsis
>   
>   ::
>   
> -    reset
> -    reset -w
> +    reset [-c|-w]
>       reset -edl
>   
>   Description
>   -----------
>   
> -Perform reset of the CPU. By default does COLD reset, which resets CPU,
> -DDR and peripherals, on some boards also resets external PMIC.
> +Perform reset of the CPU. By default does COLD reset unless overridden via
> +Kconfig CONFIG_SYSRESET_CMD_RESET_DEFAULT_{COLD,WARM,POWER}.
> +
> +-c
> +    Do COLD reset: reset CPU and peripheral/DDR; on some boards also resets
> +    external PMIC.
>   

I really don't like this. I'm afraid we'll end up with very different 
meanings by architecture, vendor or even board. I'm not sure I have 
anything to suggest though (and maybe we've already reached this issue), 
so this is not a NACK but phew, I fear for the future.

Cheers,
Quentin

  parent reply	other threads:[~2026-06-26 15:05 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03  7:07 [PATCH v4 0/7] reset: add board reset type dmukhin
2026-06-03  7:07 ` [PATCH v4 1/7] reset: Allow per-board " dmukhin
2026-06-03  7:07 ` [PATCH v4 2/7] reset: Add explicit cold reset support dmukhin
2026-06-03 17:04   ` Simon Glass
2026-06-16 21:44   ` Tom Rini
2026-06-17  6:29     ` dmukhin
2026-07-29  8:21     ` Denis Mukhin via U-Boot
2026-06-26 15:00   ` Quentin Schulz
2026-06-27  8:28     ` Simon Glass
2026-06-03  7:07 ` [PATCH v4 3/7] reset: Print reset type on diagnostic console dmukhin
2026-06-03 17:04   ` Simon Glass
2026-06-26 15:01   ` Quentin Schulz
2026-06-27  8:30     ` Simon Glass
2026-07-23 16:43       ` Quentin Schulz
2026-07-28 11:38         ` Simon Glass
2026-07-28 11:43           ` Quentin Schulz
2026-07-28 11:49             ` Simon Glass
2026-06-03  7:07 ` [PATCH v4 4/7] reset: x86: Use cpu_hlt() in pch_sysreset_power_off() dmukhin
2026-06-03 17:04   ` Simon Glass
2026-06-03  7:07 ` [PATCH v4 5/7] reset: x86: Use cpu_hlt() in efi_reset_system() dmukhin
2026-06-03 17:04   ` Simon Glass
2026-06-03  7:07 ` [PATCH v4 6/7] docs: reset: document cold reset option dmukhin
2026-06-03 17:04   ` Simon Glass
2026-06-26 15:05   ` Quentin Schulz [this message]
2026-06-03  7:07 ` [PATCH v4 7/7] tests: reset: add cold/warm reset types dmukhin
2026-06-03 17:05   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c6df9e1-4c44-46bd-a400-c6ecee9ac5bf@cherry.de \
    --to=quentin.schulz@cherry.de \
    --cc=dmukhin@ford.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox