From: dmukhin@ford.com
To: Tom Rini <trini@konsulko.com>
Cc: dmukhin@ford.com, u-boot@lists.denx.de, sjg@chromium.org
Subject: Re: [PATCH v4 2/7] reset: Add explicit cold reset support
Date: Tue, 16 Jun 2026 23:29:08 -0700 [thread overview]
Message-ID: <ajI+tBSR87dqYdpr@kraken> (raw)
In-Reply-To: <20260616214450.GA1740849@bill-the-cat>
On Tue, Jun 16, 2026 at 03:44:50PM -0600, Tom Rini wrote:
> On Wed, Jun 03, 2026 at 12:07:38AM -0700, dmukhin@ford.com wrote:
>
> > Some prototype boards default to a non-cold reset type, e.g. warm reset.
> >
> > Add 'reset -c' so users can explicitly request a cold reset when needed.
> >
> > Signed-off-by: Denis Mukhin <dmukhin@ford.com>
> > ---
> > Changes since v3:
> > - preserved existing behavior for 'reset -edl' handling
> > - corrected commit message formatting
>
> This, and the subsequent test add growth in SPL on platforms that aren't
> using it, and then one of them is now too large to link. Looking harder
> at the code, we need to start out with some sort of re-factoring to move
> do_reset / do_poweroff out of drivers/sysreset/sysreset-uclass.c and in
> to something under cmd/ (and not conflict with the non-DM implementation
> of those functions).
> https://docs.u-boot-project.org/en/latest/develop/ci_testing.html is a
> pointer on running CI which I forget if I'd given you for something else
> or not yet, but would also show the current series failing on the
> rockchip world build job.
Thanks, will double check CI; I haven't tried CI yet.
>
> --
> Tom
next prev parent reply other threads:[~2026-06-17 6:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 7:07 [PATCH v4 0/7] reset: add board reset type dmukhin
2026-06-03 7:07 ` [PATCH v4 1/7] reset: Allow per-board " dmukhin
2026-06-03 7:07 ` [PATCH v4 2/7] reset: Add explicit cold reset support dmukhin
2026-06-03 17:04 ` Simon Glass
2026-06-16 21:44 ` Tom Rini
2026-06-17 6:29 ` dmukhin [this message]
2026-06-03 7:07 ` [PATCH v4 3/7] reset: Print reset type on diagnostic console dmukhin
2026-06-03 17:04 ` Simon Glass
2026-06-03 7:07 ` [PATCH v4 4/7] reset: x86: Use cpu_hlt() in pch_sysreset_power_off() dmukhin
2026-06-03 17:04 ` Simon Glass
2026-06-03 7:07 ` [PATCH v4 5/7] reset: x86: Use cpu_hlt() in efi_reset_system() dmukhin
2026-06-03 17:04 ` Simon Glass
2026-06-03 7:07 ` [PATCH v4 6/7] docs: reset: document cold reset option dmukhin
2026-06-03 17:04 ` Simon Glass
2026-06-03 7:07 ` [PATCH v4 7/7] tests: reset: add cold/warm reset types dmukhin
2026-06-03 17:05 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajI+tBSR87dqYdpr@kraken \
--to=dmukhin@ford.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox