From: Robert Schwebel <robert@schwebel.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Enforcement of coding standards
Date: Fri, 7 Mar 2003 07:29:51 +0100 [thread overview]
Message-ID: <20030307062951.GD16290@pengutronix.de> (raw)
In-Reply-To: <A1DD009E87CDD2119E940008C7334DA402249CBC@ns.radstone.co.uk>
On Thu, Mar 06, 2003 at 04:16:30PM -0000, Chris Elston wrote:
> I don't really want to get into the politics of when patches should be
> accepted/rejected, but I do agree that we need to have an honest (and
> friendly!) discussion of the #ifdef mess and coding standard enforcement
> issues.
Strong ack.
> Both Robert and Wolfgang have fair points. From Robert's point of view why
> be picky about formatting when the rest of the source isn't as neat as it
> could be. And from Wolfgang's point of view, why add more messy code - that
> will just make things worse.
No, the point was that these two // have been rejected, after lots of
coding style patches I've sent have also been rejected because "they do
not change functionality". Just for the record, I wanted to shut up
about that :-)
Robert
--
Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry
Braunschweiger Str. 79, 31134 Hildesheim, Germany
Handelsregister: Amtsgericht Hildesheim, HRA 2686
Phone: +49-5121-28619-0 | Fax: +49-5121-28619-4
next prev parent reply other threads:[~2003-03-07 6:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-06 16:16 [U-Boot-Users] Enforcement of coding standards Chris Elston
2003-03-06 19:30 ` [U-Boot-Users] Enforcement of coding standards my $0.02 worth Rod Boyce
2003-03-07 6:29 ` Robert Schwebel [this message]
2003-03-07 8:11 ` [U-Boot-Users] Enforcement of coding standards Wolfgang Denk
2003-03-07 8:34 ` Robert Schwebel
2003-03-07 8:58 ` Wolfgang Denk
2003-03-07 9:06 ` Robert Schwebel
-- strict thread matches above, loose matches on Subject: below --
2003-03-06 16:57 Rune Torgersen
2003-03-07 9:03 Chris Elston
2003-03-07 9:57 ` Wolfgang Denk
[not found] <0001AAA4.C22236@pengutronix.de>
2003-03-07 15:39 ` Jerry Van Baren
2003-03-07 19:47 ` Wolfgang Denk
2003-03-08 8:07 ` Robert Schwebel
2003-03-08 9:34 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030307062951.GD16290@pengutronix.de \
--to=robert@schwebel.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox