public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ladislav Michl <ladis@linux-mips.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] fix cfi_flash on LE systems
Date: Wed, 9 Jun 2004 15:44:29 +0200	[thread overview]
Message-ID: <20040609134429.GA6663@umax645sx> (raw)

Hi,

cfi_flash is missing inclusion of asm/byteorder.h, thus
__LITTLE_ENDIAN is undefined and driver is broken for LE systems.
Once there turn printf into debug as I guess it ought to be.

	ladis

Index: drivers/cfi_flash.c
===================================================================
RCS file: /cvsroot/u-boot/u-boot/drivers/cfi_flash.c,v
retrieving revision 1.8
diff -u -r1.8 cfi_flash.c
--- drivers/cfi_flash.c	23 Mar 2004 22:14:28 -0000	1.8
+++ drivers/cfi_flash.c	9 Jun 2004 13:24:35 -0000
@@ -46,6 +46,7 @@
 
 #include <common.h>
 #include <asm/processor.h>
+#include <asm/byteorder.h>
 #include <linux/byteorder/swab.h>
 #ifdef	CFG_FLASH_CFI_DRIVER
 
@@ -1038,7 +1039,7 @@
 				(tmp & 0xffff) ? ((tmp & 0xffff) * 256) : 128;
 			tmp >>= 16;
 			erase_region_count = (tmp & 0xffff) + 1;
-			printf ("erase_region_count = %d erase_region_size = %d\n",
+			debug ("erase_region_count = %d erase_region_size = %d\n",
 				erase_region_count, erase_region_size);
 			for (j = 0; j < erase_region_count; j++) {
 				info->start[sect_cnt] = sector;

             reply	other threads:[~2004-06-09 13:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-09 13:44 Ladislav Michl [this message]
2004-06-09 20:40 ` [U-Boot-Users] [PATCH] fix cfi_flash on LE systems Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040609134429.GA6663@umax645sx \
    --to=ladis@linux-mips.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox