* [U-Boot-Users] [PATCH] fix cfi_flash on LE systems
@ 2004-06-09 13:44 Ladislav Michl
2004-06-09 20:40 ` Wolfgang Denk
0 siblings, 1 reply; 2+ messages in thread
From: Ladislav Michl @ 2004-06-09 13:44 UTC (permalink / raw)
To: u-boot
Hi,
cfi_flash is missing inclusion of asm/byteorder.h, thus
__LITTLE_ENDIAN is undefined and driver is broken for LE systems.
Once there turn printf into debug as I guess it ought to be.
ladis
Index: drivers/cfi_flash.c
===================================================================
RCS file: /cvsroot/u-boot/u-boot/drivers/cfi_flash.c,v
retrieving revision 1.8
diff -u -r1.8 cfi_flash.c
--- drivers/cfi_flash.c 23 Mar 2004 22:14:28 -0000 1.8
+++ drivers/cfi_flash.c 9 Jun 2004 13:24:35 -0000
@@ -46,6 +46,7 @@
#include <common.h>
#include <asm/processor.h>
+#include <asm/byteorder.h>
#include <linux/byteorder/swab.h>
#ifdef CFG_FLASH_CFI_DRIVER
@@ -1038,7 +1039,7 @@
(tmp & 0xffff) ? ((tmp & 0xffff) * 256) : 128;
tmp >>= 16;
erase_region_count = (tmp & 0xffff) + 1;
- printf ("erase_region_count = %d erase_region_size = %d\n",
+ debug ("erase_region_count = %d erase_region_size = %d\n",
erase_region_count, erase_region_size);
for (j = 0; j < erase_region_count; j++) {
info->start[sect_cnt] = sector;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot-Users] [PATCH] fix cfi_flash on LE systems
2004-06-09 13:44 [U-Boot-Users] [PATCH] fix cfi_flash on LE systems Ladislav Michl
@ 2004-06-09 20:40 ` Wolfgang Denk
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2004-06-09 20:40 UTC (permalink / raw)
To: u-boot
In message <20040609134429.GA6663@umax645sx> you wrote:
>
> cfi_flash is missing inclusion of asm/byteorder.h, thus
> __LITTLE_ENDIAN is undefined and driver is broken for LE systems.
> Once there turn printf into debug as I guess it ought to be.
Both patches were checked in just today.
Sorry it took so long.
Best regards,
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
Accident: A condition in which presence of mind is good, but absence
of body is better.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-06-09 20:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-09 13:44 [U-Boot-Users] [PATCH] fix cfi_flash on LE systems Ladislav Michl
2004-06-09 20:40 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox