* [U-Boot-Users] Pull request u-boot-blackfin.git
@ 2008-02-23 6:17 Mike Frysinger
2008-02-23 8:42 ` Wolfgang Denk
0 siblings, 1 reply; 40+ messages in thread
From: Mike Frysinger @ 2008-02-23 6:17 UTC (permalink / raw)
To: u-boot
This cleans up and unifies much of the Blackfin cpu/arch directories.
The following changes since commit e5084af8ded58453cd07ec1af8b0f29f34122bbc:
Detlev Zundel (1):
Replace deprecated "ramdisk" with "ramdisk_size" kernel parameter.
are available in the git repository at:
git://www.denx.de/git/u-boot-blackfin.git master
Mike Frysinger (13):
Blackfin: move bootldr command to common code
Blackfin: convert BFIN_CPU to CONFIG_BFIN_CPU
Blackfin: move on-chip MAC driver into drivers/net/
Blackfin: BF537-stamp: drop board-specific flash driver for CFI
Blackfin: BF537-stamp: cleanup spi flash driver
Blackfin: update MAINTAINERS list
Blackfin: unify cpu and boot modes
Blackfin: new cplbinfo command for viewing cplb tables
Blackfin: add proper ELF markings to some assembly functions
Blackfin: cleanup lib_blackfin/cache.c
Blackfin: cleanup and overhaul common board init functions
smc91111: use SSYNC() rather than asm(ssync) for Blackfin
Blackfin: add error debug to serial driver
MAINTAINERS | 15 +
Makefile | 4 +-
blackfin_config.mk | 9 +-
board/bf533-ezkit/Makefile | 2 +-
board/bf533-ezkit/bf533-ezkit.c | 7 -
board/bf533-ezkit/config.mk | 6 +-
board/bf533-ezkit/u-boot.lds.S | 208 +++---
board/bf533-stamp/Makefile | 4 +-
board/bf533-stamp/bf533-stamp.c | 7 -
board/bf533-stamp/config.mk | 6 +-
board/bf533-stamp/spi.c | 474 ------------
board/bf533-stamp/spi_flash.c | 2 +
board/bf533-stamp/u-boot.lds.S | 206 +++---
board/bf537-stamp/Makefile | 4 +-
board/bf537-stamp/bf537-stamp.c | 68 +--
board/bf537-stamp/config.mk | 10 +-
board/bf537-stamp/flash-defines.h | 123 ---
board/bf537-stamp/flash.c | 403 ----------
board/bf537-stamp/spi_flash.c | 815 ++++++++++++++++++++
board/bf537-stamp/stm_m25p64.c | 516 -------------
board/bf537-stamp/u-boot.lds.S | 258 +++----
board/bf561-ezkit/Makefile | 2 +-
board/bf561-ezkit/config.mk | 6 +-
board/bf561-ezkit/u-boot.lds.S | 209 +++---
common/Makefile | 2 +
common/cmd_bootldr.c | 64 ++
common/cmd_cplbinfo.c | 59 ++
cpu/bf533/Makefile | 52 --
cpu/bf533/bf533_serial.h | 77 --
cpu/bf533/cache.S | 129 ---
cpu/bf533/config.mk | 27 -
cpu/bf533/cpu.c | 213 -----
cpu/bf533/cpu.h | 66 --
cpu/bf533/flush.S | 405 ----------
cpu/bf533/init_sdram.S | 183 -----
cpu/bf533/init_sdram_bootrom_initblock.S | 183 -----
cpu/bf533/interrupt.S | 244 ------
cpu/bf533/interrupts.c | 165 ----
cpu/bf533/ints.c | 112 ---
cpu/bf533/serial.c | 186 -----
cpu/bf533/start.S | 313 --------
cpu/bf533/traps.c | 238 ------
cpu/bf533/video.c | 194 -----
cpu/bf533/video.h | 25 -
cpu/bf537/Makefile | 52 --
cpu/bf537/cache.S | 129 ---
cpu/bf537/config.mk | 27 -
cpu/bf537/cpu.c | 219 ------
cpu/bf537/cpu.h | 66 --
cpu/bf537/flush.S | 403 ----------
cpu/bf537/init_sdram.S | 178 -----
cpu/bf537/init_sdram_bootrom_initblock.S | 203 -----
cpu/bf537/interrupt.S | 244 ------
cpu/bf537/interrupts.c | 170 ----
cpu/bf537/ints.c | 112 ---
cpu/bf537/serial.c | 186 -----
cpu/bf537/serial.h | 77 --
cpu/bf537/start.S | 576 --------------
cpu/bf537/start1.S | 38 -
cpu/bf537/traps.c | 239 ------
cpu/bf537/video.c | 194 -----
cpu/bf537/video.h | 25 -
cpu/bf561/Makefile | 52 --
cpu/bf561/cache.S | 129 ---
cpu/bf561/config.mk | 27 -
cpu/bf561/cpu.c | 212 -----
cpu/bf561/cpu.h | 66 --
cpu/bf561/flush.S | 402 ----------
cpu/bf561/init_sdram.S | 175 -----
cpu/bf561/init_sdram_bootrom_initblock.S | 189 -----
cpu/bf561/interrupt.S | 244 ------
cpu/bf561/ints.c | 112 ---
cpu/bf561/serial.c | 188 -----
cpu/bf561/serial.h | 77 --
cpu/bf561/start.S | 303 --------
cpu/bf561/start1.S | 38 -
cpu/bf561/traps.c | 238 ------
cpu/bf561/video.c | 194 -----
cpu/bf561/video.h | 25 -
cpu/blackfin/.gitignore | 1 +
cpu/blackfin/Makefile | 65 ++
cpu/blackfin/bootrom-asm-offsets.awk | 41 +
cpu/blackfin/bootrom-asm-offsets.c.in | 12 +
cpu/blackfin/cache.S | 61 ++
cpu/blackfin/cpu.c | 141 ++++
cpu/{bf533/start1.S => blackfin/cpu.h} | 28 +-
cpu/blackfin/flush.S | 230 ++++++
cpu/{bf537 => blackfin}/i2c.c | 98 ++-
cpu/blackfin/initcode.c | 353 +++++++++
cpu/blackfin/interrupt.S | 33 +
cpu/{bf561 => blackfin}/interrupts.c | 50 +-
cpu/blackfin/reset.c | 96 +++
cpu/blackfin/serial.c | 163 ++++
cpu/blackfin/serial.h | 275 +++++++
cpu/blackfin/start.S | 219 ++++++
cpu/blackfin/system_map.S | 18 +
cpu/blackfin/traps.c | 353 +++++++++
cpu/blackfin/watchdog.c | 25 +
drivers/net/Makefile | 1 +
.../ether_bf537.c => drivers/net/bfin_mac.c | 166 ++---
.../ether_bf537.h => drivers/net/bfin_mac.h | 32 +-
drivers/net/smc91111.h | 4 +-
include/asm-blackfin/blackfin-config-post.h | 6 +-
include/configs/bf533-ezkit.h | 53 +-
include/configs/bf533-stamp.h | 138 +---
include/configs/bf537-stamp.h | 143 +---
include/configs/bf561-ezkit.h | 42 +-
lib_blackfin/Makefile | 6 +-
lib_blackfin/bf533_linux.c | 85 --
lib_blackfin/bf533_string.c | 198 -----
lib_blackfin/bfin_string.c | 203 +++++
lib_blackfin/blackfin_board.h | 64 --
lib_blackfin/board.c | 432 ++++++-----
lib_blackfin/boot.c | 54 ++
lib_blackfin/cache.c | 35 +-
lib_blackfin/cache.h | 35 -
lib_blackfin/memcmp.S | 3 +
lib_blackfin/memcpy.S | 3 +
lib_blackfin/memmove.S | 3 +
lib_blackfin/memset.S | 3 +
120 files changed, 4250 insertions(+), 11831 deletions(-)
delete mode 100644 board/bf533-stamp/spi.c
create mode 100644 board/bf533-stamp/spi_flash.c
delete mode 100644 board/bf537-stamp/flash-defines.h
delete mode 100644 board/bf537-stamp/flash.c
create mode 100644 board/bf537-stamp/spi_flash.c
delete mode 100644 board/bf537-stamp/stm_m25p64.c
create mode 100644 common/cmd_bootldr.c
create mode 100644 common/cmd_cplbinfo.c
delete mode 100644 cpu/bf533/Makefile
delete mode 100644 cpu/bf533/bf533_serial.h
delete mode 100644 cpu/bf533/cache.S
delete mode 100644 cpu/bf533/config.mk
delete mode 100644 cpu/bf533/cpu.c
delete mode 100644 cpu/bf533/cpu.h
delete mode 100644 cpu/bf533/flush.S
delete mode 100644 cpu/bf533/init_sdram.S
delete mode 100644 cpu/bf533/init_sdram_bootrom_initblock.S
delete mode 100644 cpu/bf533/interrupt.S
delete mode 100644 cpu/bf533/interrupts.c
delete mode 100644 cpu/bf533/ints.c
delete mode 100644 cpu/bf533/serial.c
delete mode 100644 cpu/bf533/start.S
delete mode 100644 cpu/bf533/traps.c
delete mode 100644 cpu/bf533/video.c
delete mode 100644 cpu/bf533/video.h
delete mode 100644 cpu/bf537/Makefile
delete mode 100644 cpu/bf537/cache.S
delete mode 100644 cpu/bf537/config.mk
delete mode 100644 cpu/bf537/cpu.c
delete mode 100644 cpu/bf537/cpu.h
delete mode 100644 cpu/bf537/flush.S
delete mode 100644 cpu/bf537/init_sdram.S
delete mode 100644 cpu/bf537/init_sdram_bootrom_initblock.S
delete mode 100644 cpu/bf537/interrupt.S
delete mode 100644 cpu/bf537/interrupts.c
delete mode 100644 cpu/bf537/ints.c
delete mode 100644 cpu/bf537/serial.c
delete mode 100644 cpu/bf537/serial.h
delete mode 100644 cpu/bf537/start.S
delete mode 100644 cpu/bf537/start1.S
delete mode 100644 cpu/bf537/traps.c
delete mode 100644 cpu/bf537/video.c
delete mode 100644 cpu/bf537/video.h
delete mode 100644 cpu/bf561/Makefile
delete mode 100644 cpu/bf561/cache.S
delete mode 100644 cpu/bf561/config.mk
delete mode 100644 cpu/bf561/cpu.c
delete mode 100644 cpu/bf561/cpu.h
delete mode 100644 cpu/bf561/flush.S
delete mode 100644 cpu/bf561/init_sdram.S
delete mode 100644 cpu/bf561/init_sdram_bootrom_initblock.S
delete mode 100644 cpu/bf561/interrupt.S
delete mode 100644 cpu/bf561/ints.c
delete mode 100644 cpu/bf561/serial.c
delete mode 100644 cpu/bf561/serial.h
delete mode 100644 cpu/bf561/start.S
delete mode 100644 cpu/bf561/start1.S
delete mode 100644 cpu/bf561/traps.c
delete mode 100644 cpu/bf561/video.c
delete mode 100644 cpu/bf561/video.h
create mode 100644 cpu/blackfin/.gitignore
create mode 100644 cpu/blackfin/Makefile
create mode 100755 cpu/blackfin/bootrom-asm-offsets.awk
create mode 100644 cpu/blackfin/bootrom-asm-offsets.c.in
create mode 100644 cpu/blackfin/cache.S
create mode 100644 cpu/blackfin/cpu.c
rename cpu/{bf533/start1.S => blackfin/cpu.h} (68%)
create mode 100644 cpu/blackfin/flush.S
rename cpu/{bf537 => blackfin}/i2c.c (75%)
create mode 100644 cpu/blackfin/initcode.c
create mode 100644 cpu/blackfin/interrupt.S
rename cpu/{bf561 => blackfin}/interrupts.c (68%)
create mode 100644 cpu/blackfin/reset.c
create mode 100644 cpu/blackfin/serial.c
create mode 100644 cpu/blackfin/serial.h
create mode 100644 cpu/blackfin/start.S
create mode 100644 cpu/blackfin/system_map.S
create mode 100644 cpu/blackfin/traps.c
create mode 100644 cpu/blackfin/watchdog.c
rename board/bf537-stamp/ether_bf537.c => drivers/net/bfin_mac.c (77%)
rename board/bf537-stamp/ether_bf537.h => drivers/net/bfin_mac.h (70%)
delete mode 100644 lib_blackfin/bf533_linux.c
delete mode 100644 lib_blackfin/bf533_string.c
create mode 100644 lib_blackfin/bfin_string.c
delete mode 100644 lib_blackfin/blackfin_board.h
create mode 100644 lib_blackfin/boot.c
delete mode 100644 lib_blackfin/cache.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080223/9a417e53/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-23 6:17 [U-Boot-Users] Pull request u-boot-blackfin.git Mike Frysinger
@ 2008-02-23 8:42 ` Wolfgang Denk
2008-02-23 8:59 ` Mike Frysinger
0 siblings, 1 reply; 40+ messages in thread
From: Wolfgang Denk @ 2008-02-23 8:42 UTC (permalink / raw)
To: u-boot
In message <200802230117.03679.vapier@gentoo.org> you wrote:
>
> Mike Frysinger (13):
> Blackfin: move bootldr command to common code
> Blackfin: convert BFIN_CPU to CONFIG_BFIN_CPU
> Blackfin: move on-chip MAC driver into drivers/net/
> Blackfin: BF537-stamp: drop board-specific flash driver for CFI
> Blackfin: BF537-stamp: cleanup spi flash driver
> Blackfin: update MAINTAINERS list
> Blackfin: unify cpu and boot modes
> Blackfin: new cplbinfo command for viewing cplb tables
> Blackfin: add proper ELF markings to some assembly functions
> Blackfin: cleanup lib_blackfin/cache.c
> Blackfin: cleanup and overhaul common board init functions
> smc91111: use SSYNC() rather than asm(ssync) for Blackfin
> Blackfin: add error debug to serial driver
Hm... where are these changes coming from?
I don't think any of them have been poosted on the mailing list
before?
And things like "new cplbinfo command" don't exactly look like bug
fixesto me - remember that no merge window is open at the moment, so
no new stuff may be added, just bugs fixed.
Please explain...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Niklaus Wirth has lamented that, whereas Europeans pronounce his name
correctly (Ni-klows Virt), Americans invariably mangle it into
(Nick-les Worth). Which is to say that Europeans call him by name,
but Americans call him by value.
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-23 8:42 ` Wolfgang Denk
@ 2008-02-23 8:59 ` Mike Frysinger
2008-02-23 19:36 ` Wolfgang Denk
0 siblings, 1 reply; 40+ messages in thread
From: Mike Frysinger @ 2008-02-23 8:59 UTC (permalink / raw)
To: u-boot
On Saturday 23 February 2008, Wolfgang Denk wrote:
> In message <200802230117.03679.vapier@gentoo.org> you wrote:
> > Mike Frysinger (13):
> > Blackfin: move bootldr command to common code
> > Blackfin: convert BFIN_CPU to CONFIG_BFIN_CPU
> > Blackfin: move on-chip MAC driver into drivers/net/
> > Blackfin: BF537-stamp: drop board-specific flash driver for CFI
> > Blackfin: BF537-stamp: cleanup spi flash driver
> > Blackfin: update MAINTAINERS list
> > Blackfin: unify cpu and boot modes
> > Blackfin: new cplbinfo command for viewing cplb tables
> > Blackfin: add proper ELF markings to some assembly functions
> > Blackfin: cleanup lib_blackfin/cache.c
> > Blackfin: cleanup and overhaul common board init functions
> > smc91111: use SSYNC() rather than asm(ssync) for Blackfin
> > Blackfin: add error debug to serial driver
>
> Hm... where are these changes coming from?
i'm in the process of merging the u-boot fork that we've been using at
blackfin.uclinux.org
> I don't think any of them have been poosted on the mailing list
> before?
nope
> And things like "new cplbinfo command" don't exactly look like bug
> fixesto me - remember that no merge window is open at the moment, so
> no new stuff may be added, just bugs fixed.
the Blackfin port in u-boot mainline has never worked, so i dont think it's a
big deal ... and i still dont consider the mainline code "supported" until
ive finished syncing all of the changes from the blackfin.uclinux.org svn
into mainline. at that point, i can shut down our svn and switch it over to
a read-only mirror of the git repo.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080223/d262b719/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-23 8:59 ` Mike Frysinger
@ 2008-02-23 19:36 ` Wolfgang Denk
2008-02-23 20:29 ` Mike Frysinger
0 siblings, 1 reply; 40+ messages in thread
From: Wolfgang Denk @ 2008-02-23 19:36 UTC (permalink / raw)
To: u-boot
In message <200802230359.32224.vapier@gentoo.org> you wrote:
>
> > In message <200802230117.03679.vapier@gentoo.org> you wrote:
> > > Mike Frysinger (13):
> > > Blackfin: move bootldr command to common code
> > > Blackfin: convert BFIN_CPU to CONFIG_BFIN_CPU
> > > Blackfin: move on-chip MAC driver into drivers/net/
> > > Blackfin: BF537-stamp: drop board-specific flash driver for CFI
> > > Blackfin: BF537-stamp: cleanup spi flash driver
> > > Blackfin: update MAINTAINERS list
> > > Blackfin: unify cpu and boot modes
> > > Blackfin: new cplbinfo command for viewing cplb tables
> > > Blackfin: add proper ELF markings to some assembly functions
> > > Blackfin: cleanup lib_blackfin/cache.c
> > > Blackfin: cleanup and overhaul common board init functions
> > > smc91111: use SSYNC() rather than asm(ssync) for Blackfin
> > > Blackfin: add error debug to serial driver
> >
> > Hm... where are these changes coming from?
>
> i'm in the process of merging the u-boot fork that we've been using at=20
> blackfin.uclinux.org
>
> > I don't think any of them have been poosted on the mailing list
> > before?
>
> nope
Then that cannot go in now. We would break several rules at once:
patches must be posted to the list first, and new stuff will get
merged only when a merge window is open.
You shouldn't have sent this pull request now.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If all you have is a hammer, everything looks like a nail.
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-23 19:36 ` Wolfgang Denk
@ 2008-02-23 20:29 ` Mike Frysinger
2008-02-23 22:25 ` Haavard Skinnemoen
2008-02-23 22:30 ` Wolfgang Denk
0 siblings, 2 replies; 40+ messages in thread
From: Mike Frysinger @ 2008-02-23 20:29 UTC (permalink / raw)
To: u-boot
On Saturday 23 February 2008, Wolfgang Denk wrote:
> In message <200802230359.32224.vapier@gentoo.org> you wrote:
> > > In message <200802230117.03679.vapier@gentoo.org> you wrote:
> > > > Mike Frysinger (13):
> > > > Blackfin: move bootldr command to common code
> > > > Blackfin: convert BFIN_CPU to CONFIG_BFIN_CPU
> > > > Blackfin: move on-chip MAC driver into drivers/net/
> > > > Blackfin: BF537-stamp: drop board-specific flash driver for CFI
> > > > Blackfin: BF537-stamp: cleanup spi flash driver
> > > > Blackfin: update MAINTAINERS list
> > > > Blackfin: unify cpu and boot modes
> > > > Blackfin: new cplbinfo command for viewing cplb tables
> > > > Blackfin: add proper ELF markings to some assembly functions
> > > > Blackfin: cleanup lib_blackfin/cache.c
> > > > Blackfin: cleanup and overhaul common board init functions
> > > > smc91111: use SSYNC() rather than asm(ssync) for Blackfin
> > > > Blackfin: add error debug to serial driver
> > >
> > > Hm... where are these changes coming from?
> >
> > i'm in the process of merging the u-boot fork that we've been using at=20
> > blackfin.uclinux.org
> >
> > > I don't think any of them have been poosted on the mailing list
> > > before?
> >
> > nope
>
> Then that cannot go in now. We would break several rules at once:
> patches must be posted to the list first, and new stuff will get
> merged only when a merge window is open.
i understand where you're coming from, and i intend to follow the rules ...
after Blackfin in mainline is actually usable. i'm being pragmatic here:
since Blackfin literrally has never compiled/linked in the mainline releases,
theres no way i could break it even more. delaying these updates to make
mainline Blackfin u-boot usable is only that: delay.
as for posting the patches to the list, how do you know whether to merge it
directly or pull from a repo ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080223/ae548bde/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-23 20:29 ` Mike Frysinger
@ 2008-02-23 22:25 ` Haavard Skinnemoen
2008-02-23 23:17 ` Mike Frysinger
2008-02-23 22:30 ` Wolfgang Denk
1 sibling, 1 reply; 40+ messages in thread
From: Haavard Skinnemoen @ 2008-02-23 22:25 UTC (permalink / raw)
To: u-boot
On Sat, 23 Feb 2008 15:29:03 -0500
Mike Frysinger <vapier@gentoo.org> wrote:
> i understand where you're coming from, and i intend to follow the rules ...
> after Blackfin in mainline is actually usable. i'm being pragmatic here:
> since Blackfin literrally has never compiled/linked in the mainline releases,
> theres no way i could break it even more. delaying these updates to make
> mainline Blackfin u-boot usable is only that: delay.
Come on, you know damn well it's not acceptable to add tons of new
features (including, from the look of it, two new commands) this close
to a release.
You should focus on getting the thing to work (why was it merged in the
first place if it didn't work, btw?) not try to achieve feature-parity
with the out-of-tree code.
There are way too many useless commands in the tree as it is, we don't
want even more unreviewed crap sneaking in through the back door.
Haavard
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-23 22:25 ` Haavard Skinnemoen
@ 2008-02-23 23:17 ` Mike Frysinger
2008-02-23 23:50 ` Haavard Skinnemoen
0 siblings, 1 reply; 40+ messages in thread
From: Mike Frysinger @ 2008-02-23 23:17 UTC (permalink / raw)
To: u-boot
On Saturday 23 February 2008, Haavard Skinnemoen wrote:
> On Sat, 23 Feb 2008 15:29:03 -0500
>
> Mike Frysinger <vapier@gentoo.org> wrote:
> > i understand where you're coming from, and i intend to follow the rules
> > ... after Blackfin in mainline is actually usable. i'm being pragmatic
> > here: since Blackfin literrally has never compiled/linked in the mainline
> > releases, theres no way i could break it even more. delaying these
> > updates to make mainline Blackfin u-boot usable is only that: delay.
>
> Come on, you know damn well it's not acceptable to add tons of new
> features (including, from the look of it, two new commands) this close
> to a release.
i'd agree with you completely if Blackfin were currently usable
> You should focus on getting the thing to work (why was it merged in the
> first place if it didn't work, btw?) not try to achieve feature-parity
> with the out-of-tree code.
ive had no involvement in the past development. if you want to say it sucked
or complain about how it was done, i dont really care. only moving forward
from the current situation matters to me.
as for getting it to work, i dont see the value in getting an old dead version
of the Blackfin tree working when i have a clean rewritten tree to merge. if
i get the old one to boot, so what ? the resulting code base isnt
supported ... if someone says "i tried to do XYZ with the Blackfin code and
it didnt work", i'm going to look at it and say "it works with this other
code base, so i dont care. you can wait until i finish merging this tree."
> There are way too many useless commands in the tree as it is, we don't
> want even more unreviewed crap sneaking in through the back door.
if you look at all the new commands you'll see that (1) they're optional and
(2) they expose Blackfin specific functionality. these affect no other
arches.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080223/71be3cb8/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-23 23:17 ` Mike Frysinger
@ 2008-02-23 23:50 ` Haavard Skinnemoen
2008-02-24 0:07 ` Mike Frysinger
0 siblings, 1 reply; 40+ messages in thread
From: Haavard Skinnemoen @ 2008-02-23 23:50 UTC (permalink / raw)
To: u-boot
On Sat, 23 Feb 2008 18:17:34 -0500
Mike Frysinger <vapier@gentoo.org> wrote:
> ive had no involvement in the past development. if you want to say it sucked
> or complain about how it was done, i dont really care. only moving forward
> from the current situation matters to me.
I'm not saying it sucks. You're the one who said it's broken ;-)
> as for getting it to work, i dont see the value in getting an old dead version
> of the Blackfin tree working when i have a clean rewritten tree to merge. if
> i get the old one to boot, so what ? the resulting code base isnt
> supported ... if someone says "i tried to do XYZ with the Blackfin code and
> it didnt work", i'm going to look at it and say "it works with this other
> code base, so i dont care. you can wait until i finish merging this tree."
That's why we do incremental improvements so that you can separate the
fixes from the other stuff and submit them even if there isn't a merge
window open.
> > There are way too many useless commands in the tree as it is, we don't
> > want even more unreviewed crap sneaking in through the back door.
>
> if you look at all the new commands you'll see that (1) they're optional and
> (2) they expose Blackfin specific functionality. these affect no other
> arches.
First, if they're blackfin-specific, what are they doing under common/?
Second, the SPI driver that broke the tree for almost four weeks was
optional and ppc-specific. Have you run tests on all architectures so
that you can be 100% sure that you're not breaking anything this late
in the release cycle?
The avr32 architecture broke three times during the Linux 2.6.25-rc1
merge window, as did lots of other architectures (which isn't a huge
deal since it was, after all, during the merge window, but it breaks
bisectability). In two of the cases it was caused by patches that were
deemed so simple that they didn't get proper review and were never
exposed in -mm.
Which is why I've been a bit grumpy lately with respect to real and
potential breakage in mainline, in case anyone wondered.
Your tree touches common code and you're asking for it to be merged
without any review at all. I don't think that's a good idea.
Haavard
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-23 23:50 ` Haavard Skinnemoen
@ 2008-02-24 0:07 ` Mike Frysinger
2008-02-24 0:29 ` Wolfgang Denk
2008-02-24 0:35 ` Haavard Skinnemoen
0 siblings, 2 replies; 40+ messages in thread
From: Mike Frysinger @ 2008-02-24 0:07 UTC (permalink / raw)
To: u-boot
On Saturday 23 February 2008, Haavard Skinnemoen wrote:
> Mike Frysinger <vapier@gentoo.org> wrote:
> > ive had no involvement in the past development. if you want to say it
> > sucked or complain about how it was done, i dont really care. only
> > moving forward from the current situation matters to me.
>
> I'm not saying it sucks. You're the one who said it's broken ;-)
it is broken. broken as in it wont compile let alone link for any Blackfin
code.
> > as for getting it to work, i dont see the value in getting an old dead
> > version of the Blackfin tree working when i have a clean rewritten tree
> > to merge. if i get the old one to boot, so what ? the resulting code
> > base isnt supported ... if someone says "i tried to do XYZ with the
> > Blackfin code and it didnt work", i'm going to look at it and say "it
> > works with this other code base, so i dont care. you can wait until i
> > finish merging this tree."
>
> That's why we do incremental improvements so that you can separate the
> fixes from the other stuff and submit them even if there isn't a merge
> window open.
it's already been done
> > > There are way too many useless commands in the tree as it is, we don't
> > > want even more unreviewed crap sneaking in through the back door.
> >
> > if you look at all the new commands you'll see that (1) they're optional
> > and (2) they expose Blackfin specific functionality. these affect no
> > other arches.
>
> First, if they're blackfin-specific, what are they doing under common/?
my understanding was that all commands go in common/. there's plenty of
arch-specific commands in there already.
> Second, the SPI driver that broke the tree for almost four weeks was
> optional and ppc-specific. Have you run tests on all architectures so
> that you can be 100% sure that you're not breaking anything this late
> in the release cycle?
i make my things conditionally compiled (see the Makefile). so yes, i'm 100%
sure i'm not breaking anyone. if you add the CONFIG_xxx to your board
config, well that's your fault ;).
> Your tree touches common code
Blackfin-specific pieces of common code ... there's a difference
> you're asking for it to be merged
> without any review at all. I don't think that's a good idea.
i'm asking for the Blackfin pieces to be merged regardless of "merge window".
i'm making no requests wrt review. Wolfgang wants it reviewed first -- i'm
fine with that. complaining that Blackfin changes are going in that
arent "pure fixes" i dont care about (right now).
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080223/e8a8e876/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-24 0:07 ` Mike Frysinger
@ 2008-02-24 0:29 ` Wolfgang Denk
2008-02-24 0:39 ` Mike Frysinger
2008-02-24 0:35 ` Haavard Skinnemoen
1 sibling, 1 reply; 40+ messages in thread
From: Wolfgang Denk @ 2008-02-24 0:29 UTC (permalink / raw)
To: u-boot
In message <200802231907.22816.vapier@gentoo.org> you wrote:
>
> > you're asking for it to be merged
> > without any review at all. I don't think that's a good idea.
>
> i'm asking for the Blackfin pieces to be merged regardless of "merge window".
I already said "no", and I see no reason to reconsider.
> i'm making no requests wrt review. Wolfgang wants it reviewed first -- i'm
> fine with that. complaining that Blackfin changes are going in that
> arent "pure fixes" i dont care about (right now).
Hm.. you did read http://www.denx.de/wiki/UBoot/DevelopmentProcess -
didn't you?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As far as the laws of mathematics refer to reality, they are not cer-
tain, and as far as they are certain, they do not refer to reality.
-- Albert Einstein
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-24 0:29 ` Wolfgang Denk
@ 2008-02-24 0:39 ` Mike Frysinger
2008-02-24 1:22 ` Wolfgang Denk
0 siblings, 1 reply; 40+ messages in thread
From: Mike Frysinger @ 2008-02-24 0:39 UTC (permalink / raw)
To: u-boot
On Saturday 23 February 2008, Wolfgang Denk wrote:
> In message <200802231907.22816.vapier@gentoo.org> you wrote:
> > > you're asking for it to be merged
> > > without any review at all. I don't think that's a good idea.
> >
> > i'm asking for the Blackfin pieces to be merged regardless of "merge
> > window".
>
> I already said "no", and I see no reason to reconsider.
then the Blackfin tree stays broken. whatever, no skin off my back.
> > i'm making no requests wrt review. Wolfgang wants it reviewed first --
> > i'm fine with that. complaining that Blackfin changes are going in that
> > arent "pure fixes" i dont care about (right now).
>
> Hm.. you did read http://www.denx.de/wiki/UBoot/DevelopmentProcess -
> didn't you?
of course i have. writing out rules is to codify the spirit of the process so
that people can jump in and know how things works. however, the point of the
rules isnt to have a rigid unchanging methodology, but to keep things flowing
in the spirit: merge windows allow new fun stuff while the non-merge time is
for bugfixes only. this of course assumes that the tree in question is
stable/usable in the first place. if it isnt, then there isnt much point to
locking out changes to move it in that direction.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080223/7239941a/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-24 0:39 ` Mike Frysinger
@ 2008-02-24 1:22 ` Wolfgang Denk
2008-02-24 1:37 ` Mike Frysinger
0 siblings, 1 reply; 40+ messages in thread
From: Wolfgang Denk @ 2008-02-24 1:22 UTC (permalink / raw)
To: u-boot
In message <200802231939.51739.vapier@gentoo.org> you wrote:
>
> of course i have. writing out rules is to codify the spirit of the process so
> that people can jump in and know how things works. however, the point of the
> rules isnt to have a rigid unchanging methodology, but to keep things flowing
> in the spirit: merge windows allow new fun stuff while the non-merge time is
> for bugfixes only. this of course assumes that the tree in question is
> stable/usable in the first place. if it isnt, then there isnt much point to
> locking out changes to move it in that direction.
The tree in general is actually pretty stable/usable as of now; I
know only of a few (minor) problems.
If the BF stuff is in bad shape, then I'm sorry about this, but 1)
you could have posted your stuff in the merge window like everybody
else, or 2) you have to wait until the next merge window like
everybody else. I will not destabilize the whole tree for a single
architecture.
If you have bug fixes, please go on and post these and I will make
sure they go in as fast as possible.
But I will not add major new code now.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q: How do you play religious roulette?
A: You stand around in a circle and blaspheme and see who gets
struck by lightning first.
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-24 1:22 ` Wolfgang Denk
@ 2008-02-24 1:37 ` Mike Frysinger
2008-02-24 13:44 ` Wolfgang Denk
0 siblings, 1 reply; 40+ messages in thread
From: Mike Frysinger @ 2008-02-24 1:37 UTC (permalink / raw)
To: u-boot
On Saturday 23 February 2008, Wolfgang Denk wrote:
> In message <200802231939.51739.vapier@gentoo.org> you wrote:
> > of course i have. writing out rules is to codify the spirit of the
> > process so that people can jump in and know how things works. however,
> > the point of the rules isnt to have a rigid unchanging methodology, but
> > to keep things flowing in the spirit: merge windows allow new fun stuff
> > while the non-merge time is for bugfixes only. this of course assumes
> > that the tree in question is stable/usable in the first place. if it
> > isnt, then there isnt much point to locking out changes to move it in
> > that direction.
>
> The tree in general is actually pretty stable/usable as of now; I
> know only of a few (minor) problems.
>
> If the BF stuff is in bad shape, then I'm sorry about this, but 1)
> you could have posted your stuff in the merge window like everybody
> else, or 2) you have to wait until the next merge window like
> everybody else. I will not destabilize the whole tree for a single
> architecture.
>
> If you have bug fixes, please go on and post these and I will make
> sure they go in as fast as possible.
>
> But I will not add major new code now.
wrt Blackfin, those statements are conflicting. fixing the Blackfin tree
involves major new code. of the changes i posted, only 2 or 3 touch
Blackfin-specific pieces in files outside of Blackfin trees, and do so in a
controlled manner (obj-$(CONFIG) in the Makefiles). those are not
generally "bugfix" in nature though.
but you dont really care: it's big changes that havent been posted to the
u-boot list for review, only been reviewed in the Blackfin fork on
blackfin.uclinux.org by our team / customers over the last year.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080223/ba14c162/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-24 1:37 ` Mike Frysinger
@ 2008-02-24 13:44 ` Wolfgang Denk
0 siblings, 0 replies; 40+ messages in thread
From: Wolfgang Denk @ 2008-02-24 13:44 UTC (permalink / raw)
To: u-boot
In message <200802232037.40287.vapier@gentoo.org> you wrote:
>
> wrt Blackfin, those statements are conflicting. fixing the Blackfin tree
> involves major new code. of the changes i posted, only 2 or 3 touch
Then it has to wait until the next merge window. That won't take that
long.
> but you dont really care: it's big changes that havent been posted to the
> u-boot list for review, only been reviewed in the Blackfin fork on
> blackfin.uclinux.org by our team / customers over the last year.
If I didn't care I would not continue to try to explain all this to
you.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are bugs and then there are bugs. And then there are bugs.
- Karl Lehenbauer
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-24 0:07 ` Mike Frysinger
2008-02-24 0:29 ` Wolfgang Denk
@ 2008-02-24 0:35 ` Haavard Skinnemoen
2008-02-24 1:15 ` Mike Frysinger
2008-02-24 13:55 ` Jean-Christophe PLAGNIOL-VILLARD
1 sibling, 2 replies; 40+ messages in thread
From: Haavard Skinnemoen @ 2008-02-24 0:35 UTC (permalink / raw)
To: u-boot
On Sat, 23 Feb 2008 19:07:22 -0500
Mike Frysinger <vapier@gentoo.org> wrote:
> > That's why we do incremental improvements so that you can separate the
> > fixes from the other stuff and submit them even if there isn't a merge
> > window open.
>
> it's already been done
Then how come you're still trying to push 400k changesets outside the
merge window?
> my understanding was that all commands go in common/. there's plenty of
> arch-specific commands in there already.
I still think it's wrong...although if there's an existing consensus
that all commands go under common/, I'm not going to argue further
against it.
> > Second, the SPI driver that broke the tree for almost four weeks was
> > optional and ppc-specific. Have you run tests on all architectures so
> > that you can be 100% sure that you're not breaking anything this late
> > in the release cycle?
>
> i make my things conditionally compiled (see the Makefile). so yes, i'm 100%
> sure i'm not breaking anyone. if you add the CONFIG_xxx to your board
> config, well that's your fault ;).
Famous last words ;)
I take it you're absolutely sure that the new CONFIG_xxx symbols aren't
already being used anywhere?
> > Your tree touches common code
>
> Blackfin-specific pieces of common code ... there's a difference
Isn't that a contradiction? If it's blackfin-specific, it can't really
be common, can it?
And are you sure that the commands cannot be reworked to be usable on
other architectures as well? That sort of thing might come out of a
review, you know...
> > you're asking for it to be merged
> > without any review at all. I don't think that's a good idea.
>
> i'm asking for the Blackfin pieces to be merged regardless of "merge window".
> i'm making no requests wrt review. Wolfgang wants it reviewed first -- i'm
> fine with that. complaining that Blackfin changes are going in that
> arent "pure fixes" i dont care about (right now).
Ok, I'm not all that concerned about the Blackfin stuff. But I think
that, at a minimum, the stuff under common/ and drivers/ should be
posted for review, and the stuff under driver/net should preferably go
in through the Networking custodian.
Haavard
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-24 0:35 ` Haavard Skinnemoen
@ 2008-02-24 1:15 ` Mike Frysinger
2008-02-24 13:55 ` Jean-Christophe PLAGNIOL-VILLARD
1 sibling, 0 replies; 40+ messages in thread
From: Mike Frysinger @ 2008-02-24 1:15 UTC (permalink / raw)
To: u-boot
On Saturday 23 February 2008, Haavard Skinnemoen wrote:
> Mike Frysinger <vapier@gentoo.org> wrote:
> > > That's why we do incremental improvements so that you can separate the
> > > fixes from the other stuff and submit them even if there isn't a merge
> > > window open.
> >
> > it's already been done
>
> Then how come you're still trying to push 400k changesets outside the
> merge window?
as i said, i find the merge window irrelevant to Blackfin as until i'm done
merging the external fork back into mainline. Wolfgang disagrees which means
the process of getting Blackfin working is delayed.
> > my understanding was that all commands go in common/. there's plenty of
> > arch-specific commands in there already.
>
> I still think it's wrong...although if there's an existing consensus
> that all commands go under common/, I'm not going to argue further
> against it.
i'd agree as i used to put Blackfin specific commands in lib_blackfin/. but i
figured folding back might as well go the currently accepted route. doesnt
matter to me one way or the other.
> > > Second, the SPI driver that broke the tree for almost four weeks was
> > > optional and ppc-specific. Have you run tests on all architectures so
> > > that you can be 100% sure that you're not breaking anything this late
> > > in the release cycle?
> >
> > i make my things conditionally compiled (see the Makefile). so yes, i'm
> > 100% sure i'm not breaking anyone. if you add the CONFIG_xxx to your
> > board config, well that's your fault ;).
>
> Famous last words ;)
>
> I take it you're absolutely sure that the new CONFIG_xxx symbols aren't
> already being used anywhere?
grep says only Blackfin
> > > Your tree touches common code
> >
> > Blackfin-specific pieces of common code ... there's a difference
>
> Isn't that a contradiction?
no ...
> If it's blackfin-specific, it can't really be common, can it?
i'm just working with how u-boot is designed. u-boot has common code that
has '#ifdef CONFIG_<ARCH>' and that is where the changes for Blackfin are.
> And are you sure that the commands cannot be reworked to be usable on
> other architectures as well? That sort of thing might come out of a
> review, you know...
unless some other architecture is designing cache tables the same way as
Blackfin, or designing their boot process to use the same exact file format
that the Blackfin uses, then i doubt it's useful to anyone else.
> > > you're asking for it to be merged
> > > without any review at all. I don't think that's a good idea.
> >
> > i'm asking for the Blackfin pieces to be merged regardless of "merge
> > window". i'm making no requests wrt review. Wolfgang wants it reviewed
> > first -- i'm fine with that. complaining that Blackfin changes are going
> > in that arent "pure fixes" i dont care about (right now).
>
> Ok, I'm not all that concerned about the Blackfin stuff. But I think
> that, at a minimum, the stuff under common/ and drivers/ should be
> posted for review, and the stuff under driver/net should preferably go
> in through the Networking custodian.
i plan on taking them out of the public repo and posting them for review
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080223/ca149883/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-24 0:35 ` Haavard Skinnemoen
2008-02-24 1:15 ` Mike Frysinger
@ 2008-02-24 13:55 ` Jean-Christophe PLAGNIOL-VILLARD
2008-02-24 16:48 ` Mike Frysinger
1 sibling, 1 reply; 40+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2008-02-24 13:55 UTC (permalink / raw)
To: u-boot
On 01:35 Sun 24 Feb , Haavard Skinnemoen wrote:
> On Sat, 23 Feb 2008 19:07:22 -0500
> Mike Frysinger <vapier@gentoo.org> wrote:
>
> > > Your tree touches common code
> >
> > Blackfin-specific pieces of common code ... there's a difference
>
> Isn't that a contradiction? If it's blackfin-specific, it can't really
> be common, can it?
>
> And are you sure that the commands cannot be reworked to be usable on
> other architectures as well? That sort of thing might come out of a
> review, you know...
As example the SPI flash will be good to merge it to the common drivers/mtd
and be usable on other architectures
Best Regards,
J.
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-24 13:55 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2008-02-24 16:48 ` Mike Frysinger
0 siblings, 0 replies; 40+ messages in thread
From: Mike Frysinger @ 2008-02-24 16:48 UTC (permalink / raw)
To: u-boot
On Sunday 24 February 2008, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 01:35 Sun 24 Feb , Haavard Skinnemoen wrote:
> > Mike Frysinger <vapier@gentoo.org> wrote:
> > > > Your tree touches common code
> > >
> > > Blackfin-specific pieces of common code ... there's a difference
> >
> > Isn't that a contradiction? If it's blackfin-specific, it can't really
> > be common, can it?
> >
> > And are you sure that the commands cannot be reworked to be usable on
> > other architectures as well? That sort of thing might come out of a
> > review, you know...
>
> As example the SPI flash will be good to merge it to the common drivers/mtd
> and be usable on other architectures
which is already being done and no reason to hold up merging of code that
affects Blackfin boards only
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080224/d581b498/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-23 20:29 ` Mike Frysinger
2008-02-23 22:25 ` Haavard Skinnemoen
@ 2008-02-23 22:30 ` Wolfgang Denk
2008-02-23 23:19 ` Mike Frysinger
1 sibling, 1 reply; 40+ messages in thread
From: Wolfgang Denk @ 2008-02-23 22:30 UTC (permalink / raw)
To: u-boot
In message <200802231529.04407.vapier@gentoo.org> you wrote:
>
> > Then that cannot go in now. We would break several rules at once:
> > patches must be posted to the list first, and new stuff will get
> > merged only when a merge window is open.
>
> since Blackfin literrally has never compiled/linked in the mainline releases,
> theres no way i could break it even more. delaying these updates to make
> mainline Blackfin u-boot usable is only that: delay.
Still the patches need to be reviewed first.
> as for posting the patches to the list, how do you know whether to merge it
> directly or pull from a repo ?
In cases like this one, where there is a custodian who caresa about
the topic of the patches, I wait for his pull request and then pull
from the repo. The posting of the patches is primarily for giving
others a chance to review the stuff *before* it goes into mainline.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Name one thing windows is better than unix in?
Making money for Microsoft?
-- Randal L. Schwartz in <8cvi5t4c3t.fsf@gadget.cscaper.com>
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-23 22:30 ` Wolfgang Denk
@ 2008-02-23 23:19 ` Mike Frysinger
2008-02-23 23:42 ` Wolfgang Denk
0 siblings, 1 reply; 40+ messages in thread
From: Mike Frysinger @ 2008-02-23 23:19 UTC (permalink / raw)
To: u-boot
On Saturday 23 February 2008, Wolfgang Denk wrote:
> In message <200802231529.04407.vapier@gentoo.org> you wrote:
> > > Then that cannot go in now. We would break several rules at once:
> > > patches must be posted to the list first, and new stuff will get
> > > merged only when a merge window is open.
> >
> > since Blackfin literrally has never compiled/linked in the mainline
> > releases, theres no way i could break it even more. delaying these
> > updates to make mainline Blackfin u-boot usable is only that: delay.
>
> Still the patches need to be reviewed first.
fair enough. i'd point out for the cpu unification, the patch is 400k and i'm
not about to go splitting it up just so the mailing list will accept it. if
people actually care, they can read the diff in the git tree.
> > as for posting the patches to the list, how do you know whether to merge
> > it directly or pull from a repo ?
>
> In cases like this one, where there is a custodian who caresa about
> the topic of the patches, I wait for his pull request and then pull
> from the repo. The posting of the patches is primarily for giving
> others a chance to review the stuff *before* it goes into mainline.
so for all Blackfin patches, i'll post them and people may review them, but
you wont merge them until i put them into my tree for you to pull ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080223/7896d95e/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-23 23:19 ` Mike Frysinger
@ 2008-02-23 23:42 ` Wolfgang Denk
2008-02-24 0:09 ` Mike Frysinger
0 siblings, 1 reply; 40+ messages in thread
From: Wolfgang Denk @ 2008-02-23 23:42 UTC (permalink / raw)
To: u-boot
In message <200802231819.56414.vapier@gentoo.org> you wrote:
>
> > Still the patches need to be reviewed first.
>
> fair enough. i'd point out for the cpu unification, the patch is 400k and i'm
> not about to go splitting it up just so the mailing list will accept it. if
> people actually care, they can read the diff in the git tree.
Mike, this is not the way you are supposed to react - not as a norman
developer, and escpecially not as a custodian.
You want the stuff to go in, so please make it easy for us to review
it.
> > In cases like this one, where there is a custodian who caresa about
> > the topic of the patches, I wait for his pull request and then pull
> > from the repo. The posting of the patches is primarily for giving
> > others a chance to review the stuff *before* it goes into mainline.
>
> so for all Blackfin patches, i'll post them and people may review them, but
> you wont merge them until i put them into my tree for you to pull ?
Correct - except that you already have those patches in some git
repository, because otherwise you could not use git-format-patch and
git-send-email to prepare resp. to send the patches.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The price of curiosity is a terminal experience.
- Terry Pratchett, _The Dark Side of the Sun_
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-23 23:42 ` Wolfgang Denk
@ 2008-02-24 0:09 ` Mike Frysinger
2008-02-24 0:36 ` Wolfgang Denk
0 siblings, 1 reply; 40+ messages in thread
From: Mike Frysinger @ 2008-02-24 0:09 UTC (permalink / raw)
To: u-boot
On Saturday 23 February 2008, Wolfgang Denk wrote:
> In message <200802231819.56414.vapier@gentoo.org> you wrote:
> > > Still the patches need to be reviewed first.
> >
> > fair enough. i'd point out for the cpu unification, the patch is 400k
> > and i'm not about to go splitting it up just so the mailing list will
> > accept it. if people actually care, they can read the diff in the git
> > tree.
>
> Mike, this is not the way you are supposed to react - not as a norman
> developer, and escpecially not as a custodian.
>
> You want the stuff to go in, so please make it easy for us to review
> it.
if you force us to use the mailing list (which is fine), then it should be
easy to use the mailing list (which if i recall from the last time this came
up, you arent going to change).
> > > In cases like this one, where there is a custodian who caresa about
> > > the topic of the patches, I wait for his pull request and then pull
> > > from the repo. The posting of the patches is primarily for giving
> > > others a chance to review the stuff *before* it goes into mainline.
> >
> > so for all Blackfin patches, i'll post them and people may review them,
> > but you wont merge them until i put them into my tree for you to pull ?
>
> Correct - except that you already have those patches in some git
> repository, because otherwise you could not use git-format-patch and
> git-send-email to prepare resp. to send the patches.
i'm not sure what you're trying to say. of course git-format-patch only works
on patches that have been committed to a repo.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080223/715316d1/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-24 0:09 ` Mike Frysinger
@ 2008-02-24 0:36 ` Wolfgang Denk
2008-02-24 1:18 ` Mike Frysinger
0 siblings, 1 reply; 40+ messages in thread
From: Wolfgang Denk @ 2008-02-24 0:36 UTC (permalink / raw)
To: u-boot
In message <200802231909.43013.vapier@gentoo.org> you wrote:
>
> > You want the stuff to go in, so please make it easy for us to review
> > it.
>
> if you force us to use the mailing list (which is fine), then it should be
This is the rules we agreed on. See
http://www.denx.de/wiki/UBoot/DevelopmentProcess and
http://www.denx.de/wiki/UBoot/Patches
> easy to use the mailing list (which if i recall from the last time this came
> up, you arent going to change).
What do you mean? The size limit? We have a soft-limit of 40 k and a
hard limit of 100k and a description for exceptions in
http://www.denx.de/wiki/UBoot/Patches
But this doesn't save you from splitting your changes into small,
orthogonal pieces.
> > > so for all Blackfin patches, i'll post them and people may review them,
> > > but you wont merge them until i put them into my tree for you to pull ?
> >
> > Correct - except that you already have those patches in some git
> > repository, because otherwise you could not use git-format-patch and
> > git-send-email to prepare resp. to send the patches.
>
> i'm not sure what you're trying to say. of course git-format-patch only works
> on patches that have been committed to a repo.
I tried to answer your question - you asked "you wont merge them
until i put them into my tree" and I confirmed this (as this is what
a pull request from a custodian means). Your question seemed to imply
that this was additional effort for you, so I tried to explain that
it ain't, as you will already have such a repository ready to pull
from (or rather to push into the custodia's repo from where I will
pull) because you needed it to send the patches to the mailing list,
and without sending patches first you cannot send a pull request.
Sorry if this sounds complicated. See
http://www.denx.de/wiki/UBoot/DevelopmentProcess for details.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Once upon a time, "PC" meant "personal computer". Now it seems to
only mean "Prisoner of Bill". Alas! All my PCs run Unix, and those
include Intel, Sparc, and other processors.
-- Tom "Bring back the non-PC meaning of `PC'" Christiansen
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-24 0:36 ` Wolfgang Denk
@ 2008-02-24 1:18 ` Mike Frysinger
2008-02-24 1:26 ` Wolfgang Denk
0 siblings, 1 reply; 40+ messages in thread
From: Mike Frysinger @ 2008-02-24 1:18 UTC (permalink / raw)
To: u-boot
On Saturday 23 February 2008, Wolfgang Denk wrote:
> In message <200802231909.43013.vapier@gentoo.org> you wrote:
> > > You want the stuff to go in, so please make it easy for us to review
> > > it.
> >
> > easy to use the mailing list (which if i recall from the last time this
> > came up, you arent going to change).
>
> What do you mean? The size limit? We have a soft-limit of 40 k and a
> hard limit of 100k and a description for exceptions in
> http://www.denx.de/wiki/UBoot/Patches
>
> But this doesn't save you from splitting your changes into small,
> orthogonal pieces.
the last thread i read you said it was going to stay at 40k and 100k was not
going to happen.
> > > > so for all Blackfin patches, i'll post them and people may review
> > > > them, but you wont merge them until i put them into my tree for you
> > > > to pull ?
> > >
> > > Correct - except that you already have those patches in some git
> > > repository, because otherwise you could not use git-format-patch and
> > > git-send-email to prepare resp. to send the patches.
> >
> > i'm not sure what you're trying to say. of course git-format-patch only
> > works on patches that have been committed to a repo.
>
> I tried to answer your question - you asked "you wont merge them
> until i put them into my tree" and I confirmed this (as this is what
> a pull request from a custodian means). Your question seemed to imply
> that this was additional effort for you, so I tried to explain that
> it ain't, as you will already have such a repository ready to pull
> from (or rather to push into the custodia's repo from where I will
> pull) because you needed it to send the patches to the mailing list,
> and without sending patches first you cannot send a pull request.
i know how to format/email patches from git. i just wasnt sure you were
telling/implying anything i didnt already know. it would seem not.
> Sorry if this sounds complicated. See
> http://www.denx.de/wiki/UBoot/DevelopmentProcess for details.
i dont think it's complicated at all
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080223/f2afe38b/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-24 1:18 ` Mike Frysinger
@ 2008-02-24 1:26 ` Wolfgang Denk
0 siblings, 0 replies; 40+ messages in thread
From: Wolfgang Denk @ 2008-02-24 1:26 UTC (permalink / raw)
To: u-boot
In message <200802232018.35652.vapier@gentoo.org> you wrote:
>
> the last thread i read you said it was going to stay at 40k and 100k was not
> going to happen.
I said I would not change the list's message size limit on the
SourceForge server. Messages that exceed this size (40 kB = that's
what I called soft-limit) need moderation. I will check these, and
unless they are reasonable and below 100 kB I've been ACKimg these
since that discussion.
> i dont think it's complicated at all
Great. Then please play by those rules.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I can't understand it. I can't even understand the people who can
understand it. - Queen Juliana of the Netherlands.
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
@ 2008-06-01 2:59 Mike Frysinger
2008-06-01 19:45 ` Wolfgang Denk
0 siblings, 1 reply; 40+ messages in thread
From: Mike Frysinger @ 2008-06-01 2:59 UTC (permalink / raw)
To: u-boot
The following changes since commit 1f1554841a4c8e069d331176f0c3059fb2bb8280:
Wolfgang Denk (1):
Merge branch 'master' of /home/wd/git/u-boot/custodians
are available in the git repository at:
git://www.denx.de/git/u-boot-blackfin.git review
Mike Frysinger (14):
Blackfin: make baud calculation more accurate
Blackfin: fix up UART status bit handling
Blackfin: fix up comment about CONFIG_BFIN_BOOT_MODE
Blackfin: punt unused page_descriptor_table_size definition
Blackfin: punt mem_init.h since it is no longer used
Blackfin: update cpu header definitions from latest Blackfin toolchain
Blackfin: punt unused BF533-STAMP definitions
Blackfin: resurrect BF533-STAMP video splash driver
Blackfin: touchup BF561-EZKIT board file
Blackfin: set default boot SPI CS for BF538/BF539
Blackfin: kill conversion warnings in async nand driver
Blackfin: tighten up post memory coding style
Blackfin: overhaul i2c driver
Blackfin: implement go/boote wrappers
board/bf533-stamp/Makefile | 9 +-
board/bf533-stamp/bf533-stamp.c | 1 -
board/bf533-stamp/bf533-stamp.h | 3 -
board/bf533-stamp/video.c | 257 +++++++++++++
board/bf533-stamp/video.h | 25 ++
board/bf537-stamp/nand.c | 8 +-
board/bf537-stamp/post-memory.c | 23 +-
board/bf537-stamp/spi_flash.c | 4 +-
board/bf561-ezkit/bf561-ezkit.c | 6 +-
cpu/blackfin/Makefile | 2 +-
cpu/blackfin/i2c.c | 444 -----------------------
cpu/blackfin/initcode.c | 2 +-
cpu/blackfin/serial.c | 72 +++-
cpu/blackfin/serial.h | 8 +-
drivers/i2c/Makefile | 1 +
drivers/i2c/bfin-twi_i2c.c | 298 +++++++++++++++
include/asm-blackfin/blackfin-config-pre.h | 4 +-
include/asm-blackfin/cplb.h | 7 +-
include/asm-blackfin/mach-common/bits/lockbox.h | 70 ++--
include/asm-blackfin/mem_init.h | 321 ----------------
include/configs/bf533-ezkit.h | 2 +-
include/configs/bf533-stamp.h | 2 +-
include/configs/bf537-stamp.h | 43 +--
lib_blackfin/Makefile | 2 +-
lib_blackfin/{bootm.c => boot.c} | 20 +
25 files changed, 738 insertions(+), 896 deletions(-)
create mode 100644 board/bf533-stamp/video.c
create mode 100644 board/bf533-stamp/video.h
delete mode 100644 cpu/blackfin/i2c.c
create mode 100644 drivers/i2c/bfin-twi_i2c.c
delete mode 100644 include/asm-blackfin/mem_init.h
rename lib_blackfin/{bootm.c => boot.c} (80%)
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-06-01 2:59 Mike Frysinger
@ 2008-06-01 19:45 ` Wolfgang Denk
2008-06-01 20:54 ` Mike Frysinger
0 siblings, 1 reply; 40+ messages in thread
From: Wolfgang Denk @ 2008-06-01 19:45 UTC (permalink / raw)
To: u-boot
In message <1212289153-5117-1-git-send-email-vapier@gentoo.org> you wrote:
> The following changes since commit 1f1554841a4c8e069d331176f0c3059fb2bb8280:
> Wolfgang Denk (1):
> Merge branch 'master' of /home/wd/git/u-boot/custodians
>
> are available in the git repository at:
>
> git://www.denx.de/git/u-boot-blackfin.git review
What's that? I cannot make heads nor tails out of this.
If this was intended to be a pull request as the subject suggests,
then I see a few problems with that:
* minor problem: please provide stuff for pull requests in the
"master" branch, as requested in
http://www.denx.de/wiki/view/UBoot/CustodianGitTrees#BEFORE_Requesting_a_Pull
* Major problem: only changes should be used in custodian trees and
submitted as part of a pull request, that had been submitted to the
mailing list before, and for whioch at least no negative comments
have been raised. But in this list here:
> Mike Frysinger (14):
> Blackfin: make baud calculation more accurate
> Blackfin: fix up UART status bit handling
> Blackfin: fix up comment about CONFIG_BFIN_BOOT_MODE
> Blackfin: punt unused page_descriptor_table_size definition
> Blackfin: punt mem_init.h since it is no longer used
> Blackfin: update cpu header definitions from latest Blackfin toolchain
> Blackfin: punt unused BF533-STAMP definitions
> Blackfin: resurrect BF533-STAMP video splash driver
> Blackfin: touchup BF561-EZKIT board file
> Blackfin: set default boot SPI CS for BF538/BF539
> Blackfin: kill conversion warnings in async nand driver
> Blackfin: tighten up post memory coding style
> Blackfin: overhaul i2c driver
> Blackfin: implement go/boote wrappers
I can only find 2 of these in the mailing list archives:
04/18 Mike Frysinger [U-Boot-Users] [PATCH/review] Blackfin: overhaul i2c driver
Status: change request from Jean-Christophe Plagniol-Villard, no
feedback ever sent.
04/19 Mike Frysinger [U-Boot-Users] [PATCH] Blackfin: implement go/boote wrappers
Status: rejected by me. Discussion stopped on 04/21.
This is not how you are supposed to work as a custodian.
Please stick to the rules.
Pull rejected.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When in doubt, mumble; when in trouble, delegate; when in charge,
ponder. -- James H. Boren
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-06-01 19:45 ` Wolfgang Denk
@ 2008-06-01 20:54 ` Mike Frysinger
2008-06-01 21:54 ` Wolfgang Denk
0 siblings, 1 reply; 40+ messages in thread
From: Mike Frysinger @ 2008-06-01 20:54 UTC (permalink / raw)
To: u-boot
On Sunday 01 June 2008, Wolfgang Denk wrote:
> In message <1212289153-5117-1-git-send-email-vapier@gentoo.org> you wrote:
> > The following changes since commit
> > 1f1554841a4c8e069d331176f0c3059fb2bb8280: Wolfgang Denk (1):
> > Merge branch 'master' of /home/wd/git/u-boot/custodians
> >
> > are available in the git repository at:
> >
> > git://www.denx.de/git/u-boot-blackfin.git review
>
> What's that? I cannot make heads nor tails out of this.
>
> If this was intended to be a pull request as the subject suggests,
> then I see a few problems with that:
>
> * minor problem: please provide stuff for pull requests in the
> "master" branch, as requested in
sorry, i forgot about that
> * Major problem: only changes should be used in custodian trees and
> submitted as part of a pull request, that had been submitted to the
> mailing list before, and for whioch at least no negative comments
all of them have been posted. i dont know why you cant find them. in fact,
you responded to about half of them already.
> 04/18 Mike Frysinger [U-Boot-Users] [PATCH/review] Blackfin: overhaul
> i2c driver
>
> Status: change request from Jean-Christophe Plagniol-Villard, no
> feedback ever sent.
i implemented his suggestions
> 04/19 Mike Frysinger [U-Boot-Users] [PATCH] Blackfin: implement
> go/boote wrappers
>
> Status: rejected by me. Discussion stopped on 04/21.
stopped by you as well. i already explained why the current behavior is
broken for Blackfin. a poorly performing system is more desirable than a
broken/crashing one.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080601/eba848d0/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-06-01 20:54 ` Mike Frysinger
@ 2008-06-01 21:54 ` Wolfgang Denk
2008-06-01 22:02 ` Mike Frysinger
0 siblings, 1 reply; 40+ messages in thread
From: Wolfgang Denk @ 2008-06-01 21:54 UTC (permalink / raw)
To: u-boot
In message <200806011654.55700.vapier@gentoo.org> you wrote:
>
> > * Major problem: only changes should be used in custodian trees and
> > submitted as part of a pull request, that had been submitted to the
> > mailing list before, and for whioch at least no negative comments
>
> all of them have been posted. i dont know why you cant find them. in fact,
> you responded to about half of them already.
I expect that the entry in the pull request match the subject of some
posting. Is this not the case? If so, why not?
> > 04/18 Mike Frysinger [U-Boot-Users] [PATCH/review] Blackfin: overhaul
> > i2c driver
> >
> > Status: change request from Jean-Christophe Plagniol-Villard, no
> > feedback ever sent.
>
> i implemented his suggestions
You did not repost a cleaned up patch?
> > 04/19 Mike Frysinger [U-Boot-Users] [PATCH] Blackfin: implement
> > go/boote wrappers
> >
> > Status: rejected by me. Discussion stopped on 04/21.
>
> stopped by you as well. i already explained why the current behavior is
> broken for Blackfin. a poorly performing system is more desirable than a
> broken/crashing one.
So the status quo is that I rejected this patch. Why do you think you
could it add to the repo?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
GUIs are virtually useless. Learn tools. They're configurable,
scriptable, automatable, cron-able, interoperable, etc. We don't need
no brain-dead winslurping monolithic claptrap.
-- Tom Christiansen in 371140df at csnews
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-06-01 21:54 ` Wolfgang Denk
@ 2008-06-01 22:02 ` Mike Frysinger
2008-06-01 22:15 ` Wolfgang Denk
0 siblings, 1 reply; 40+ messages in thread
From: Mike Frysinger @ 2008-06-01 22:02 UTC (permalink / raw)
To: u-boot
On Sunday 01 June 2008, Wolfgang Denk wrote:
> In message <200806011654.55700.vapier@gentoo.org> you wrote:
> > > * Major problem: only changes should be used in custodian trees and
> > > submitted as part of a pull request, that had been submitted to the
> > > mailing list before, and for whioch at least no negative comments
> >
> > all of them have been posted. i dont know why you cant find them. in
> > fact, you responded to about half of them already.
>
> I expect that the entry in the pull request match the subject of some
> posting. Is this not the case? If so, why not?
i really have no idea what you're referring to
> > > 04/18 Mike Frysinger [U-Boot-Users] [PATCH/review] Blackfin:
> > > overhaul i2c driver
> > >
> > > Status: change request from Jean-Christophe Plagniol-Villard, no
> > > feedback ever sent.
> >
> > i implemented his suggestions
>
> You did not repost a cleaned up patch?
to "fix" whitespace ? no, i didnt
> > > 04/19 Mike Frysinger [U-Boot-Users] [PATCH] Blackfin: implement
> > > go/boote wrappers
> > >
> > > Status: rejected by me. Discussion stopped on 04/21.
> >
> > stopped by you as well. i already explained why the current behavior is
> > broken for Blackfin. a poorly performing system is more desirable than a
> > broken/crashing one.
>
> So the status quo is that I rejected this patch. Why do you think you
> could it add to the repo?
you rejected based on a misunderstanding of what the purpose of the change
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080601/7633ac6c/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-06-01 22:02 ` Mike Frysinger
@ 2008-06-01 22:15 ` Wolfgang Denk
2008-06-01 22:47 ` Mike Frysinger
0 siblings, 1 reply; 40+ messages in thread
From: Wolfgang Denk @ 2008-06-01 22:15 UTC (permalink / raw)
To: u-boot
In message <200806011802.41546.vapier@gentoo.org> you wrote:
>
> > I expect that the entry in the pull request match the subject of some
> > posting. Is this not the case? If so, why not?
>
> i really have no idea what you're referring to
You wrote:
Mike Frysinger (14):
Blackfin: make baud calculation more accurate
Blackfin: fix up UART status bit handling
Blackfin: fix up comment about CONFIG_BFIN_BOOT_MODE
Blackfin: punt unused page_descriptor_table_size definition
Blackfin: punt mem_init.h since it is no longer used
Blackfin: update cpu header definitions from latest Blackfin toolchain
Blackfin: punt unused BF533-STAMP definitions
Blackfin: resurrect BF533-STAMP video splash driver
Blackfin: touchup BF561-EZKIT board file
Blackfin: set default boot SPI CS for BF538/BF539
Blackfin: kill conversion warnings in async nand driver
Blackfin: tighten up post memory coding style
Blackfin: overhaul i2c driver
Blackfin: implement go/boote wrappers
I can find the subjects
overhaul i2c driver
and implement go/boote wrappers
in my archive.
I cannot find any of the other subjects. For example, where is any
posting that contained the string
fix up comment about CONFIG_BFIN_BOOT_MODE
?
> > > i implemented his suggestions
> >
> > You did not repost a cleaned up patch?
>
> to "fix" whitespace ? no, i didnt
So how should anybody know if this is the old patch, or if you did
any changes, and if so, which changes you did?
We don't want to pull unreviewed code.
> > So the status quo is that I rejected this patch. Why do you think you
> > could it add to the repo?
>
> you rejected based on a misunderstanding of what the purpose of the change
This is your opinion. Fact is, that I rejected it, and I did not
revert this reject, and I do not revert it now.
Actually it is pretty foul game to try and make me pull in stuff
which I explicitely rejected.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Karl's version of Parkinson's Law: Work expands to exceed the time
alloted it.
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-06-01 22:15 ` Wolfgang Denk
@ 2008-06-01 22:47 ` Mike Frysinger
2008-06-02 11:58 ` Wolfgang Denk
0 siblings, 1 reply; 40+ messages in thread
From: Mike Frysinger @ 2008-06-01 22:47 UTC (permalink / raw)
To: u-boot
On Sunday 01 June 2008, Wolfgang Denk wrote:
> In message <200806011802.41546.vapier@gentoo.org> you wrote:
> > > I expect that the entry in the pull request match the subject of some
> > > posting. Is this not the case? If so, why not?
> >
> > i really have no idea what you're referring to
>
> You wrote:
>
> Mike Frysinger (14):
> Blackfin: make baud calculation more accurate
> Blackfin: fix up UART status bit handling
> Blackfin: fix up comment about CONFIG_BFIN_BOOT_MODE
> Blackfin: punt unused page_descriptor_table_size definition
> Blackfin: punt mem_init.h since it is no longer used
> Blackfin: update cpu header definitions from latest Blackfin
> toolchain Blackfin: punt unused BF533-STAMP definitions
> Blackfin: resurrect BF533-STAMP video splash driver
> Blackfin: touchup BF561-EZKIT board file
> Blackfin: set default boot SPI CS for BF538/BF539
> Blackfin: kill conversion warnings in async nand driver
> Blackfin: tighten up post memory coding style
> Blackfin: overhaul i2c driver
> Blackfin: implement go/boote wrappers
>
> I can find the subjects
>
> overhaul i2c driver
> and implement go/boote wrappers
>
> in my archive.
>
> I cannot find any of the other subjects. For example, where is any
> posting that contained the string
>
> fix up comment about CONFIG_BFIN_BOOT_MODE
i can find them just fine with the same exact subject as well as your replies.
dont know what to tell you.
> > > > i implemented his suggestions
> > >
> > > You did not repost a cleaned up patch?
> >
> > to "fix" whitespace ? no, i didnt
>
> So how should anybody know if this is the old patch, or if you did
> any changes, and if so, which changes you did?
you have all the source in the open. there's no secrets. if you dont trust
me, you can check things by running `diff`.
> We don't want to pull unreviewed code.
for things that are substantial, reposting makes sense. you want to see
reposts of only whitespace changes ?
> > > So the status quo is that I rejected this patch. Why do you think you
> > > could it add to the repo?
> >
> > you rejected based on a misunderstanding of what the purpose of the
> > change
>
> This is your opinion. Fact is, that I rejected it, and I did not
> revert this reject, and I do not revert it now.
then follow up with what needs to happen. your proposals in the thread werent
a solution to the problem at hand and you've rejected anything ive tried to
do to appease you.
> Actually it is pretty foul game to try and make me pull in stuff
> which I explicitely rejected.
please refrain from such irrelevant comments
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080601/53797c89/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-06-01 22:47 ` Mike Frysinger
@ 2008-06-02 11:58 ` Wolfgang Denk
0 siblings, 0 replies; 40+ messages in thread
From: Wolfgang Denk @ 2008-06-02 11:58 UTC (permalink / raw)
To: u-boot
In message <200806011847.44121.vapier@gentoo.org> you wrote:
>
> > I cannot find any of the other subjects. For example, where is any
> > posting that contained the string
> >
> > fix up comment about CONFIG_BFIN_BOOT_MODE
>
> i can find them just fine with the same exact subject as well as your replies.
> dont know what to tell you.
Hm...
That's strange.
Now that I look on external achives, I can indeed for example fine
your "fix up comment about CONFIG_BFIN_BOOT_MODE" posting.
OK, got it. My mistake was to just "grep" for the Subjects, and this
didn't work because your subject lines were so long that they were
broken into two lines. Sory...
> > > > You did not repost a cleaned up patch?
> > >
> > > to "fix" whitespace ? no, i didnt
> >
> > So how should anybody know if this is the old patch, or if you did
> > any changes, and if so, which changes you did?
>
> you have all the source in the open. there's no secrets. if you dont trust
> me, you can check things by running `diff`.
This is not a question of trust, it's a question of rules. And the
rule is that the submitter of a patch is supposed to provide cleaned
up patches on the mailing list, and only when all issues have been
resolved the custodian should pick up the stuff.
> > We don't want to pull unreviewed code.
>
> for things that are substantial, reposting makes sense. you want to see
> reposts of only whitespace changes ?
Yes, definitely. How else should anybody know if you ever saw the
comments? please keep in mind that your situation is special as you
are both the submitter of the patch and the custodian who will pick
it up. Please try to act as if you were two different persons
communicating only over the mailing list.
> > This is your opinion. Fact is, that I rejected it, and I did not
> > revert this reject, and I do not revert it now.
>
> then follow up with what needs to happen. your proposals in the thread werent
> a solution to the problem at hand and you've rejected anything ive tried to
> do to appease you.
I don't have anything new to add to that topic. I wrote on Tue, 22 Apr
2008 00:19:25:
| I accept that the default settings may be not optimal for your use
| case, so please accept that your settings may not be always optimal,
| either. As a solution I imagine options to the "go" command. If you
| consider this too complicated for your users, please feel free to
| provide an alias in an envrionment variable which your users can
| "run".
...
| I see zero justification for a new command (and very little for
| changes to the implementation of "go", but I am still willing to
| allow for such extensions if you think it's necessary or more
| convenient).
> > Actually it is pretty foul game to try and make me pull in stuff
> > which I explicitely rejected.
>
> please refrain from such irrelevant comments
Please don't try to make me pull rejected code.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Anyone attempting to generate random numbers by deterministic means
is, of course, living in a state of sin." - John Von Neumann
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
@ 2008-03-30 19:54 Mike Frysinger
2008-04-07 22:09 ` Wolfgang Denk
0 siblings, 1 reply; 40+ messages in thread
From: Mike Frysinger @ 2008-03-30 19:54 UTC (permalink / raw)
To: u-boot
The following changes since commit 74d1e66d22dac91388bc538b2fe19f735edc5b82:
Bartlomiej Sieka (1):
Fix host tool build breakage, take two
are available in the git repository at:
git://www.denx.de/git/u-boot-blackfin.git master
Mike Frysinger (4):
Blackfin: BF537-stamp: cleanup spi flash driver
Blackfin: unify cpu and boot modes
Blackfin: cleanup lib_blackfin/cache.c
Blackfin: cleanup and overhaul common board init functions
Makefile | 5 +-
blackfin_config.mk | 3 +
board/bf533-ezkit/Makefile | 2 +-
board/bf533-ezkit/config.mk | 6 +-
board/bf533-ezkit/u-boot.lds.S | 208 ++++----
board/bf533-stamp/Makefile | 4 +-
board/bf533-stamp/config.mk | 6 +-
board/bf533-stamp/spi.c | 474 ----------------
board/bf533-stamp/spi_flash.c | 2 +
board/bf533-stamp/u-boot.lds.S | 206 ++++----
board/bf537-stamp/Makefile | 4 +-
board/bf537-stamp/bf537-stamp.c | 13 +-
board/bf537-stamp/config.mk | 10 +-
board/bf537-stamp/spi_flash.c | 815 +++++++++++++++++++++++++++
board/bf537-stamp/stm_m25p64.c | 516 -----------------
board/bf537-stamp/u-boot.lds.S | 258 ++++-----
board/bf561-ezkit/Makefile | 2 +-
board/bf561-ezkit/config.mk | 6 +-
board/bf561-ezkit/u-boot.lds.S | 209 ++++----
cpu/bf533/Makefile | 52 --
cpu/bf533/bf533_serial.h | 77 ---
cpu/bf533/cache.S | 129 -----
cpu/bf533/config.mk | 27 -
cpu/bf533/cpu.c | 213 -------
cpu/bf533/cpu.h | 66 ---
cpu/bf533/flush.S | 405 -------------
cpu/bf533/init_sdram.S | 183 ------
cpu/bf533/init_sdram_bootrom_initblock.S | 183 ------
cpu/bf533/interrupt.S | 244 --------
cpu/bf533/interrupts.c | 165 ------
cpu/bf533/ints.c | 112 ----
cpu/bf533/serial.c | 186 ------
cpu/bf533/start.S | 313 ----------
cpu/bf533/traps.c | 238 --------
cpu/bf533/video.c | 194 -------
cpu/bf533/video.h | 25 -
cpu/bf537/Makefile | 52 --
cpu/bf537/cache.S | 129 -----
cpu/bf537/config.mk | 27 -
cpu/bf537/cpu.c | 219 -------
cpu/bf537/cpu.h | 66 ---
cpu/bf537/flush.S | 403 -------------
cpu/bf537/init_sdram.S | 178 ------
cpu/bf537/init_sdram_bootrom_initblock.S | 203 -------
cpu/bf537/interrupt.S | 244 --------
cpu/bf537/interrupts.c | 170 ------
cpu/bf537/ints.c | 112 ----
cpu/bf537/serial.c | 186 ------
cpu/bf537/serial.h | 77 ---
cpu/bf537/start.S | 576 -------------------
cpu/bf537/start1.S | 38 --
cpu/bf537/traps.c | 239 --------
cpu/bf537/video.c | 194 -------
cpu/bf537/video.h | 25 -
cpu/bf561/Makefile | 52 --
cpu/bf561/cache.S | 129 -----
cpu/bf561/config.mk | 27 -
cpu/bf561/cpu.c | 212 -------
cpu/bf561/cpu.h | 66 ---
cpu/bf561/flush.S | 402 -------------
cpu/bf561/init_sdram.S | 175 ------
cpu/bf561/init_sdram_bootrom_initblock.S | 189 -------
cpu/bf561/interrupt.S | 244 --------
cpu/bf561/ints.c | 112 ----
cpu/bf561/serial.c | 188 ------
cpu/bf561/serial.h | 77 ---
cpu/bf561/start.S | 303 ----------
cpu/bf561/start1.S | 38 --
cpu/bf561/traps.c | 238 --------
cpu/bf561/video.c | 194 -------
cpu/bf561/video.h | 25 -
cpu/blackfin/.gitignore | 1 +
cpu/blackfin/Makefile | 65 +++
cpu/blackfin/bootrom-asm-offsets.awk | 41 ++
cpu/blackfin/bootrom-asm-offsets.c.in | 12 +
cpu/blackfin/cache.S | 61 ++
cpu/blackfin/cpu.c | 141 +++++
cpu/{bf533/start1.S => blackfin/cpu.h} | 28 +-
cpu/blackfin/flush.S | 230 ++++++++
cpu/{bf537 => blackfin}/i2c.c | 98 ++--
cpu/blackfin/initcode.c | 353 ++++++++++++
cpu/blackfin/interrupt.S | 33 ++
cpu/{bf561 => blackfin}/interrupts.c | 50 +-
cpu/blackfin/reset.c | 96 ++++
cpu/blackfin/serial.c | 124 ++++
cpu/blackfin/serial.h | 275 +++++++++
cpu/blackfin/start.S | 219 +++++++
cpu/blackfin/system_map.S | 18 +
cpu/blackfin/traps.c | 353 ++++++++++++
cpu/blackfin/watchdog.c | 25 +
include/asm-blackfin/blackfin-config-post.h | 6 +-
include/configs/bf533-ezkit.h | 44 +--
include/configs/bf533-stamp.h | 113 +----
include/configs/bf537-stamp.h | 104 +---
include/configs/bf561-ezkit.h | 40 +-
lib_blackfin/Makefile | 6 +-
lib_blackfin/bf533_string.c | 198 -------
lib_blackfin/blackfin_board.h | 64 ---
lib_blackfin/board.c | 429 ++++++++-------
lib_blackfin/bootm.c | 77 +--
lib_blackfin/cache.c | 35 +-
lib_blackfin/cache.h | 35 --
lib_blackfin/string.c | 203 +++++++
103 files changed, 3899 insertions(+), 11048 deletions(-)
delete mode 100644 board/bf533-stamp/spi.c
create mode 100644 board/bf533-stamp/spi_flash.c
create mode 100644 board/bf537-stamp/spi_flash.c
delete mode 100644 board/bf537-stamp/stm_m25p64.c
delete mode 100644 cpu/bf533/Makefile
delete mode 100644 cpu/bf533/bf533_serial.h
delete mode 100644 cpu/bf533/cache.S
delete mode 100644 cpu/bf533/config.mk
delete mode 100644 cpu/bf533/cpu.c
delete mode 100644 cpu/bf533/cpu.h
delete mode 100644 cpu/bf533/flush.S
delete mode 100644 cpu/bf533/init_sdram.S
delete mode 100644 cpu/bf533/init_sdram_bootrom_initblock.S
delete mode 100644 cpu/bf533/interrupt.S
delete mode 100644 cpu/bf533/interrupts.c
delete mode 100644 cpu/bf533/ints.c
delete mode 100644 cpu/bf533/serial.c
delete mode 100644 cpu/bf533/start.S
delete mode 100644 cpu/bf533/traps.c
delete mode 100644 cpu/bf533/video.c
delete mode 100644 cpu/bf533/video.h
delete mode 100644 cpu/bf537/Makefile
delete mode 100644 cpu/bf537/cache.S
delete mode 100644 cpu/bf537/config.mk
delete mode 100644 cpu/bf537/cpu.c
delete mode 100644 cpu/bf537/cpu.h
delete mode 100644 cpu/bf537/flush.S
delete mode 100644 cpu/bf537/init_sdram.S
delete mode 100644 cpu/bf537/init_sdram_bootrom_initblock.S
delete mode 100644 cpu/bf537/interrupt.S
delete mode 100644 cpu/bf537/interrupts.c
delete mode 100644 cpu/bf537/ints.c
delete mode 100644 cpu/bf537/serial.c
delete mode 100644 cpu/bf537/serial.h
delete mode 100644 cpu/bf537/start.S
delete mode 100644 cpu/bf537/start1.S
delete mode 100644 cpu/bf537/traps.c
delete mode 100644 cpu/bf537/video.c
delete mode 100644 cpu/bf537/video.h
delete mode 100644 cpu/bf561/Makefile
delete mode 100644 cpu/bf561/cache.S
delete mode 100644 cpu/bf561/config.mk
delete mode 100644 cpu/bf561/cpu.c
delete mode 100644 cpu/bf561/cpu.h
delete mode 100644 cpu/bf561/flush.S
delete mode 100644 cpu/bf561/init_sdram.S
delete mode 100644 cpu/bf561/init_sdram_bootrom_initblock.S
delete mode 100644 cpu/bf561/interrupt.S
delete mode 100644 cpu/bf561/ints.c
delete mode 100644 cpu/bf561/serial.c
delete mode 100644 cpu/bf561/serial.h
delete mode 100644 cpu/bf561/start.S
delete mode 100644 cpu/bf561/start1.S
delete mode 100644 cpu/bf561/traps.c
delete mode 100644 cpu/bf561/video.c
delete mode 100644 cpu/bf561/video.h
create mode 100644 cpu/blackfin/.gitignore
create mode 100644 cpu/blackfin/Makefile
create mode 100755 cpu/blackfin/bootrom-asm-offsets.awk
create mode 100644 cpu/blackfin/bootrom-asm-offsets.c.in
create mode 100644 cpu/blackfin/cache.S
create mode 100644 cpu/blackfin/cpu.c
rename cpu/{bf533/start1.S => blackfin/cpu.h} (68%)
create mode 100644 cpu/blackfin/flush.S
rename cpu/{bf537 => blackfin}/i2c.c (75%)
create mode 100644 cpu/blackfin/initcode.c
create mode 100644 cpu/blackfin/interrupt.S
rename cpu/{bf561 => blackfin}/interrupts.c (68%)
create mode 100644 cpu/blackfin/reset.c
create mode 100644 cpu/blackfin/serial.c
create mode 100644 cpu/blackfin/serial.h
create mode 100644 cpu/blackfin/start.S
create mode 100644 cpu/blackfin/system_map.S
create mode 100644 cpu/blackfin/traps.c
create mode 100644 cpu/blackfin/watchdog.c
delete mode 100644 lib_blackfin/bf533_string.c
delete mode 100644 lib_blackfin/blackfin_board.h
delete mode 100644 lib_blackfin/cache.h
create mode 100644 lib_blackfin/string.c
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-03-30 19:54 Mike Frysinger
@ 2008-04-07 22:09 ` Wolfgang Denk
0 siblings, 0 replies; 40+ messages in thread
From: Wolfgang Denk @ 2008-04-07 22:09 UTC (permalink / raw)
To: u-boot
In message <1206906865-30191-1-git-send-email-vapier@gentoo.org> you wrote:
> The following changes since commit 74d1e66d22dac91388bc538b2fe19f735edc5b82:
> Bartlomiej Sieka (1):
> Fix host tool build breakage, take two
>
> are available in the git repository at:
>
> git://www.denx.de/git/u-boot-blackfin.git master
>
> Mike Frysinger (4):
> Blackfin: BF537-stamp: cleanup spi flash driver
> Blackfin: unify cpu and boot modes
> Blackfin: cleanup lib_blackfin/cache.c
> Blackfin: cleanup and overhaul common board init functions
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I think there's a world market for about five computers.
-- attr. Thomas J. Watson (Chairman of the Board, IBM), 1943
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
@ 2008-03-16 2:33 Mike Frysinger
2008-03-18 21:17 ` Wolfgang Denk
0 siblings, 1 reply; 40+ messages in thread
From: Mike Frysinger @ 2008-03-16 2:33 UTC (permalink / raw)
To: u-boot
The following changes since commit b8aa57b5d4d69e8f0810a5e632c0ce41c0f46ee0:
Wolfgang Denk (1):
tools/setlocalversion: use a git-describe-ish format
are available in the git repository at:
git://www.denx.de/git/u-boot-blackfin.git master
Mike Frysinger (6):
Blackfin: move bootldr command to common code
Blackfin: convert BFIN_CPU to CONFIG_BFIN_CPU
Blackfin: update MAINTAINERS list
Blackfin: new cplbinfo command for viewing cplb tables
Blackfin: add proper ELF markings to some assembly functions
Blackfin: BF537-stamp: drop board-specific flash driver for CFI
MAINTAINERS | 15 ++
blackfin_config.mk | 6 +-
board/bf533-ezkit/bf533-ezkit.c | 7 -
board/bf533-stamp/bf533-stamp.c | 7 -
board/bf537-stamp/Makefile | 2 +-
board/bf537-stamp/bf537-stamp.c | 56 -----
board/bf537-stamp/flash-defines.h | 123 -----------
board/bf537-stamp/flash.c | 403 -------------------------------------
common/Makefile | 2 +
common/cmd_bootldr.c | 64 ++++++
common/cmd_cplbinfo.c | 59 ++++++
include/configs/bf533-ezkit.h | 9 +-
include/configs/bf533-stamp.h | 25 +--
include/configs/bf537-stamp.h | 43 ++---
include/configs/bf561-ezkit.h | 6 +-
lib_blackfin/board.c | 3 +-
lib_blackfin/memcmp.S | 3 +
lib_blackfin/memcpy.S | 3 +
lib_blackfin/memmove.S | 3 +
lib_blackfin/memset.S | 3 +
20 files changed, 187 insertions(+), 655 deletions(-)
delete mode 100644 board/bf537-stamp/flash-defines.h
delete mode 100644 board/bf537-stamp/flash.c
create mode 100644 common/cmd_bootldr.c
create mode 100644 common/cmd_cplbinfo.c
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-03-16 2:33 Mike Frysinger
@ 2008-03-18 21:17 ` Wolfgang Denk
0 siblings, 0 replies; 40+ messages in thread
From: Wolfgang Denk @ 2008-03-18 21:17 UTC (permalink / raw)
To: u-boot
In message <1205634823-27186-1-git-send-email-vapier@gentoo.org> you wrote:
> The following changes since commit b8aa57b5d4d69e8f0810a5e632c0ce41c0f46ee0:
> Wolfgang Denk (1):
> tools/setlocalversion: use a git-describe-ish format
>
> are available in the git repository at:
>
> git://www.denx.de/git/u-boot-blackfin.git master
>
> Mike Frysinger (6):
> Blackfin: move bootldr command to common code
> Blackfin: convert BFIN_CPU to CONFIG_BFIN_CPU
> Blackfin: update MAINTAINERS list
> Blackfin: new cplbinfo command for viewing cplb tables
Blackfin: add proper ELF markings to some assembly functions
> Blackfin: BF537-stamp: drop board-specific flash driver for CFI
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are two ways of constructing a software design. One way is to
make it so simple that there are obviously no deficiencies and the
other is to make it so complicated that there are no obvious defi-
ciencies. - Charles Anthony Richard Hoare
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
@ 2008-02-24 1:33 Wolfgang Denk
0 siblings, 0 replies; 40+ messages in thread
From: Wolfgang Denk @ 2008-02-24 1:33 UTC (permalink / raw)
To: u-boot
I wrote:
> I said I would not change the list's message size limit on the
> SourceForge server. Messages that exceed this size (40 kB = that's
> what I called soft-limit) need moderation. I will check these, and
> unless they are reasonable and below 100 kB I've been ACKimg these
> since that discussion.
s/unless they are/if they were/
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The joys of love made her human and the agonies of love destroyed
her.
-- Spock, "Requiem for Methuselah", stardate 5842.8
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot-Users] Pull request u-boot-blackfin.git
@ 2008-02-05 0:31 Mike Frysinger
2008-02-14 23:12 ` Wolfgang Denk
0 siblings, 1 reply; 40+ messages in thread
From: Mike Frysinger @ 2008-02-05 0:31 UTC (permalink / raw)
To: u-boot
This should get the Blackfin port building/running fine with mainline u-boot
and a bunch of cleanups in the process. More/bigger things to come ...
The following changes since commit 2c5260f711168d5ee91c70ddbb7d897013eefc46:
Ladislav Michl (1):
ARM: AT91RM9200 based boards config cleanup
are available in the git repository at:
git://www.denx.de/git/u-boot-blackfin.git master
Mike Frysinger (21):
add gitignores for Blackfin pieces
fix building on Blackfin as the assembler supports the .set syntax, not the = syntax, for assigning symbols
make smc91111_eeprom managment simpler by depending on the board configuration file rather than a hardcoded list of boards
add some more Blackfin docs
add the default Blackfin logo used by Blackfin boards with splash screens
add missing __raw versions of Blackfin read/write io functions
always pull in asm/blackfin.h for Blackfin ports
punt Blackfin VDSP headers and import sanitized/auto-generated ones
unify the Blackfin board targets
move -ffixed-P5 to blackfin_config.mk and drop unused -D__BLACKFIN__
add Blackfin-specific bdinfo command
add support for Blackfin symbol prefixes to examples
add Blackfin-specific reginfo command
use C code rather than inline assembly
add support for memory commands with Blackfin L1 instruction memory
interface to Blackfin on-chip One-Time-Programmable memory
move Blackfin cpu object list to respective cpu directories
scrub unused symbols
generate u-boot.ldr for Blackfin targets
rewrite/cleanup Blackfin RTC driver
new command for displaying strings at specified memory locations
.gitignore | 4 +
Makefile | 47 +-
README | 5 +
blackfin_config.mk | 10 +-
board/bf533-ezkit/.gitignore | 1 +
board/bf533-ezkit/flash.c | 8 +-
board/bf533-stamp/.gitignore | 1 +
board/bf533-stamp/bf533-stamp.c | 32 +-
board/bf533-stamp/spi.c | 39 +-
board/bf537-stamp/.gitignore | 1 +
board/bf537-stamp/bf537-stamp.c | 9 +-
board/bf537-stamp/ether_bf537.c | 6 +-
board/bf537-stamp/flash.c | 2 +-
board/bf537-stamp/nand.c | 4 +-
board/bf537-stamp/post-memory.c | 18 +-
board/bf537-stamp/stm_m25p64.c | 43 +-
board/bf561-ezkit/.gitignore | 1 +
board/bf561-ezkit/bf561-ezkit.c | 4 +-
common/Makefile | 2 +
common/cmd_bdinfo.c | 31 +
common/cmd_mem.c | 51 +-
common/cmd_otp.c | 163 +
common/cmd_reginfo.c | 45 +-
common/cmd_strings.c | 49 +
common/environment.c | 7 +-
config.mk | 1 +
cpu/bf533/Makefile | 4 +-
cpu/bf533/bf533_serial.h | 4 +-
cpu/bf533/cache.S | 3 +-
cpu/bf533/config.mk | 2 +-
cpu/bf533/cpu.c | 26 +-
cpu/bf533/init_sdram.S | 4 +
cpu/bf533/init_sdram_bootrom_initblock.S | 4 +
cpu/bf533/interrupt.S | 12 +-
cpu/bf533/interrupts.c | 4 -
cpu/bf533/ints.c | 37 +-
cpu/bf533/serial.c | 47 +-
cpu/bf533/start.S | 27 +-
cpu/bf533/traps.c | 25 +-
cpu/bf537/Makefile | 4 +-
cpu/bf537/cache.S | 1 +
cpu/bf537/config.mk | 2 +-
cpu/bf537/cpu.c | 26 +-
cpu/bf537/i2c.c | 45 +-
cpu/bf537/init_sdram.S | 4 +
cpu/bf537/init_sdram_bootrom_initblock.S | 4 +
cpu/bf537/interrupt.S | 12 +-
cpu/bf537/interrupts.c | 4 -
cpu/bf537/ints.c | 37 +-
cpu/bf537/serial.c | 57 +-
cpu/bf537/serial.h | 4 +-
cpu/bf537/start.S | 31 +-
cpu/bf537/traps.c | 25 +-
cpu/bf561/Makefile | 4 +-
cpu/bf561/cache.S | 1 +
cpu/bf561/config.mk | 2 +-
cpu/bf561/cpu.c | 26 +-
cpu/bf561/init_sdram.S | 4 +
cpu/bf561/init_sdram_bootrom_initblock.S | 4 +
cpu/bf561/interrupt.S | 12 +-
cpu/bf561/interrupts.c | 4 -
cpu/bf561/ints.c | 37 +-
cpu/bf561/serial.c | 47 +-
cpu/bf561/serial.h | 4 +-
cpu/bf561/start.S | 58 +-
cpu/bf561/traps.c | 25 +-
doc/README.blackfin | 46 +
doc/README.standalone | 21 +-
drivers/rtc/Makefile | 2 +-
drivers/rtc/bf5xx_rtc.c | 143 -
drivers/rtc/bfin_rtc.c | 117 +
examples/.gitignore | 1 +
examples/Makefile | 8 +-
examples/smc91111_eeprom | Bin 0 -> 13643 bytes
examples/smc91111_eeprom.c | 31 +-
include/.gitignore | 1 +
include/asm-blackfin/arch-bf533/anomaly.h | 172 -
include/asm-blackfin/arch-bf533/bf533_serial.h | 78 -
include/asm-blackfin/arch-bf533/bf5xx_rtc.h | 46 -
include/asm-blackfin/arch-bf533/cdefBF531.h | 24 -
include/asm-blackfin/arch-bf533/cdefBF532.h | 398 --
include/asm-blackfin/arch-bf533/cdefBF533.h | 24 -
include/asm-blackfin/arch-bf533/defBF531.h | 24 -
include/asm-blackfin/arch-bf533/defBF532.h | 1159 ----
include/asm-blackfin/arch-bf533/defBF533.h | 24 -
include/asm-blackfin/arch-bf533/defBF533_extn.h | 77 -
include/asm-blackfin/arch-bf533/irq.h | 137 -
include/asm-blackfin/arch-bf537/anomaly.h | 116 -
include/asm-blackfin/arch-bf537/bf537_serial.h | 78 -
include/asm-blackfin/arch-bf537/bf5xx_rtc.h | 46 -
include/asm-blackfin/arch-bf537/cdefBF534.h | 1009 ----
include/asm-blackfin/arch-bf537/cdefBF537.h | 186 -
include/asm-blackfin/arch-bf537/defBF534.h | 2627 ---------
include/asm-blackfin/arch-bf537/defBF537.h | 488 --
include/asm-blackfin/arch-bf537/defBF537_extn.h | 76 -
include/asm-blackfin/arch-bf537/irq.h | 94 -
include/asm-blackfin/arch-bf561/anomaly.h | 181 -
include/asm-blackfin/arch-bf561/bf561_serial.h | 78 -
include/asm-blackfin/arch-bf561/cdefBF561.h | 998 ----
include/asm-blackfin/arch-bf561/defBF561.h | 1941 -------
include/asm-blackfin/arch-bf561/defBF561_extn.h | 76 -
include/asm-blackfin/arch-bf561/irq.h | 137 -
include/asm-blackfin/arch-common/bf53x_rtc.h | 46 -
include/asm-blackfin/arch-common/cdefBF5xx.h | 40 -
include/asm-blackfin/arch-common/cdef_LPBlackfin.h | 160 -
include/asm-blackfin/arch-common/def_LPBlackfin.h | 445 --
include/asm-blackfin/bfin_logo_230x230.h | 2377 ++++++++
include/asm-blackfin/bitops.h | 32 +-
include/asm-blackfin/blackfin-config-post.h | 72 +
include/asm-blackfin/blackfin-config-pre.h | 40 +
include/asm-blackfin/blackfin.h | 45 +-
include/asm-blackfin/blackfin_cdef.h | 67 +
include/asm-blackfin/blackfin_def.h | 105 +
include/asm-blackfin/blackfin_defs.h | 83 -
include/asm-blackfin/blackfin_local.h | 215 +
include/asm-blackfin/cplb.h | 47 +-
include/asm-blackfin/current.h | 40 -
include/asm-blackfin/entry.h | 133 +-
include/asm-blackfin/global_data.h | 2 -
include/asm-blackfin/hw_irq.h | 43 -
include/asm-blackfin/io-kernel.h | 138 -
include/asm-blackfin/io.h | 99 +-
include/asm-blackfin/irq.h | 142 -
include/asm-blackfin/linkage.h | 18 +-
.../mach-bf527/ADSP-EDN-BF52x-extended_cdef.h | 1507 +++++
.../mach-bf527/ADSP-EDN-BF52x-extended_def.h | 509 ++
include/asm-blackfin/mach-bf527/BF522_cdef.h | 344 ++
include/asm-blackfin/mach-bf527/BF522_def.h | 139 +
include/asm-blackfin/mach-bf527/BF523_cdef.h | 344 ++
include/asm-blackfin/mach-bf527/BF523_def.h | 139 +
include/asm-blackfin/mach-bf527/BF524_cdef.h | 851 +++
include/asm-blackfin/mach-bf527/BF524_def.h | 308 +
include/asm-blackfin/mach-bf527/BF525_cdef.h | 851 +++
include/asm-blackfin/mach-bf527/BF525_def.h | 308 +
include/asm-blackfin/mach-bf527/BF526_cdef.h | 1088 ++++
include/asm-blackfin/mach-bf527/BF526_def.h | 387 ++
include/asm-blackfin/mach-bf527/BF527_cdef.h | 1088 ++++
include/asm-blackfin/mach-bf527/BF527_def.h | 387 ++
include/asm-blackfin/mach-bf527/anomaly.h | 55 +
include/asm-blackfin/mach-bf527/def_local.h | 1 +
include/asm-blackfin/mach-bf527/ports.h | 127 +
include/asm-blackfin/mach-bf533/BF531_cdef.h | 14 +
include/asm-blackfin/mach-bf533/BF531_def.h | 23 +
include/asm-blackfin/mach-bf533/BF532_cdef.h | 14 +
include/asm-blackfin/mach-bf533/BF532_def.h | 23 +
include/asm-blackfin/mach-bf533/BF533_cdef.h | 14 +
include/asm-blackfin/mach-bf533/BF533_def.h | 29 +
include/asm-blackfin/mach-bf533/anomaly.h | 263 +
include/asm-blackfin/mach-bf533/def_local.h | 1 +
include/asm-blackfin/mach-bf533/ports.h | 26 +
.../mach-bf537/ADSP-EDN-BF534-extended_cdef.h | 2755 +++++++++
.../mach-bf537/ADSP-EDN-BF534-extended_def.h | 925 +++
include/asm-blackfin/mach-bf537/BF534_cdef.h | 14 +
include/asm-blackfin/mach-bf537/BF534_def.h | 29 +
include/asm-blackfin/mach-bf537/BF536_cdef.h | 251 +
include/asm-blackfin/mach-bf537/BF536_def.h | 102 +
include/asm-blackfin/mach-bf537/BF537_cdef.h | 251 +
include/asm-blackfin/mach-bf537/BF537_def.h | 108 +
include/asm-blackfin/mach-bf537/anomaly.h | 152 +
include/asm-blackfin/mach-bf537/def_local.h | 1 +
include/asm-blackfin/mach-bf537/ports.h | 78 +
.../mach-bf548/ADSP-EDN-BF542-extended_cdef.h | 4381 ++++++++++++++
.../mach-bf548/ADSP-EDN-BF542-extended_def.h | 1467 +++++
.../mach-bf548/ADSP-EDN-BF544-extended_cdef.h | 4975 ++++++++++++++++
.../mach-bf548/ADSP-EDN-BF544-extended_def.h | 1665 ++++++
.../mach-bf548/ADSP-EDN-BF547-extended_cdef.h | 3619 ++++++++++++
.../mach-bf548/ADSP-EDN-BF547-extended_def.h | 1213 ++++
.../mach-bf548/ADSP-EDN-BF548-extended_cdef.h | 5791 ++++++++++++++++++
.../mach-bf548/ADSP-EDN-BF548-extended_def.h | 1937 ++++++
.../mach-bf548/ADSP-EDN-BF549-extended_cdef.h | 6139 ++++++++++++++++++++
.../mach-bf548/ADSP-EDN-BF549-extended_def.h | 2053 +++++++
include/asm-blackfin/mach-bf548/BF541_cdef.h | 326 ++
include/asm-blackfin/mach-bf548/BF541_def.h | 118 +
include/asm-blackfin/mach-bf548/BF542_cdef.h | 326 ++
include/asm-blackfin/mach-bf548/BF542_def.h | 133 +
include/asm-blackfin/mach-bf548/BF544_cdef.h | 326 ++
include/asm-blackfin/mach-bf548/BF544_def.h | 133 +
include/asm-blackfin/mach-bf548/BF547_cdef.h | 326 ++
include/asm-blackfin/mach-bf548/BF547_def.h | 127 +
include/asm-blackfin/mach-bf548/BF548_cdef.h | 326 ++
include/asm-blackfin/mach-bf548/BF548_def.h | 133 +
include/asm-blackfin/mach-bf548/BF549_cdef.h | 326 ++
include/asm-blackfin/mach-bf548/BF549_def.h | 133 +
include/asm-blackfin/mach-bf548/anomaly.h | 99 +
include/asm-blackfin/mach-bf548/def_local.h | 1 +
include/asm-blackfin/mach-bf548/ports.h | 257 +
include/asm-blackfin/mach-bf561/BF561_cdef.h | 470 ++
include/asm-blackfin/mach-bf561/BF561_def.h | 175 +
include/asm-blackfin/mach-bf561/anomaly.h | 270 +
include/asm-blackfin/mach-bf561/def_local.h | 10 +
.../mach-common/ADSP-EDN-DUAL-CORE-extended_cdef.h | 1990 +++++++
.../mach-common/ADSP-EDN-DUAL-CORE-extended_def.h | 670 +++
.../asm-blackfin/mach-common/ADSP-EDN-core_cdef.h | 67 +
.../asm-blackfin/mach-common/ADSP-EDN-core_def.h | 29 +
.../mach-common/ADSP-EDN-extended_cdef.h | 1612 +++++
.../mach-common/ADSP-EDN-extended_def.h | 544 ++
include/asm-blackfin/mach-common/bits/bootrom.h | 218 +
include/asm-blackfin/mach-common/bits/core.h | 109 +
include/asm-blackfin/mach-common/bits/dma.h | 58 +
include/asm-blackfin/mach-common/bits/ebiu.h | 421 ++
include/asm-blackfin/mach-common/bits/emac.h | 220 +
include/asm-blackfin/mach-common/bits/eppi.h | 70 +
include/asm-blackfin/mach-common/bits/lockbox.h | 62 +
include/asm-blackfin/mach-common/bits/mpu.h | 116 +
include/asm-blackfin/mach-common/bits/otp.h | 72 +
include/asm-blackfin/mach-common/bits/pll.h | 96 +
include/asm-blackfin/mach-common/bits/ppi.h | 38 +
include/asm-blackfin/mach-common/bits/rtc.h | 42 +
include/asm-blackfin/mach-common/bits/spi.h | 67 +
include/asm-blackfin/mach-common/bits/sport.h | 89 +
include/asm-blackfin/mach-common/bits/timer.h | 78 +
include/asm-blackfin/mach-common/bits/trace.h | 19 +
include/asm-blackfin/mach-common/bits/twi.h | 77 +
include/asm-blackfin/mach-common/bits/uart.h | 98 +
include/asm-blackfin/mach-common/bits/watchdog.h | 19 +
include/asm-blackfin/machdep.h | 90 -
include/asm-blackfin/page_offset.h | 35 -
include/asm-blackfin/posix_types.h | 3 +
include/asm-blackfin/processor.h | 140 +-
include/asm-blackfin/segment.h | 46 -
include/asm-blackfin/setup.h | 87 -
include/asm-blackfin/string.h | 1 -
include/asm-blackfin/system.h | 167 +-
include/asm-blackfin/u-boot.h | 10 +-
include/asm-blackfin/uaccess.h | 205 -
include/asm-blackfin/virtconvert.h | 46 -
include/common.h | 3 +
lib_blackfin/bf533_string.c | 23 +-
lib_blackfin/cache.c | 6 +-
tools/easylogo/linux_blackfin.tga | Bin 0 -> 158718 bytes
230 files changed, 61691 insertions(+), 13133 deletions(-)
create mode 100644 board/bf533-ezkit/.gitignore
create mode 100644 board/bf533-stamp/.gitignore
create mode 100644 board/bf537-stamp/.gitignore
create mode 100644 board/bf561-ezkit/.gitignore
create mode 100644 common/cmd_otp.c
create mode 100644 common/cmd_strings.c
create mode 100644 doc/README.blackfin
delete mode 100644 drivers/rtc/bf5xx_rtc.c
create mode 100644 drivers/rtc/bfin_rtc.c
create mode 100755 examples/smc91111_eeprom
delete mode 100644 include/asm-blackfin/arch-bf533/anomaly.h
delete mode 100644 include/asm-blackfin/arch-bf533/bf533_serial.h
delete mode 100644 include/asm-blackfin/arch-bf533/bf5xx_rtc.h
delete mode 100644 include/asm-blackfin/arch-bf533/cdefBF531.h
delete mode 100644 include/asm-blackfin/arch-bf533/cdefBF532.h
delete mode 100644 include/asm-blackfin/arch-bf533/cdefBF533.h
delete mode 100644 include/asm-blackfin/arch-bf533/defBF531.h
delete mode 100644 include/asm-blackfin/arch-bf533/defBF532.h
delete mode 100644 include/asm-blackfin/arch-bf533/defBF533.h
delete mode 100644 include/asm-blackfin/arch-bf533/defBF533_extn.h
delete mode 100644 include/asm-blackfin/arch-bf533/irq.h
delete mode 100644 include/asm-blackfin/arch-bf537/anomaly.h
delete mode 100644 include/asm-blackfin/arch-bf537/bf537_serial.h
delete mode 100644 include/asm-blackfin/arch-bf537/bf5xx_rtc.h
delete mode 100644 include/asm-blackfin/arch-bf537/cdefBF534.h
delete mode 100644 include/asm-blackfin/arch-bf537/cdefBF537.h
delete mode 100644 include/asm-blackfin/arch-bf537/defBF534.h
delete mode 100644 include/asm-blackfin/arch-bf537/defBF537.h
delete mode 100644 include/asm-blackfin/arch-bf537/defBF537_extn.h
delete mode 100644 include/asm-blackfin/arch-bf537/irq.h
delete mode 100644 include/asm-blackfin/arch-bf561/anomaly.h
delete mode 100644 include/asm-blackfin/arch-bf561/bf561_serial.h
delete mode 100644 include/asm-blackfin/arch-bf561/cdefBF561.h
delete mode 100644 include/asm-blackfin/arch-bf561/defBF561.h
delete mode 100644 include/asm-blackfin/arch-bf561/defBF561_extn.h
delete mode 100644 include/asm-blackfin/arch-bf561/irq.h
delete mode 100644 include/asm-blackfin/arch-common/bf53x_rtc.h
delete mode 100644 include/asm-blackfin/arch-common/cdefBF5xx.h
delete mode 100644 include/asm-blackfin/arch-common/cdef_LPBlackfin.h
delete mode 100644 include/asm-blackfin/arch-common/def_LPBlackfin.h
create mode 100644 include/asm-blackfin/bfin_logo_230x230.h
create mode 100644 include/asm-blackfin/blackfin-config-post.h
create mode 100644 include/asm-blackfin/blackfin-config-pre.h
create mode 100644 include/asm-blackfin/blackfin_cdef.h
create mode 100644 include/asm-blackfin/blackfin_def.h
delete mode 100644 include/asm-blackfin/blackfin_defs.h
create mode 100644 include/asm-blackfin/blackfin_local.h
delete mode 100644 include/asm-blackfin/current.h
delete mode 100644 include/asm-blackfin/hw_irq.h
delete mode 100644 include/asm-blackfin/io-kernel.h
delete mode 100644 include/asm-blackfin/irq.h
create mode 100644 include/asm-blackfin/mach-bf527/ADSP-EDN-BF52x-extended_cdef.h
create mode 100644 include/asm-blackfin/mach-bf527/ADSP-EDN-BF52x-extended_def.h
create mode 100644 include/asm-blackfin/mach-bf527/BF522_cdef.h
create mode 100644 include/asm-blackfin/mach-bf527/BF522_def.h
create mode 100644 include/asm-blackfin/mach-bf527/BF523_cdef.h
create mode 100644 include/asm-blackfin/mach-bf527/BF523_def.h
create mode 100644 include/asm-blackfin/mach-bf527/BF524_cdef.h
create mode 100644 include/asm-blackfin/mach-bf527/BF524_def.h
create mode 100644 include/asm-blackfin/mach-bf527/BF525_cdef.h
create mode 100644 include/asm-blackfin/mach-bf527/BF525_def.h
create mode 100644 include/asm-blackfin/mach-bf527/BF526_cdef.h
create mode 100644 include/asm-blackfin/mach-bf527/BF526_def.h
create mode 100644 include/asm-blackfin/mach-bf527/BF527_cdef.h
create mode 100644 include/asm-blackfin/mach-bf527/BF527_def.h
create mode 100644 include/asm-blackfin/mach-bf527/anomaly.h
create mode 100644 include/asm-blackfin/mach-bf527/def_local.h
create mode 100644 include/asm-blackfin/mach-bf527/ports.h
create mode 100644 include/asm-blackfin/mach-bf533/BF531_cdef.h
create mode 100644 include/asm-blackfin/mach-bf533/BF531_def.h
create mode 100644 include/asm-blackfin/mach-bf533/BF532_cdef.h
create mode 100644 include/asm-blackfin/mach-bf533/BF532_def.h
create mode 100644 include/asm-blackfin/mach-bf533/BF533_cdef.h
create mode 100644 include/asm-blackfin/mach-bf533/BF533_def.h
create mode 100644 include/asm-blackfin/mach-bf533/anomaly.h
create mode 100644 include/asm-blackfin/mach-bf533/def_local.h
create mode 100644 include/asm-blackfin/mach-bf533/ports.h
create mode 100644 include/asm-blackfin/mach-bf537/ADSP-EDN-BF534-extended_cdef.h
create mode 100644 include/asm-blackfin/mach-bf537/ADSP-EDN-BF534-extended_def.h
create mode 100644 include/asm-blackfin/mach-bf537/BF534_cdef.h
create mode 100644 include/asm-blackfin/mach-bf537/BF534_def.h
create mode 100644 include/asm-blackfin/mach-bf537/BF536_cdef.h
create mode 100644 include/asm-blackfin/mach-bf537/BF536_def.h
create mode 100644 include/asm-blackfin/mach-bf537/BF537_cdef.h
create mode 100644 include/asm-blackfin/mach-bf537/BF537_def.h
create mode 100644 include/asm-blackfin/mach-bf537/anomaly.h
create mode 100644 include/asm-blackfin/mach-bf537/def_local.h
create mode 100644 include/asm-blackfin/mach-bf537/ports.h
create mode 100644 include/asm-blackfin/mach-bf548/ADSP-EDN-BF542-extended_cdef.h
create mode 100644 include/asm-blackfin/mach-bf548/ADSP-EDN-BF542-extended_def.h
create mode 100644 include/asm-blackfin/mach-bf548/ADSP-EDN-BF544-extended_cdef.h
create mode 100644 include/asm-blackfin/mach-bf548/ADSP-EDN-BF544-extended_def.h
create mode 100644 include/asm-blackfin/mach-bf548/ADSP-EDN-BF547-extended_cdef.h
create mode 100644 include/asm-blackfin/mach-bf548/ADSP-EDN-BF547-extended_def.h
create mode 100644 include/asm-blackfin/mach-bf548/ADSP-EDN-BF548-extended_cdef.h
create mode 100644 include/asm-blackfin/mach-bf548/ADSP-EDN-BF548-extended_def.h
create mode 100644 include/asm-blackfin/mach-bf548/ADSP-EDN-BF549-extended_cdef.h
create mode 100644 include/asm-blackfin/mach-bf548/ADSP-EDN-BF549-extended_def.h
create mode 100644 include/asm-blackfin/mach-bf548/BF541_cdef.h
create mode 100644 include/asm-blackfin/mach-bf548/BF541_def.h
create mode 100644 include/asm-blackfin/mach-bf548/BF542_cdef.h
create mode 100644 include/asm-blackfin/mach-bf548/BF542_def.h
create mode 100644 include/asm-blackfin/mach-bf548/BF544_cdef.h
create mode 100644 include/asm-blackfin/mach-bf548/BF544_def.h
create mode 100644 include/asm-blackfin/mach-bf548/BF547_cdef.h
create mode 100644 include/asm-blackfin/mach-bf548/BF547_def.h
create mode 100644 include/asm-blackfin/mach-bf548/BF548_cdef.h
create mode 100644 include/asm-blackfin/mach-bf548/BF548_def.h
create mode 100644 include/asm-blackfin/mach-bf548/BF549_cdef.h
create mode 100644 include/asm-blackfin/mach-bf548/BF549_def.h
create mode 100644 include/asm-blackfin/mach-bf548/anomaly.h
create mode 100644 include/asm-blackfin/mach-bf548/def_local.h
create mode 100644 include/asm-blackfin/mach-bf548/ports.h
create mode 100644 include/asm-blackfin/mach-bf561/BF561_cdef.h
create mode 100644 include/asm-blackfin/mach-bf561/BF561_def.h
create mode 100644 include/asm-blackfin/mach-bf561/anomaly.h
create mode 100644 include/asm-blackfin/mach-bf561/def_local.h
create mode 100644 include/asm-blackfin/mach-common/ADSP-EDN-DUAL-CORE-extended_cdef.h
create mode 100644 include/asm-blackfin/mach-common/ADSP-EDN-DUAL-CORE-extended_def.h
create mode 100644 include/asm-blackfin/mach-common/ADSP-EDN-core_cdef.h
create mode 100644 include/asm-blackfin/mach-common/ADSP-EDN-core_def.h
create mode 100644 include/asm-blackfin/mach-common/ADSP-EDN-extended_cdef.h
create mode 100644 include/asm-blackfin/mach-common/ADSP-EDN-extended_def.h
create mode 100644 include/asm-blackfin/mach-common/bits/bootrom.h
create mode 100644 include/asm-blackfin/mach-common/bits/core.h
create mode 100644 include/asm-blackfin/mach-common/bits/dma.h
create mode 100644 include/asm-blackfin/mach-common/bits/ebiu.h
create mode 100644 include/asm-blackfin/mach-common/bits/emac.h
create mode 100644 include/asm-blackfin/mach-common/bits/eppi.h
create mode 100644 include/asm-blackfin/mach-common/bits/lockbox.h
create mode 100644 include/asm-blackfin/mach-common/bits/mpu.h
create mode 100644 include/asm-blackfin/mach-common/bits/otp.h
create mode 100644 include/asm-blackfin/mach-common/bits/pll.h
create mode 100644 include/asm-blackfin/mach-common/bits/ppi.h
create mode 100644 include/asm-blackfin/mach-common/bits/rtc.h
create mode 100644 include/asm-blackfin/mach-common/bits/spi.h
create mode 100644 include/asm-blackfin/mach-common/bits/sport.h
create mode 100644 include/asm-blackfin/mach-common/bits/timer.h
create mode 100644 include/asm-blackfin/mach-common/bits/trace.h
create mode 100644 include/asm-blackfin/mach-common/bits/twi.h
create mode 100644 include/asm-blackfin/mach-common/bits/uart.h
create mode 100644 include/asm-blackfin/mach-common/bits/watchdog.h
delete mode 100644 include/asm-blackfin/machdep.h
delete mode 100644 include/asm-blackfin/page_offset.h
delete mode 100644 include/asm-blackfin/segment.h
delete mode 100644 include/asm-blackfin/setup.h
delete mode 100644 include/asm-blackfin/uaccess.h
delete mode 100644 include/asm-blackfin/virtconvert.h
create mode 100644 tools/easylogo/linux_blackfin.tga
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080204/53d89ee5/attachment.pgp
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot-Users] Pull request u-boot-blackfin.git
2008-02-05 0:31 Mike Frysinger
@ 2008-02-14 23:12 ` Wolfgang Denk
0 siblings, 0 replies; 40+ messages in thread
From: Wolfgang Denk @ 2008-02-14 23:12 UTC (permalink / raw)
To: u-boot
In message <200802041931.13102.vapier@gentoo.org> you wrote:
>
> This should get the Blackfin port building/running fine with mainline u-boot
> and a bunch of cleanups in the process. More/bigger things to come ...
>
> The following changes since commit 2c5260f711168d5ee91c70ddbb7d897013eefc46:
> Ladislav Michl (1):
> ARM: AT91RM9200 based boards config cleanup
>
> are available in the git repository at:
>
> git://www.denx.de/git/u-boot-blackfin.git master
Done. Thanks!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If the car industry behaved like the computer industry over the last
30 years, a Rolls-Royce would cost $5, get 300 miles per gallon, and
blow up once a year killing all passengers inside.
^ permalink raw reply [flat|nested] 40+ messages in thread
end of thread, other threads:[~2008-06-02 11:58 UTC | newest]
Thread overview: 40+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-23 6:17 [U-Boot-Users] Pull request u-boot-blackfin.git Mike Frysinger
2008-02-23 8:42 ` Wolfgang Denk
2008-02-23 8:59 ` Mike Frysinger
2008-02-23 19:36 ` Wolfgang Denk
2008-02-23 20:29 ` Mike Frysinger
2008-02-23 22:25 ` Haavard Skinnemoen
2008-02-23 23:17 ` Mike Frysinger
2008-02-23 23:50 ` Haavard Skinnemoen
2008-02-24 0:07 ` Mike Frysinger
2008-02-24 0:29 ` Wolfgang Denk
2008-02-24 0:39 ` Mike Frysinger
2008-02-24 1:22 ` Wolfgang Denk
2008-02-24 1:37 ` Mike Frysinger
2008-02-24 13:44 ` Wolfgang Denk
2008-02-24 0:35 ` Haavard Skinnemoen
2008-02-24 1:15 ` Mike Frysinger
2008-02-24 13:55 ` Jean-Christophe PLAGNIOL-VILLARD
2008-02-24 16:48 ` Mike Frysinger
2008-02-23 22:30 ` Wolfgang Denk
2008-02-23 23:19 ` Mike Frysinger
2008-02-23 23:42 ` Wolfgang Denk
2008-02-24 0:09 ` Mike Frysinger
2008-02-24 0:36 ` Wolfgang Denk
2008-02-24 1:18 ` Mike Frysinger
2008-02-24 1:26 ` Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2008-06-01 2:59 Mike Frysinger
2008-06-01 19:45 ` Wolfgang Denk
2008-06-01 20:54 ` Mike Frysinger
2008-06-01 21:54 ` Wolfgang Denk
2008-06-01 22:02 ` Mike Frysinger
2008-06-01 22:15 ` Wolfgang Denk
2008-06-01 22:47 ` Mike Frysinger
2008-06-02 11:58 ` Wolfgang Denk
2008-03-30 19:54 Mike Frysinger
2008-04-07 22:09 ` Wolfgang Denk
2008-03-16 2:33 Mike Frysinger
2008-03-18 21:17 ` Wolfgang Denk
2008-02-24 1:33 Wolfgang Denk
2008-02-05 0:31 Mike Frysinger
2008-02-14 23:12 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox