[U-Boot-Users] [PATCH] get_vfatname

[U-Boot-Users] [PATCH] get_vfatname

[michael]

Hi,

I find  a problem related to the get_vfatname function. This is my
proposal patch.

Regards Michael


-------------- next part --------------
A non-text attachment was scrubbed...
Name: is-a-valid-dir_slot-entry.patch
Type: text/x-patch
Size: 1014 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080327/f7d42805/attachment.bin 

[U-Boot-Users] [PATCH] get_vfatname

[Wolfgang Denk]

In message <47EB9C97.8030000@gandalf.sssup.it> you wrote:
>
> I find  a problem related to the get_vfatname function. This is my
> proposal patch.

What exactly is the preoblem? Is there a test case that can reproduce
the problem?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Never give in.  Never give in.  Never. Never. Never."
- Winston Churchill

[U-Boot-Users] [PATCH] get_vfatname

[michael]

Hi,
Wolfgang Denk wrote:
> In message <47EB9C97.8030000@gandalf.sssup.it> you wrote:
>   
>> I find  a problem related to the get_vfatname function. This is my
>> proposal patch.
>>     
>
> What exactly is the preoblem? Is there a test case that can reproduce
> the problem?
>   
My test case is a 64Mb CF. Maybe  I give you a link :) as soon as possible.

The problem is that the code doesn't look if the dir_slot contain a long 
name.
If doesn't contain a long name is a dir_entry and the name can be get by the
get_name function. I'm not an expert of vfat filesystem, I take a look 
to the
linux code and to experimental result. The block that is read by the
gc_getcluster function is not a dir_slot but a dir_entry.

Regards Michael

[U-Boot-Users] [PATCH] get_vfatname

[michael]

Hi,
Wolfgang Denk wrote:
> In message <47EB9C97.8030000@gandalf.sssup.it> you wrote:
>   
>> I find  a problem related to the get_vfatname function. This is my
>> proposal patch.
>>     
>
> What exactly is the preoblem? Is there a test case that can reproduce
> the problem?
>   
My test case is a 64Mb CF. Maybe  I give you a link :) as soon as possible.

The problem is that the code doesn't look if the dir_slot contain a long
name.
If doesn't contain a long name is a dir_entry and the name can be get by the
get_name function. I'm not an expert of vfat filesystem, I take a look
to the
linux code and to experimental result. The block that is read by the
gc_getcluster function is not a dir_slot but a dir_entry.

Regards Michael

[U-Boot-Users] [PATCH] get_vfatname

[Wolfgang Denk]

In message <47ECD868.3040600@gandalf.sssup.it> you wrote:
>
> > What exactly is the preoblem? Is there a test case that can reproduce
> > the problem?
> >   
> My test case is a 64Mb CF. Maybe  I give you a link :) as soon as possible.
> 
> The problem is that the code doesn't look if the dir_slot contain a long name.
> If doesn't contain a long name is a dir_entry and the name can be get by the
> get_name function. I'm not an expert of vfat filesystem, I take a look
> to the linux code and to experimental result. The block that is read by the
> gc_getcluster function is not a dir_slot but a dir_entry.

Well, maybe you can give me a test case?

Like some script to create the needed directories / files in a VFAT
file system which provokes the error?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A direct quote from the Boss: "We passed over a lot of good people to
get the ones we hired."

[U-Boot-Users] [PATCH] get_vfatname

[michael]

Wolfgang Denk wrote:
> In message <47ECD868.3040600@gandalf.sssup.it> you wrote:
>   
>>> What exactly is the preoblem? Is there a test case that can reproduce
>>> the problem?
>>>   
>>>       
>> My test case is a 64Mb CF. Maybe  I give you a link :) as soon as possible.
>>
>> The problem is that the code doesn't look if the dir_slot contain a long name.
>> If doesn't contain a long name is a dir_entry and the name can be get by the
>> get_name function. I'm not an expert of vfat filesystem, I take a look
>> to the linux code and to experimental result. The block that is read by the
>> gc_getcluster function is not a dir_slot but a dir_entry.
>>     
>
> Well, maybe you can give me a test case?
>
> Like some script to create the needed directories / files in a VFAT
> file system which provokes the error?
>
> Best regards,
>
> Wolfgang Denk
>
>   
I can give you an image that you can write on ide disk or on a Compact 
Flash.
Is ok?

Michael

[U-Boot-Users] [PATCH] get_vfatname

[Wolfgang Denk]

In message <47F22032.6040409@gandalf.sssup.it> you wrote:
>
> > Like some script to create the needed directories / files in a VFAT
> > file system which provokes the error?
...
> I can give you an image that you can write on ide disk or on a Compact 
> Flash.
> Is ok?

Actually I'd prefer a script to create such an image, but if this is
impossible (?) then an image will do, too.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Vulcans never bluff.
	-- Spock, "The Doomsday Machine", stardate 4202.1

[U-Boot-Users] [PATCH] get_vfatname

[michael]

Hi,
Wolfgang Denk wrote:
> In message <47F22032.6040409@gandalf.sssup.it> you wrote:
>   
>>> Like some script to create the needed directories / files in a VFAT
>>> file system which provokes the error?
>>>       
> ...
>   
>> I can give you an image that you can write on ide disk or on a Compact 
>> Flash.
>> Is ok?
>>     
>
> Actually I'd prefer a script to create such an image, but if this is
> impossible (?) then an image will do, too.
>   
Do you receive the link?

Regards
Michael