From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ARM: Use do_div() instead of division for "long long".
Date: Tue, 09 Sep 2008 23:07:47 +0200 [thread overview]
Message-ID: <20080909210747.854B02491D@gemini.denx.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0809092249070.9737@axis700.grange>
Dear Guennadi Liakhovetski,
In message <Pine.LNX.4.64.0809092249070.9737@axis700.grange> you wrote:
>
> > + do_div(val, (data[i][0] - data[i-1][0]));
>
> Looking at how do_div() is defined, and it handles its parameters
> carefully, one shouldn't need the extra parenthesis here, i.e.,
The are not exactly need (and actually a remainder from the copy &
paste of the old code), but on the other hand they don't hurt either,
and they make the argument's easier to parse, at least to my eyes.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Felson's Law:
To steal ideas from one person is plagiarism; to steal from
many is research.
next prev parent reply other threads:[~2008-09-09 21:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 22:59 [U-Boot] [PATCH] ARM: Use do_div() instead of division for "long long" Wolfgang Denk
2008-09-09 0:08 ` [U-Boot] [PATCH v2] " Wolfgang Denk
2008-09-09 0:08 ` [U-Boot] [PATCH] ARM: fix warning: target CPU does not support interworking Wolfgang Denk
2008-09-09 20:55 ` [U-Boot] [PATCH v2] ARM: Use do_div() instead of division for "long long" Guennadi Liakhovetski
2008-09-09 21:07 ` Wolfgang Denk [this message]
2008-09-11 22:24 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080909210747.854B02491D@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox