From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot-Users] [PATCH] cmd_spi: remove broken signed casting for display
Date: Tue, 14 Oct 2008 14:20:35 +0200 [thread overview]
Message-ID: <20081014122035.2DB1981C99C9@gemini.denx.de> (raw)
In-Reply-To: <1223982278-28497-1-git-send-email-vapier@gentoo.org>
Dear Mike Frysinger,
In message <1223982278-28497-1-git-send-email-vapier@gentoo.org> you wrote:
> Since we're working with unsigned data, you can't apply a signed pointer
> cast and then attempt to print the result. Otherwise you get wrong output
> when the sign bit is set like "0xFF" incorrectly extended to "0xFFFFFFFF".
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> common/cmd_spi.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Where a calculator on the ENIAC is equipped with 18,000 vacuum tubes
and weighs 30 tons, computers in the future may have only 1,000
vacuum tubes and weigh only 1/2 tons. - Popular Mechanics, March 1949
parent reply other threads:[~2008-10-14 12:20 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1223982278-28497-1-git-send-email-vapier@gentoo.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014122035.2DB1981C99C9@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox