public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [patch] make hello world example work for	at91sam9261ek and make readme clearer about this
Date: Sat, 6 Dec 2008 18:47:56 +0100	[thread overview]
Message-ID: <20081206174756.GI2977@game.jcrosoft.org> (raw)
In-Reply-To: <3efb10970812050041y199ae0a4la4f4c3589a07fa1@mail.gmail.com>

On 09:41 Fri 05 Dec     , Remy Bohmer wrote:
> Hello Jean-Christophe,
> 
> >> @@ -33,9 +33,13 @@ ifeq ($(ARCH),arm)
> >>  ifeq ($(BOARD),omap2420h4)
> >>  LOAD_ADDR = 0x80300000
> >>  else
> >> +ifeq ($(BOARD),at91sam9261ek)
> >> +LOAD_ADDR = 0x21400000
> >> +else
> >>  LOAD_ADDR = 0xc100000
> >>  endif
> >>  endif
> >> +endif
> > Honestly I'll prefer to remove all arch and board ifdef
> > and let the board ovewrite it or the arch if the board do not not already define it
> > and do here
> > LOAD_ADDR ?= <default addr>
> 
> I completely agree about this.
> This was just a minor patch I had on the stack for months and
> yesterday I just put them all out.
> The most important part of this patch was the comment about the
> load-addr in the readme file.
> Frequently questions misunderstandings about the examples appear on
> the ML, and the readme change would help there.
> 
> I can look into it later on to improve it and find a more generic
> solution. In the mean time, I do not think this patch hurts anyone ;-)
I'll prefer to wait because I've other patch in queued that will do the
samethink

Best Regards,
J.

  reply	other threads:[~2008-12-06 17:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04 21:25 [U-Boot] [patch] make hello world example work for at91sam9261ek and make readme clearer about this Remy Bohmer
2008-12-04 21:41 ` Jean-Christophe PLAGNIOL-VILLARD
2008-12-05  8:41   ` Remy Bohmer
2008-12-06 17:47     ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2008-12-15 23:11     ` Wolfgang Denk
2008-12-15 23:10 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081206174756.GI2977@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox