public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [patch u-boot-git 2/2] davinci_nand: cleanup II	(CONFIG_SYS_DAVINCI_BROKEN_ECC )
Date: Sat, 9 May 2009 16:21:17 +0200	[thread overview]
Message-ID: <20090509142117.GD13502@game.jcrosoft.org> (raw)
In-Reply-To: <200904281319.53898.david-b@pacbell.net>

On 13:19 Tue 28 Apr     , David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
> 
> Remove CONFIG_SYS_DAVINCI_BROKEN_ECC option.  It's not just nasty;
> it's also unused by any current boards, and doesn't even match the
> main U-Boot distributions from TI (which use soft ECC, or 4-bit ECC
> on newer chips that support it).
> 
> DaVinci GIT kernels since 2.6.24, and mainline Linux since 2.6.30,
> match non-BROKEN code paths for 1-bit HW ECC.  The BROKEN code paths
> do seem to partially match what MontaVista/TI kernels (4.0/2.6.10,
> and 5.0/2.6.18) do ... but only for small pages.  Large page support
> is really broken (and it's unclear just what software it was trying
> to match!), and the ECC layout was making three more bytes available
> for use by filesystem (or whatever) code.
> 
> Since this option itself seems broken, remove it.  Add a comment
> about the MV/TI compat issue, and the most straightforward way to
> address it (should someone really need to solve it).
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
Noone seems to worry about it

maybe cc the linux davinci ML to announce that we remove it could be nice
Scoot is it ok with you

Otherwise
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

Best Regards,
J.

  reply	other threads:[~2009-05-09 14:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28 20:19 [U-Boot] [patch u-boot-git 2/2] davinci_nand: cleanup II (CONFIG_SYS_DAVINCI_BROKEN_ECC ) David Brownell
2009-05-09 14:21 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-05-11 17:45   ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090509142117.GD13502@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox