public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] The omap3 L2 cache enable/disable function to omap3 dependent code
Date: Mon, 1 Jun 2009 12:49:41 -0500	[thread overview]
Message-ID: <20090601124941.c2be21af.kim.phillips@freescale.com> (raw)
In-Reply-To: <4A2405DD.7040106@googlemail.com>

On Mon, 01 Jun 2009 18:46:21 +0200
Dirk Behme <dirk.behme@googlemail.com> wrote:

> > 2. your signoff is in the correct location, however the commit message
> > is not.  It belongs above the line with the '---'.
> > 3. while making backreferences by pointing to messages in the list
> > archive is cool, they don't stand the test of time - the URL may one
> > day cease to exist.  So it is better to either reference a commitish in
> > the repository itself, or simply restate/copy the original data.
> 
> As long as references to the mailing list archive are in patch comment 
> (below --- as they are here) and don't go into git I think it's fine 
> to use them.

agreed (and I just did that myself in another thread) - it's just that,
in this case, the referenced subject matter needs to go in the git
commit message (see 2 above).

Kim

  reply	other threads:[~2009-06-01 17:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-01 10:14 [U-Boot] [PATCH] The omap3 L2 cache enable/disable function to omap3 dependent code Kim, Heung Jun
2009-06-01 15:54 ` Kim Phillips
2009-06-01 16:08   ` Kim, Heung Jun
2009-06-01 16:24     ` Kim Phillips
2009-06-01 16:46   ` Dirk Behme
2009-06-01 17:49     ` Kim Phillips [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-06-01  8:21 Kim, Heung Jun
2009-06-01  8:36 ` Kim, Heung Jun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090601124941.c2be21af.kim.phillips@freescale.com \
    --to=kim.phillips@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox