public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_mmc: make curr_device static
Date: Wed, 15 Jul 2009 11:09:05 -0400	[thread overview]
Message-ID: <200907151109.06151.vapier@gentoo.org> (raw)
In-Reply-To: <1245029722-14514-1-git-send-email-vapier@gentoo.org>

On Sunday 14 June 2009 21:35:21 Mike Frysinger wrote:
> The curr_device variable isn't used outside of cmd_mmc, so mark it static
> to avoid conflicts with other pieces of code (like sata which also exports
> a curr_device).  Otherwise we end up with stuff like:
> common/libcommon.a(cmd_sata.o):(.data.curr_device+0x0):
> 	multiple definition of `curr_device'
> common/libcommon.a(cmd_mmc.o):(.data.curr_device+0x0): first defined here

Wolfgang: were you waiting on some thing/one with this and the similar sata 
cmd change ?  or was it lost in the shuffle ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090715/470720c9/attachment.pgp 

  parent reply	other threads:[~2009-07-15 15:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-15  1:35 [U-Boot] [PATCH] cmd_mmc: make curr_device static Mike Frysinger
2009-06-15  1:35 ` [U-Boot] [PATCH] sata: namespace curr_device variable Mike Frysinger
2009-07-17 20:15   ` Wolfgang Denk
2009-07-15 15:09 ` Mike Frysinger [this message]
2009-07-17 20:16   ` [U-Boot] [PATCH] cmd_mmc: make curr_device static Wolfgang Denk
2009-07-17 20:14 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907151109.06151.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox