From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_mmc: make curr_device static
Date: Fri, 17 Jul 2009 22:16:15 +0200 [thread overview]
Message-ID: <20090717201615.3F980832E416@gemini.denx.de> (raw)
In-Reply-To: <200907151109.06151.vapier@gentoo.org>
Dear Mike Frysinger,
In message <200907151109.06151.vapier@gentoo.org> you wrote:
> --nextPart4747607.DNTvaE3gLs
> Content-Type: text/plain;
> charset="iso-8859-1"
> Content-Transfer-Encoding: quoted-printable
> Content-Disposition: inline
>
> On Sunday 14 June 2009 21:35:21 Mike Frysinger wrote:
> > The curr_device variable isn't used outside of cmd_mmc, so mark it static
> > to avoid conflicts with other pieces of code (like sata which also exports
> > a curr_device). Otherwise we end up with stuff like:
> > common/libcommon.a(cmd_sata.o):(.data.curr_device+0x0):
> > multiple definition of `curr_device'
> > common/libcommon.a(cmd_mmc.o):(.data.curr_device+0x0): first defined here
>
> Wolfgang: were you waiting on some thing/one with this and the similar sata
> cmd change ? or was it lost in the shuffle ?
It was not lost. I was waiting for a few hours to work on patches...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When all is said and done, more is said than done.
next prev parent reply other threads:[~2009-07-17 20:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 1:35 [U-Boot] [PATCH] cmd_mmc: make curr_device static Mike Frysinger
2009-06-15 1:35 ` [U-Boot] [PATCH] sata: namespace curr_device variable Mike Frysinger
2009-07-17 20:15 ` Wolfgang Denk
2009-07-15 15:09 ` [U-Boot] [PATCH] cmd_mmc: make curr_device static Mike Frysinger
2009-07-17 20:16 ` Wolfgang Denk [this message]
2009-07-17 20:14 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090717201615.3F980832E416@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox