public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] tools: mkimage (type=kwbimage) kirkwood boot image support
Date: Mon, 20 Jul 2009 17:05:38 +0200	[thread overview]
Message-ID: <20090720150538.CB74A832E416@gemini.denx.de> (raw)
In-Reply-To: <73173D32E9439E4ABB5151606C3E19E202DE09CE02@SC-VEXCH1.marvell.com>

Dear Prafulla Wadaskar,

In message <73173D32E9439E4ABB5151606C3E19E202DE09CE02@SC-VEXCH1.marvell.com> you wrote:
> 
> > > diff --git a/tools/kwbimage.h b/tools/kwbimage.h new file
> > mode 100644
> > > index 0000000..c54b701
> > > --- /dev/null
> > > +++ b/tools/kwbimage.h
> > > ...
> > > +/* typedefs */
> > > +typedef char s8;
> > > +typedef unsigned char u8;
> > > +
> > > +typedef int s32;
> > > +typedef unsigned int u32;
> > > +
> > > +typedef short s16;
> > > +typedef unsigned short u16;
> > > +
> > > +typedef long s64;
> > > +typedef unsigned long u64;
> >
> > Please get rid of these.
> 
> Hi Wolfgang
> Any suggestions for this?
> I could used <linux/types.h> or <asm/types.h> but these typedefs are ifdefe=
> d
> under __KERNEL_STRICT_NAMES and __KERNEL__.
> I don't wish to redefine or disturb them for kwbimage support

This is code running on the host, so please use ISO C99 standard types:
#include <stdint.h> and use int8_t, int16_t, int32_t, int64_t resp.
uint8_t, uint16_t, uint32_t, uint64_t.



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
        Ordnung ist die Lust der Vernunft,
        aber Unordnung die Wonne der Phantasie         - Paul Claudel

  reply	other threads:[~2009-07-20 15:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-19  1:45 [U-Boot] [PATCH 1/3] tools: mkimage: hdr_size used to facilitate customized support Prafulla Wadaskar
2009-07-18 21:33 ` Wolfgang Denk
2009-07-19  5:41   ` Prafulla Wadaskar
2009-07-19  1:45 ` [U-Boot] [PATCH 2/3] tools: mkimage (type=kwbimage) kirkwood boot image support Prafulla Wadaskar
2009-07-18 21:25   ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-20  6:55     ` Prafulla Wadaskar
2009-07-18 22:02   ` Wolfgang Denk
2009-07-19  5:27     ` Prafulla Wadaskar
2009-07-20  6:24       ` Prafulla Wadaskar
2009-07-20 15:05         ` Wolfgang Denk [this message]
2009-07-20 14:57       ` Wolfgang Denk
2009-07-22  7:20         ` Prafulla Wadaskar
2009-07-19  1:45   ` [U-Boot] [PATCH 3/3] Kirkwood: Sheevaplug: kwimage configuration Prafulla Wadaskar
2009-07-18 21:26     ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-19  4:41       ` Prafulla Wadaskar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090720150538.CB74A832E416@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox