From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mkconfig: deny messed up ARCH definition
Date: Sat, 31 Oct 2009 17:40:58 -0400 [thread overview]
Message-ID: <200910311740.59507.vapier@gentoo.org> (raw)
In-Reply-To: <1256998321-17270-1-git-send-email-nm@ti.com>
On Saturday 31 October 2009 10:12:01 Nishanth Menon wrote:
> Refuse to setup a platform if the command
> line ARCH= is not the same as the one
> required for the board. This prevents
> any user with prehistoric aliases from
> messing up thier builds
seems like excessive line wrapping
> +if [ ! -z "$ARCH" -a "$ARCH" != "$2" ]; then
is the !-z really needed ?
> + echo "ARCH=$ARCH while ${BOARD_NAME} arch=$2: fail"
should be sent to stderr: 1>&2
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091031/aca0c43e/attachment.pgp
next prev parent reply other threads:[~2009-10-31 21:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 14:12 [U-Boot] [PATCH] mkconfig: deny messed up ARCH definition Nishanth Menon
2009-10-31 21:40 ` Mike Frysinger [this message]
2009-10-31 22:20 ` Menon, Nishanth
2009-11-01 13:38 ` Mike Frysinger
2009-11-01 14:57 ` Wolfgang Denk
2009-11-02 15:26 ` Menon, Nishanth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910311740.59507.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox