From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH ARM 3/3] s3c24x0 code style changes
Date: Tue, 15 Dec 2009 13:24:54 +0100 [thread overview]
Message-ID: <20091215122454.70D54C88AF@gemini.denx.de> (raw)
In-Reply-To: <4B2548FF.6040103@fearnside-systems.co.uk>
Dear "kevin.morfitt at fearnside-systems.co.uk",
In message <4B2548FF.6040103@fearnside-systems.co.uk> you wrote:
> Cleans up the s3c24x0 header files by changing the upper case members
> of the s3c24x0 register structures to lower case and changing all code
> that uses these register structures.
The commit message should also mention that you convert the code into
using accessor functions.
You also perform a white space cleanup here. this may be a good thing
(opinions differ), but in any case it is an unrelated change that must
be performed in a separate commit.
Note that the same applies to the other two patches.
Please also re-check the resulting code. I think there are some way
too long lines, etc.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Is there a way to determine Yesterday's date using Unix utilities?
echo "what is yesterday's date?" | /bin/mail root
-- Randal L. Schwartz in <ukbuh2y982.fsf@julie.teleport.com>
next prev parent reply other threads:[~2009-12-15 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-13 20:05 [U-Boot] [PATCH ARM 3/3] s3c24x0 code style changes kevin.morfitt at fearnside-systems.co.uk
2009-12-15 12:24 ` Wolfgang Denk [this message]
2009-12-15 14:01 ` kevin.morfitt at fearnside-systems.co.uk
2009-12-15 17:00 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091215122454.70D54C88AF@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox