[U-Boot] [PATCH] config.mk: use different host compiler for OS X 10.6

[U-Boot] [PATCH] config.mk: use different host compiler for OS X 10.6

[Andreas Bießmann]

Compiling tools subdirectory on Mac OS X 10.6 (Snow Leopard) complains about
wrong syntax in system includes.

In file included from /usr/include/stdio.h:444,
                 from /Users/andreas/Documents/source/u-boot/include/compiler.h:26,
                 from /Users/andreas/Documents/source/u-boot/lib/crc32.c:15:
/usr/include/secure/_stdio.h:46: error: syntax error in macro parameter list

This can be fixed by reverting the workaround for prior OS X releases in
config.mk conditionally for OS X 10.6 (and maybe above, but this is not covered
by this patch).

Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
---
 config.mk |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/config.mk b/config.mk
index 73b5195..be8e895 100644
--- a/config.mk
+++ b/config.mk
@@ -64,9 +64,19 @@ HOSTSTRIP	= strip
 #
 
 ifeq ($(HOSTOS),darwin)
+# get major and minor product version (e.g. 10.6 for Snow Leopard)
+DARWIN_VERSION	= $(shell sw_vers -productVersion | cut -f 1,2 -d '.')
+
+# Snow Leopards build environmenthas no longer restrictions as described above
+# TODO find a solution to match versions greater than 10.6
+ifeq ($(DARWIN_VERSION),10.6)
+HOSTCC		= gcc
+else
 HOSTCC		= cc
 HOSTCFLAGS	+= -traditional-cpp
 HOSTLDFLAGS	+= -multiply_defined suppress
+endif
+
 else
 HOSTCC		= gcc
 endif
-- 
1.7.1

[U-Boot] [PATCH] config.mk: use different host compiler for OS X 10.6

[Mike Frysinger]

On Friday 21 May 2010 17:33:14 Andreas Bie?mann wrote:
>  ifeq ($(HOSTOS),darwin)
> +# get major and minor product version (e.g. 10.6 for Snow Leopard)
> +DARWIN_VERSION	= $(shell sw_vers -productVersion | cut -f 1,2 -d '.')
> +
> +# Snow Leopards build environmenthas no longer restrictions as described
> above +# TODO find a solution to match versions greater than 10.6
> +ifeq ($(DARWIN_VERSION),10.6)
> +HOSTCC		= gcc
> +else
>  HOSTCC		= cc
>  HOSTCFLAGS	+= -traditional-cpp
>  HOSTLDFLAGS	+= -multiply_defined suppress
> +endif

presumably this is going to remain true with 10.7+, so it'd probably make more 
sense to invert the check ... have the old code run with <=10.5
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100522/806954f1/attachment.pgp 

[U-Boot] [PATCH] config.mk: use different host compiler for OS X 10.6

[Andreas Bießmann]

2010/5/22 Mike Frysinger <vapier@gentoo.org>:
> presumably this is going to remain true with 10.7+, so it'd probably make more
> sense to invert the check ... have the old code run with <=10.5
Good point. I think I have a solution.
Please see Patch v2.

regards

Andreas