From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] include/compiler.h: remove redunandt declaration of errno
Date: Sat, 19 Jun 2010 21:58:40 -0400 [thread overview]
Message-ID: <201006192158.42049.vapier@gentoo.org> (raw)
In-Reply-To: <1276993233-12149-1-git-send-email-y>
On Saturday, June 19, 2010 20:20:33 y at denx.de wrote:
> Commit 37566090 "compiler.h: unify system ifdef cruft here" added both
> a "#include <errno.h>" and a "extern int errno;" to include/compiler.h
it isnt new code, it sucked the definitions out of random files that had these
and into one place
> which is causing build warnings for some systems, for example for the
> "netstar" board:
>
> In file included from /home/wd/git/u-boot/work/lib/crc32.c:15:
> include/compiler.h:28: warning: function declaration isn't a prototype
never seen that, but i imagine re-ordering the lines might address it as well
(extern then include)
> The declaration of "errno" should be redundant, as <errno.h> is
> supposed to provide a correct declaration, so drop it.
there are older systems where this isnt true, but ive never used one myself
and if we dont care about them (i dont), then this is fine
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100619/f9e6bbfb/attachment.pgp
next prev parent reply other threads:[~2010-06-20 1:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-20 0:20 [U-Boot] [PATCH] include/compiler.h: remove redunandt declaration of errno y at denx.de
2010-06-20 1:58 ` Mike Frysinger [this message]
2010-06-20 10:12 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006192158.42049.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox