From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/6] Update kirkwood egiga to allow dynamic phy addrs
Date: Thu, 24 Jun 2010 11:14:43 +0200 [thread overview]
Message-ID: <20100624091443.1905B1524EE@gemini.denx.de> (raw)
In-Reply-To: <1277370025-17281-1-git-send-email-tor@excito.com>
Dear Tor Krill,
In message <1277370025-17281-1-git-send-email-tor@excito.com> you wrote:
> Today the kirkwood egiga driver assumes that phy addresses are
> consecutive from a base address.
>
> Our new board design using this cpu unfortunately has a non contiguous
> addressing of its phys and thus doesn't work with the current
> implementation.
>
> This patchset updates the implementation to use an array of
> phy addresses as configuration.
>
> Tor Krill (6):
> Allow PHY addresses on kirkwood egiga to be non continuous.
> Convert Suen3 board to use array of phy addrs
> Convert Sheevaplug board to use array of phy addrs
> Convert OpenRD board to use array of phy addrs
> Convert Guruplug board to use array of phy addrs
> Convert rd6281a board to use array of phy addrs
Looking at what you are doing, things get even worse.
This is an atomic change. This must be submitted as a single patch,
not split into separate patches. Please read the documentatin and
stick to the rules!
NAK!!
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Successful and fortunate crime is called virtue. - Seneca
next prev parent reply other threads:[~2010-06-24 9:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 9:00 [U-Boot] [PATCH 0/6] Update kirkwood egiga to allow dynamic phy addrs Tor Krill
2010-06-24 9:00 ` [U-Boot] [PATCH 1/6] Allow PHY addresses on kirkwood egiga to be non continuous Tor Krill
2010-06-24 9:12 ` Wolfgang Denk
2010-06-24 9:00 ` [U-Boot] [PATCH 2/6] Convert Suen3 board to use array of phy addrs Tor Krill
2010-06-24 9:00 ` [U-Boot] [PATCH 3/6] Convert Sheevaplug " Tor Krill
2010-06-24 9:00 ` [U-Boot] [PATCH 4/6] Convert OpenRD " Tor Krill
2010-06-24 9:00 ` [U-Boot] [PATCH 5/6] Convert Guruplug " Tor Krill
2010-06-24 9:00 ` [U-Boot] [PATCH 6/6] Convert rd6281a " Tor Krill
2010-06-24 9:14 ` Wolfgang Denk [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-06-24 7:55 [U-Boot] [PATCH 0/6] Update kirkwood egiga to allow dynamic " Tor Krill
2010-06-24 9:11 ` Wolfgang Denk
2010-06-24 9:17 ` Tor Krill
2010-06-23 16:04 Tor Krill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100624091443.1905B1524EE@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox