From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] board/purple/flash.c: removed unneded test
Date: Sat, 31 Jul 2010 19:16:58 +0200 [thread overview]
Message-ID: <20100731171658.BD3C6152398@gemini.denx.de> (raw)
In-Reply-To: <1280585375-1613-1-git-send-email-fransmeulenbroeks@gmail.com>
Dear Frans Meulenbroeks,
In message <1280585375-1613-1-git-send-email-fransmeulenbroeks@gmail.com> you wrote:
> removed part of a test which tested for a var that did not change
> within the loop and hence was superfluous
Hm... if you check the code, you see that the other "references" to
this variable are not exactly making much sense either. And the
function does not return any useful error codes.
Looks as if this never was really thought to an end...
If you touch this file, we should throw out rcode completely.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In accord with UNIX philosophy, Perl gives you enough rope to hang
yourself. - L. Wall & R. L. Schwartz, _Programming Perl_
next prev parent reply other threads:[~2010-07-31 17:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-31 14:09 [U-Boot] [PATCH] board/purple/flash.c: removed unneded test Frans Meulenbroeks
2010-07-31 17:16 ` Wolfgang Denk [this message]
2010-07-31 18:28 ` Frans Meulenbroeks
2010-08-01 8:10 ` [U-Boot] [PATCH] board/purple/flash.c: removed unneded variable Frans Meulenbroeks
2010-08-01 9:01 ` Sergei Shtylyov
2010-08-01 11:31 ` Frans Meulenbroeks
2010-08-08 23:08 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100731171658.BD3C6152398@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox