public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add support for the MPC5121e USB Host controller.
Date: Thu, 14 Oct 2010 15:26:40 +0200	[thread overview]
Message-ID: <20101014132640.078A8134F26@gemini.denx.de> (raw)
In-Reply-To: <1282455714-12834-1-git-send-email-d.dusha@gmail.com>

Dear Damien Dusha,

In message <1282455714-12834-1-git-send-email-d.dusha@gmail.com> you wrote:
> Add support for the USB Host controller of the MPC5121e, based on the original patch by Francesco Rendine [1].
> 
> The patch configures the USB Host controller and the on-board UTMI phy, including the Freescale-specific registers as per the Linux kernel driver.
> 
> Tested on the MPC5121ADS platform with various USB mass storage devices.
> 
> [1] http://lists.denx.de/pipermail/u-boot/2009-June/055022.html
> 
> Signed-off-by: Damien Dusha <d.dusha@gmail.com>
> ---
>  arch/powerpc/include/asm/immap_512x.h   |    4 +
>  board/freescale/mpc5121ads/mpc5121ads.c |    4 +-
>  drivers/usb/host/ehci-fsl.c             |  137 ++++++++++++++++++++++++++++-
>  drivers/usb/host/ehci.h                 |    5 +
>  include/configs/mpc5121ads.h            |   22 +++++-
>  include/usb/ehci-fsl.h                  |  149 +++++++++++++++++++++++++------
>  6 files changed, 292 insertions(+), 29 deletions(-)

Sorry for the late response.

I have to admit that I really dislike the big "#ifndef CONFIG_MPC512X"
in drivers/usb/host/ehci-fsl.c - it covers basicly all of the existing
code, and adds an alternative implementation for MPC512x.  I think
this should better be handled in a separate driver.

Patch following.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The ultimate barrier is one's viewpoint.
                        - Terry Pratchett, _The Dark Side of the Sun_

  parent reply	other threads:[~2010-10-14 13:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-22  5:41 [U-Boot] [PATCH] Add support for the MPC5121e USB Host controller Damien Dusha
2010-08-24 15:05 ` Einar Már Björgvinsson
2010-08-25  0:45   ` Damien Dusha
2010-08-25 11:27     ` Einar Már Björgvinsson
2010-08-25 13:27       ` Damien Dusha
2010-10-14 13:26 ` Wolfgang Denk [this message]
2010-10-14 13:27 ` [U-Boot] [PATCH] MPC5121: Add USB EHCI support Wolfgang Denk
2010-10-14 16:27   ` Wolfgang Denk
2010-10-16  9:51     ` Remy Bohmer
2010-10-18 20:31   ` Wolfgang Denk
2010-10-24 14:14   ` [U-Boot] [PATCH] MPC8315ERD: fix build error Wolfgang Denk
2010-10-26 18:41     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101014132640.078A8134F26@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox