public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] net:Fix potential empty DHCP Parameter Request List
Date: Fri, 22 Oct 2010 11:31:21 +0200	[thread overview]
Message-ID: <20101022093121.BD6D21359B3@gemini.denx.de> (raw)
In-Reply-To: <1287736585-32489-1-git-send-email-r64343@freescale.com>

Dear Jason Liu,

In message <1287736585-32489-1-git-send-email-r64343@freescale.com> you wrote:
> From: Gray Remlin <g_remlin@rocketmail.com>
> 
> Can't get IP address with dhcp due to the dhcp server not
> allow the empty param list request under some network env
> 
> Signed-off-by: Gray Remlin <g_remlin@rocketmail.com>
> Signed-off-by: Jason Liu <r64343@freescale.com>
> ---
>  net/bootp.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)

What is the purpose of you reposting Gray's patch here, without any
comment?

Did you change it?  Did you test it? Or what??

You did not even keep the mail thread in place; please do not do that!

Please make sure to read
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions


In
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/86974/focus=86995
I asked you to test Gray's; you did not send a formal "Tested-by:"
notification, but ok.


But I really don't understand why you now repost this patch,
completely without any explanations?  Please elucidate.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The inappropriate cannot be beautiful.
             - Frank Lloyd Wright _The Future of Architecture_ (1953)

  reply	other threads:[~2010-10-22  9:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-22  8:36 [U-Boot] [PATCH 1/1] net:Fix potential empty DHCP Parameter Request List Jason Liu
2010-10-22  9:31 ` Wolfgang Denk [this message]
2010-10-22 11:48   ` Jason Liu
2010-10-22 12:04     ` Wolfgang Denk
2010-10-22 20:06 ` Mike Frysinger
2010-11-14  3:58   ` Jason Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101022093121.BD6D21359B3@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox