From: "Loïc Minier" <lool@dooz.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Don't add symlink in srctree when using an objtree
Date: Sat, 18 Dec 2010 17:07:11 +0100 [thread overview]
Message-ID: <20101218160711.GA4008@bee.dooz.org> (raw)
In-Reply-To: <20101217195131.321CC15192A@gemini.denx.de>
On Fri, Dec 17, 2010, Wolfgang Denk wrote:
> Thanks for the fix. A tiny change request, though:
> > - @rm -f $(obj)include/asm/proc $(obj)include/asm/arch $(obj)include/asm
> > + @rm -f $(obj)include/asm/proc $(obj)include/asm/arch
> > + @[ ! -h $(obj)include/asm ] || rm -f $(obj)include/asm
> > + @[ ! -d $(obj)include/asm ] || rmdir $(obj)include/asm
>
> Don't make it that complicated. Just change the line into
> @rm -fr$(obj)include/asm/proc $(obj)include/asm/arch $(obj)include/asm
I think I had this in my first version, but had an issue with it; I
will retest
> Also a question: how has this change been tested?
I did something like:
a) start fresh:
git clean -x -d
b) configure with or without objdir
make CROSS_COMPILE=arm-linux-gnueabi- O=$PWD/obj omap3_beagle_config
c) build (with or without objdir)
d) distclean (with or without objdir)
and tested combinations like a-d-d, a-b-d-d, a-b-c-d-d, then checked
whether any file remained with git clean -x -d -n
--
Lo?c Minier
next prev parent reply other threads:[~2010-12-18 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-05 0:52 [U-Boot] [PATCH] Don't add symlink in srctree when using an objtree Loïc Minier
2010-12-17 19:51 ` Wolfgang Denk
[not found] ` <20101217195131.321CC15192A@gemini.denx.de>
2010-12-18 16:07 ` Loïc Minier [this message]
2011-01-03 15:11 ` Loïc Minier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101218160711.GA4008@bee.dooz.org \
--to=lool@dooz.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox