From: "Loïc Minier" <lool@dooz.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Use sizeof(gd_t), not sizeof(struct global_data)
Date: Mon, 3 Jan 2011 18:00:50 +0100 [thread overview]
Message-ID: <20110103170050.GB10571@bee.dooz.org> (raw)
In-Reply-To: <AANLkTimorRHn9-jZEYZH=74is3sBT3JY4wiiPOm6jTmA@mail.gmail.com>
On Mon, Jan 03, 2011, Mike Frysinger wrote:
> why not change x86's global_data.h to define the struct ? all other
> arches define 'struct global_data'.
We could implement both fixes; there are two reasons I preferred
sending this fix instead of the one you mention:
* gd_t is used across the tree, while struct global_data is only used
in arch/*/include/asm/global_data.h headers
* the global_data.h header suggested that sizeof(gd_t) was an
acceptable construct in a comment:
GENERATED_GBL_DATA_SIZE > sizeof(gd_t)
I'll send an additional patch to also add struct global_data to
arch/i386/include/asm/global_data.h.
--
Lo?c Minier
next prev parent reply other threads:[~2011-01-03 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 15:47 [U-Boot] [PATCH] Use sizeof(gd_t), not sizeof(struct global_data) Loïc Minier
2011-01-03 16:35 ` Mike Frysinger
2011-01-03 17:00 ` Loïc Minier [this message]
2011-01-03 16:51 ` Wolfgang Denk
2011-01-03 17:03 ` Loïc Minier
2011-01-03 17:00 ` [U-Boot] [PATCH 2/2] i386: Define struct global_data as on other arches Loïc Minier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103170050.GB10571@bee.dooz.org \
--to=lool@dooz.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox